Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2241567ybx; Sat, 2 Nov 2019 15:06:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/elykD45ePvA6hx6EZ8O2zzLKEPUwN2hBgazrlO3F9uzQlm0xZJ9oUn/sltr/lxdSBXLo X-Received: by 2002:aa7:c80d:: with SMTP id a13mr20829931edt.59.1572732383116; Sat, 02 Nov 2019 15:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572732383; cv=none; d=google.com; s=arc-20160816; b=h5+1WQk96I+XOGs0qGF747c625mTJaAXpL4Docv8ujbAr0aWBxFLkjbC0uJTBHPraN h/DbHJ4iOscMTFWuGDG6CMFhh156QbFTlCvpwXpVDVSGOWajWef+WCHiNsPlUB9Ybp59 RL59LlFw6jeaCj/IYVqaORF3sIzjoVIpNtD6a8OGEvyuCZ5buOrpQuZuCmPA8M6iCSK8 /ZE2pmT2wc+kXLTO5It1PqVa1og56KCQmV1JSAGb6sL1AEcExx5zbJdbtCT7b8qNKXCB yYMa/j3OlwYa+t6IKHoiGV5AJiQgM7i9yn+ue6JzDx6h8wU63sdRGSJt7y0prTwObX57 wlOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=vTCI0qHuBsBb0Kz5RbeswHqlSoPusOsIRcj6s1CCCCU=; b=OsmoPyAoZC/GFyVXiYye/AO8VLePGO22v6X7H0nhf9oEJ/7gmoZnQFAJg3w5tE3xPo A83C1/k7ThxMpWqbbdU9QmWwGPyKwPAf4oNbvI133XmeMlk2Y+a5MBZzn+AbuP6FnRnR pyUXO0/tTeG20xkvdNYRHW+dRhK6enfWfosPMD73LUHC+nAKT7k21LrlgQ8SAGoGWrJk jo7kq8sQZM7z8keIpUShpPL6g7rgYks6dLqivXREqgqRH9tcjY6Jc7iA+6xz3+d7xfSK YT9m6rF6GotdM3mQowQV8gPf2jTnbsdVaw0I0h6tLMynjuFrrGesP6Iz06sUpDxD7+Bs +tnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="XRll/5vM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v11si4133321edl.371.2019.11.02.15.05.34; Sat, 02 Nov 2019 15:06:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b="XRll/5vM"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727317AbfKBWED (ORCPT + 99 others); Sat, 2 Nov 2019 18:04:03 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:35137 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727227AbfKBWEC (ORCPT ); Sat, 2 Nov 2019 18:04:02 -0400 Received: by mail-lf1-f66.google.com with SMTP id y6so9604579lfj.2 for ; Sat, 02 Nov 2019 15:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vTCI0qHuBsBb0Kz5RbeswHqlSoPusOsIRcj6s1CCCCU=; b=XRll/5vMVkjx89KHnpq6WWB0oHHUpEHdiN6O6XIbNfDvJpLq9nAHdnvBRo0qcYtdlV dDebt2KT4z/UoQ3oT2Pk6vWaFBXKSztN5uuRAQNTvGwr3g3jPPeee0pGSv+auGk2TkT9 /FiIqnPnAFsk6ubf5wFePKPpQhSpZfg8GPgik= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vTCI0qHuBsBb0Kz5RbeswHqlSoPusOsIRcj6s1CCCCU=; b=HnTk8AnauFuwQkWDJbbtCKcCRMHpiYZGtynHAuJ3u3WDLlx7ayqja2P7Lr5bGhmCE4 Lm2K7z/Twt/tGIvL6t9dZfvR0I98GD2G0cJG3VB6RRcTAZ7/qOo6JtBpUg8emhqnGxif 9w9fVTdYM07faIIIOSftEUdoeYAGMKRldsbX0wP+NXZAWIs20+d08IcpuYONJO68KG+o RgFKP3w+sTIKGdk+TXjqHQsSfUTRDNUmjAW+8W2MKyVrgHMjqVC1qioqRRMqJwrovc/l JUHOF/bJJ7OLT7t3G9Um8yHXnVLyQGQYZ9LdOcbyykoRC7jsjHorLwyY/VTTqA+3xVU8 HqtA== X-Gm-Message-State: APjAAAVmH8Wq5z9pKbe9eZdvg+z+diwdKpDd5m9e/W1JmUOaFhI7setr eb4ugQFMckwqbhUSylBMEgN3okL/9lk= X-Received: by 2002:a19:dc14:: with SMTP id t20mr11954271lfg.21.1572732240590; Sat, 02 Nov 2019 15:04:00 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id h16sm4244380ljb.10.2019.11.02.15.04.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Nov 2019 15:04:00 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id r7so5022543ljg.2 for ; Sat, 02 Nov 2019 15:04:00 -0700 (PDT) X-Received: by 2002:a2e:3e18:: with SMTP id l24mr13611187lja.48.1572732239632; Sat, 02 Nov 2019 15:03:59 -0700 (PDT) MIME-Version: 1.0 References: <25886.1572723272@warthog.procyon.org.uk> In-Reply-To: From: Linus Torvalds Date: Sat, 2 Nov 2019 15:03:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 11/10] pipe: Add fsync() support [ver #2] To: Andy Lutomirski Cc: David Howells , Konstantin Khlebnikov , Rasmus Villemoes , Greg Kroah-Hartman , Peter Zijlstra , Nicolas Dichtel , raven@themaw.net, Christian Brauner , keyrings@vger.kernel.org, linux-usb@vger.kernel.org, linux-block , LSM List , linux-fsdevel , Linux API , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 2, 2019 at 1:31 PM Andy Lutomirski wrote: > > Add in the fact that it=E2=80=99s not obvious that vmsplice *can* be used= correctly, and I=E2=80=99m wondering if we should just remove it or make i= t just do write() under the hood. Sure it can. Just don't modify the data you vmsplice. It's really that simp= le. That said, if we don't have any actual users, then we should look at removing it (maybe turning it into "write()" as you say). Not because it's hard to use, but simply because it probably doesn't have that many uses. Linus