Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 2 Nov 2019 16:53:09 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Matthew Wilcox <willy@infradead.org>,
        Johannes Weiner <hannes@cmpxchg.org>
cc:     hui yang <yanghui.def@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, mhocko@suse.com,
        dan.j.williams@intel.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: There should have an unit (kB)
In-Reply-To: <20191102205411.GB15832@bombadil.infradead.org>
Message-ID: <alpine.DEB.2.21.1911021646240.34229@chino.kir.corp.google.com>
References: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> <20191102205411.GB15832@bombadil.infradead.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2 Nov 2019, Matthew Wilcox wrote:

> On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote:
> > From: YangHui <yanghui.def@gmail.com>
> > 
> > -    printk(KERN_CONT " %ld", zone->lowmem_reserve[i]);
> > +    printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]);
> > Make it look more perfect
> 
> I don't think this is accounted in kilobytes though.  Isn't it the
> number of pages?
> 

Yes, it's not in KB.

Speaking of lowmem_reserve, however, the current default of 1/256 for both 
ZONE_DMA and ZONE_DMA32 seem too large as memory capacities of nodes 
increase.  We tune this to be much smaller so that we don't have as much 
memory set aside only for GFP_DMA or GFP_DMA32 allocations for that reason 
and because there is less reliance on lowmem for our configurations.

I'm wondering if the default should either be 1/256 up to a bounded memory 
capacity and then the excess is disregarded or whether the default itself 
should be changed to, say, 1024.

Looping in Johannes who may also have an opinion on this.