Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp2975967ybx;
        Sun, 3 Nov 2019 08:02:10 -0800 (PST)
X-Google-Smtp-Source: APXvYqxhjk8rRKFRqeoXDoSzwfTxFdWyD+5gJ41/X3/FoU2DmRRvsTgBdaia949I4jxNaO7GV51e
X-Received: by 2002:a50:ab01:: with SMTP id s1mr24839272edc.192.1572796930031;
        Sun, 03 Nov 2019 08:02:10 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1572796930; cv=none;
        d=google.com; s=arc-20160816;
        b=D+M00EwpZuV+CMyXEMtUFV/9//om2xL/zagk93RSuxMJ3E4moFXT3ZAwAx2+2VZd3e
         3+frMe62HgSpdEkSm4y5MYC0JZdldeBPEOQziXZffO5HdAUpktFpvbyIX5lSCSAz4iSX
         /lW39lmSp+dbw5b6BMT0BOOavNTe4SICGpKOhCcUin21dAy0yLD3KT5KXdav6E+uH9zU
         2tb9/3JbnQFnOurGgjkWNHfXkgrRdKGg/0ddp2Q8hveoBrE53HC/7LLaSjN7xb+ujTkg
         KzhUR+84GZiIQygmJ3QfPem1+rhLUMbFp8jK4pPKURX6KUnq3YuYz2YSh+fvFFDQg2In
         I6gQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:message-id:subject:cc:to:from:date;
        bh=nLMQK/lIs+3BSdpPNW9GHPJgDCKuiqT7g8Lr3KR5B2E=;
        b=wVezq/L7t1OY+Vb8LLTyiZXqBJOQx5zp8R821FAc9TTIwRoWlVdYV9p4C2PQ9bFbjm
         uMfBqpFeUpSCXdYbclAY7sXBvqGSF6Uo25bF22p8H+wO0JRlvlHkY8b5oqmrIGG9R3fN
         k1H0zkropQDPfCfAi6f8oMdAgiNmVi8UItvw56zxBZQUYM0sJiH6O9J5GS0eXjXhObGf
         lAWWYTvxCF5+KdHpd1gRJbZSV8rin4AV2YjE2R0SGPSEry9oB4IOEkACQ3AsguwboLRt
         jwW6NZSLDH/CMLzPvw+gPEonFjv2IQFTRRc+Ye79qRY0rwc2H59Ho9DPoFmzSajsn2/P
         4x5Q==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q30si6094733edb.372.2019.11.03.08.01.46;
        Sun, 03 Nov 2019 08:02:10 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727754AbfKCQAd (ORCPT <rfc822;414256we@gmail.com> + 99 others);
        Sun, 3 Nov 2019 11:00:33 -0500
Received: from mx2.suse.de ([195.135.220.15]:53164 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1727523AbfKCQAc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 3 Nov 2019 11:00:32 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.220.254])
        by mx1.suse.de (Postfix) with ESMTP id BC454B1F7;
        Sun,  3 Nov 2019 16:00:31 +0000 (UTC)
Date:   Sun, 3 Nov 2019 17:00:30 +0100
From:   Michal =?iso-8859-1?Q?Such=E1nek?= <msuchanek@suse.de>
To:     flameeyes@flameeyes.com
Cc:     axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: cdrom: make debug logging rely on pr_debug and debugfs only.
Message-ID: <20191103160030.GO1384@kitsune.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190826151640.5036-3-flameeyes@flameeyes.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

can you change cd_dbg to a macro that always prints the device name
using pr_debug instead of removing it?

That way you will get much more useful debug messages. That's also what
many other subsystems do.

Also consider adding some relevant mailinglist to cc. I think the
MAINTAINERS even specifies linux-scsi for cdrom and/or sr.

Thanks

Michal