Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3383798ybx; Sun, 3 Nov 2019 17:38:04 -0800 (PST) X-Google-Smtp-Source: APXvYqwpDsYQ/d3n07Uf/Btau0ClxaBHsBT0zh6rRibr61jVRjLtj0OUMZHDkn3fCWkhPReI4mWa X-Received: by 2002:a17:906:4f14:: with SMTP id t20mr20843851eju.239.1572831484467; Sun, 03 Nov 2019 17:38:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572831484; cv=none; d=google.com; s=arc-20160816; b=Pfdqr1yFaRrXLtttpOXO0UnHm3hQIFM1wRGEPN3ShhL2abmss/XRAslcgg7lpEXvbO O6QgiSqZmtmlbLfbGwoPHFuM+28lAl8x2xtGNpawzdzoWtFiacu7R15Jmsfb248NRHnm p5WtnzBDP2WaK0bmkafrDTFPeuXeZsuBtxx/x1z+DvI9OH5qr4hEeJpzDW716rpuT3l+ xzrmKZFaomsCYQaik/a7vMEdtsy18vkW7Tnp07NcIq6iIin9d7sgT50SEmgj7GAAGWlb zZMM/e4cM0iZj8K0/xhBHwR4hlv/vu7O6onTS4bINSpYfB5YtZsUv3yBDX6s0VCV6Z46 /zkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature; bh=qtzvVA2MBskNKmugBqLBOqoMyTc6I7YNxEu7frpOkKA=; b=ZYxjGrWDqBoLQmBPEYlBvHg1qOcEUvB4xfGYXQcfeeMidEGJpIHcwnI66jvqXQ34+n AxcyM4jPebwdetUgMxzF2NEkDGpf9qDWpDkNHR/2O5AKrMgYOily6fwAqtiNhAtxdQXt +DF6CLzd3WFCBg8AF52V7vX+7Vgbf2rk0kio9qTs+WuYXPgxql7W/rSjzuwJWlWL1O2/ AIJbeYCF395a8oNfwaK7nyFOyb7jLJ9+EgqpU2Uj5oTjc2IVIOXR6azb8dk2n1VlBuPH GghxRmrPBf07bvCa4pXP9Cqfje1cLqSeop/oFSJ2lYqEkuRRZsh366jJH+atZMfeADSU MQBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jhDKIXFq; dkim=pass header.i=@codeaurora.org header.s=default header.b=YcQBFh+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si1266145ejq.291.2019.11.03.17.37.41; Sun, 03 Nov 2019 17:38:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jhDKIXFq; dkim=pass header.i=@codeaurora.org header.s=default header.b=YcQBFh+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728816AbfKDBg3 (ORCPT + 99 others); Sun, 3 Nov 2019 20:36:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43664 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728288AbfKDBg2 (ORCPT ); Sun, 3 Nov 2019 20:36:28 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id BFF7360F62; Mon, 4 Nov 2019 01:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572831387; bh=YGs0HFAfG990zlYDTL4p8WA1cAzECcjOWDR3bJ3XKZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jhDKIXFq7FFLhT2bFAkJP4V5OuSa1moMRAY5PYD7CFzUAtE91fU8dvDSwrAgtZkaL 2ioo9dIBHjhaQOhMMusHBNxHz4bxRO5Gkd7nfEszxOcCqn2WMMEdtgnlfWFBnsQjbP mzJ9PVU+pzo3NjWGhtY4wDkMY3aJdNilQJEWODew= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0DA5560F62; Mon, 4 Nov 2019 01:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572831386; bh=YGs0HFAfG990zlYDTL4p8WA1cAzECcjOWDR3bJ3XKZ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YcQBFh+vhJLFoHS2BIrmR1+6M2XqBk/nDlK+WKlpH3aEAXiJkA5txG6EF4J9wIJBL 03pEp+4NLDR5EHIz6jHnt4aBvfrdGys8qrQa3YAUgVIkeQJSx1HQWFKRYJpQx3c+n6 ka4V3vNH+lu1iYqDB8dFHQ6/jBC1Fu/JKDxMX6Pg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0DA5560F62 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Venkat Gopalakrishnan , Subhash Jadavani , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Date: Sun, 3 Nov 2019 17:35:59 -0800 Message-Id: <1572831362-22779-5-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1572831362-22779-1-git-send-email-cang@codeaurora.org> References: <1572831362-22779-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ufshcd_print_host_regs() can be called by interrupt handler, but it may sleep due to ufshcd_dump_regs() allocates the dump buffer memory with flag GFP_KERNEL. Fix it by changing GFP_KERNEL to GFP_ATMOIC. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index f12f5a7..671ea2a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -117,7 +117,7 @@ int ufshcd_dump_regs(struct ufs_hba *hba, size_t offset, size_t len, if (offset % 4 != 0 || len % 4 != 0) /* keep readl happy */ return -EINVAL; - regs = kzalloc(len, GFP_KERNEL); + regs = kzalloc(len, GFP_ATOMIC); if (!regs) return -ENOMEM; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project