Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3385741ybx; Sun, 3 Nov 2019 17:40:57 -0800 (PST) X-Google-Smtp-Source: APXvYqyARHZEDU8LiqlphqDIFKp2NLjliAC24YJhTFfE/VD5tWznyCqWJ/UjumbJjNKgxVhapLcr X-Received: by 2002:a17:906:6bc4:: with SMTP id t4mr22265173ejs.1.1572831657440; Sun, 03 Nov 2019 17:40:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572831657; cv=none; d=google.com; s=arc-20160816; b=v0zJuj1mBFhFbHrGoyEbQtTH5IMRmpeo4rM5I/Jisxf5+QRWT/iyKyvBeud7Om7QqS YlFmzKeVPv4ZeLSojMPNz8A/ovCLOqeWXG3nEcn2CIpVcETWoBOqSkDKTMtmpRWxoN04 mncsd5UzbTd3T6we27OFpaKLgvI/6lWrkcOoPvHDAkwOtSGN8XmwUgAqI5o55CALhkTL uIgGdLgtsJoWgFmgLlBZgLRxj5EkWdBGlm1N7pS8kTFcZ35R4VgxR1QZ9cLvpxPvj8wH Cf88Xba5ONXWtQmWkrtlC1msCJkaW0fOrkQaefODI3hvF7qPcYT3+49cQak5X60m9VvY fAdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature; bh=1bmK2to2FScstNA3HbECb4jFH/zj1iPmkyOf2HbNdrY=; b=bdBrqJDr8SH46srWnas2hgNWnlR0nEldx2J+ZFEClv78k3ZXo+qOlFQ41O/Cj9ipPH rjzgh6HkEKSB/GD5Ix5YtY6rqIkQB/f+WWVNTHygl022+eMLaBC6sUzoKzlsnOH8S+// Ox4gdI+s5x9ZEG1EG2XEEESNwyHy01iGs/PyaF/anNLosOeZYBl3lkp1r7tGUoWTnANO Y0BMrtlQJuZdn+qO+xq4OLVcAN54nZ6zuNLqHhn1QPPhFLPYjC63dGPRBGTT2G3YHSY4 vvKj9tkoBKVG+UaA0g1QDSUqcJMU3/k3RI23QWSr9OdrPwpThau61DsVVRdqoiJ7mCNK WMTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=hUGX4eBg; dkim=pass header.i=@codeaurora.org header.s=default header.b=HEqxaCv0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bo21si256863edb.137.2019.11.03.17.40.34; Sun, 03 Nov 2019 17:40:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=hUGX4eBg; dkim=pass header.i=@codeaurora.org header.s=default header.b=HEqxaCv0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728840AbfKDBgi (ORCPT + 99 others); Sun, 3 Nov 2019 20:36:38 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:44000 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728288AbfKDBgi (ORCPT ); Sun, 3 Nov 2019 20:36:38 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 806F460FF7; Mon, 4 Nov 2019 01:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572831397; bh=A09Hg8Gubfo22q2oteGE+XWVmGvlbeGYL8Kj6AbIyz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hUGX4eBgih7IYdFJRZGAxdOwevNfqcALMufFEvPGpT6O9rBnxK8kADhEno0oIoh3A ykfkL5zQH1olk4dAYzq2o22dcKkK21h4z2u4H/vhVxxgbEUa6fbsfnuruZXzED7CmJ AQ8UlArKIIYZt1LzZ3N/eThrCm2rR5GLoFfCTwYg= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6D2B360FBA; Mon, 4 Nov 2019 01:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572831396; bh=A09Hg8Gubfo22q2oteGE+XWVmGvlbeGYL8Kj6AbIyz4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HEqxaCv0pvIUJeSnqfbD4ngOQBe/1NXxsLJJi8NNxUDHElaD3Y7h8aBXZ2UM9EkOh aLqYZqrdvnGesQg5ErHtqaF9ShR81nAhBECq2kgFk/fbRkkDnzYp9Fs2KpSh+HHvsg D2UgKehI056ktIiEFhc4XAdwrrugOrEwhPpXCAKU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6D2B360FBA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Venkat Gopalakrishnan , Subhash Jadavani , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 6/7] scsi: ufs: Abort gating if clock on request is pending Date: Sun, 3 Nov 2019 17:36:01 -0800 Message-Id: <1572831362-22779-7-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1572831362-22779-1-git-send-email-cang@codeaurora.org> References: <1572831362-22779-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Asutosh Das This change attempts to abort gating of clocks if a request to turn-on clocks is pending. This would in turn avoid turning OFF and back ON the clocks. Signed-off-by: Asutosh Das Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 8d1b04f..7a5a904 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1610,7 +1610,7 @@ static void ufshcd_gate_work(struct work_struct *work) * state to CLKS_ON. */ if (hba->clk_gating.is_suspended || - (hba->clk_gating.state == REQ_CLKS_ON)) { + (hba->clk_gating.state != REQ_CLKS_OFF)) { hba->clk_gating.state = CLKS_ON; trace_ufshcd_clk_gating(dev_name(hba->dev), hba->clk_gating.state); -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project