Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3395437ybx; Sun, 3 Nov 2019 17:58:16 -0800 (PST) X-Google-Smtp-Source: APXvYqxKrUKmp+N66zYUMqz2DubMzbDSvDXnZx4qivHxVfU2C59oJg8KMsEs5EJ4KTp7w3BCHlyD X-Received: by 2002:a50:ef17:: with SMTP id m23mr6273816eds.81.1572832695901; Sun, 03 Nov 2019 17:58:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572832695; cv=none; d=google.com; s=arc-20160816; b=ggea4uK11S/cr+CMtuQIIZMKniGiSUXgn+Kuocv3cizSyfx0CLC5BtwcLWbzg8NIGv d5bKkfJwtXbUd/9xViet3uztY3n+qMFibGo4hhugCEu+aRMFSaikwzzE9balaSnLEYmd nRA7A6gS8SjkNVX3ebAefBOyvNluDyRO/1fqoZc7Tf1AytzTob9XptgzpXNgN9X+Ns6t aw8qvikFz9M4R76DjAYwpnebiiZJ4dgU2b44dPRg4Z6wzshy0Hpq/zCfNUUsFmkExRAI SmNDI6BMiHdnnTDbq4IYOxFI3DDozZRUdlpOKpIBz+2pX+j6q39Aufce0z9+D9h5kdDL e6sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M3J9PbRvmVJogLWYFE/OaGmuZWeAspURKa8sY0ajlDw=; b=mq/bGrBN6bMuQA6SssFkA0KEgSFmTWtXq85mZq32BcygBBSku0uUSJbujiik+zhcRD MSrrR+zw9TP2nLdWXIBznIvoRD4DGVdbH9TA1hSehC7SiuMGlp4sq3PW5rQaydV12cz2 +1u4lDt+5klcZcPh+IUwAsJDQGSgloHrnNOjSsn19SQSJISRPWroKdCt6LKFfo4BqCy+ SaJEtO7sA9E9GEI7hDFNuHnMnoRKH/IZx/Xg3L492zzxwMSMt/36r7jWLk0lymcLwGew 1n5LosrZOkW++t11z76Do8htS3ZKNaNR1WEHK9lJBHg2t6dhDu7ojOQ6NkT8vneCFp8r BQmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g7ux+1p7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hh19si3716375ejb.209.2019.11.03.17.57.52; Sun, 03 Nov 2019 17:58:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=g7ux+1p7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728693AbfKDBLe (ORCPT + 99 others); Sun, 3 Nov 2019 20:11:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:56004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726310AbfKDBLe (ORCPT ); Sun, 3 Nov 2019 20:11:34 -0500 Received: from dragon (li1038-30.members.linode.com [45.33.96.30]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D51B4222D1; Mon, 4 Nov 2019 01:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572829894; bh=9Oa/sZWPuyk4aTCFfeZkZBXLeIf0WxdXMrii3wBcuv8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g7ux+1p7dJ82AZDTQVQlwRtgWpqrw6zDT2JfOLcqVufbOeo7EcafI7G1Yd2N651e2 R6fNuCO8+xM69qoefI+G8iWvOdQ4wsml+wVh3rmyqeuGq0HPqI5QLldccnDyzUY5xZ Os8xd3Ps+7tAydS7p90yPjgiK1k2yQKf39cD+R4M= Date: Mon, 4 Nov 2019 09:11:07 +0800 From: Shawn Guo To: Peng Fan Cc: "mturquette@baylibre.com" , "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , Abel Vesa , "kernel@pengutronix.de" , dl-linux-imx , Anson Huang , Jacky Bai , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Leonard Crestez Subject: Re: [PATCH V2] clk: imx: imx8mq: fix sys3_pll_out_sels Message-ID: <20191104011106.GD24620@dragon> References: <1572231902-30230-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572231902-30230-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 28, 2019 at 03:08:34AM +0000, Peng Fan wrote: > From: Peng Fan > > It is not correct that sys3_pll_out use sys2_pll1_ref_sel as parent. > > According to the current imx_clk_sccg_pll design, it uses both > bypass1/2, however set bypass2 as 1 is not correct, because it will > make sys[x]_pll_out use wrong parent and might access wrong registers. > > So correct bypass2 to 0 and fix sys3_pll_out_sels. > > Fixes: e9dda4af685f ("clk: imx: Refactor entire sccg pll clk") > Signed-off-by: Peng Fan Applied, thanks.