Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3418696ybx; Sun, 3 Nov 2019 18:35:05 -0800 (PST) X-Google-Smtp-Source: APXvYqzq0fjrCBAzpR0zRsUl9aRYoDQeYDjxnvDUrq2/ud9XH7BKEF0VUR1F6hvGFrLWgeWBY54B X-Received: by 2002:a17:906:70e:: with SMTP id y14mr5047512ejb.70.1572834905516; Sun, 03 Nov 2019 18:35:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572834905; cv=none; d=google.com; s=arc-20160816; b=H8Hwfm1Hszf4dC5U61p1cDLRLq1u1oeVDOvW3Z9zSIK/4NSAcfHTVcifGAa6ONMMJx m/Lun3FUKK+dpcsZgOyxJdOEvHF0MPZbT5HyNtoRfVS1Oxgi+r+x/2QNgXw07bBhSqV4 /neOgHLkmyjuqth+XZCe/8ADMAN5OfDZwr9Lb/6tSaEjhW+ORcUuQ4Da0uRVsKyU4Paz k5NHMV7OdOG3kqzIes40nai8GedgAch6O2/BQI1GvzgrvVwxVzw7KZoczfoeadIL8GwR vcTX4qVN05iCVjrWdsEgQ/efTUFUvrt1Q7h9Njqqs/JcSdQabLlWHBTjQSneaJT3eH6w NxdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:date:subject:cc:to:from; bh=JeIsIbHNKh4GBKBpTnh6Y1nAiUiYjh7D4Eyl68vb6l4=; b=zceU35dXShtse28b5PxMC4bKIhh0eA3PKr3Gv7HPoZc7/uUBN4d/vVhUF3hqGPT2SQ WQCjk6T69DA/Vlb9H3L9IdoWtBwAaCw/78v9lYgDAQWUZSIKtHIZ9rlXzmodaFQ4mEe8 fqlxJXmRWJOSDlBM7rTRMiPjvHm2Phj894UhUH1UmORAivvlP8niE7rNkMe+kxzghNzq o70zu5ohnnZtIvKzNOBgEFYPY96uVfUpfnwRSNU9+9brOWACcxhHRWFfjloUESwJo0XI HWy5OVvLjrvAonbah1hxZ+iwJ9K7rlWfCvP2fOTzg4wc94atsSpT7hV3pgHsHg5izgDT 4pSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si7450105edv.82.2019.11.03.18.34.41; Sun, 03 Nov 2019 18:35:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728747AbfKDCeI (ORCPT + 99 others); Sun, 3 Nov 2019 21:34:08 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:6938 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728227AbfKDCeH (ORCPT ); Sun, 3 Nov 2019 21:34:07 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA42WRNX099500 for ; Sun, 3 Nov 2019 21:34:06 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w27mb5kw7-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 03 Nov 2019 21:34:06 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Nov 2019 02:34:03 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 4 Nov 2019 02:33:59 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA42XwVO42664148 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Nov 2019 02:33:59 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5BB3A405C; Mon, 4 Nov 2019 02:33:58 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E6A8A405B; Mon, 4 Nov 2019 02:33:58 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 4 Nov 2019 02:33:58 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 19FF0A01D6; Mon, 4 Nov 2019 13:33:54 +1100 (AEDT) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Greg Kroah-Hartman , Thomas Gleixner , Qian Cai , Nicholas Piggin , Allison Randal , Andrew Morton , David Hildenbrand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 0/6] powerpc: convert cache asm to C Date: Mon, 4 Nov 2019 13:32:52 +1100 X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19110402-0028-0000-0000-000003B2590B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110402-0029-0000-0000-00002474AAAF Message-Id: <20191104023305.9581-1-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-04_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911040026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva This series addresses a few issues discovered in how we flush caches: 1. Flushes were truncated at 4GB, so larger flushes were incorrect. 2. Flushing the dcache in arch_add_memory was unnecessary This series also converts much of the cache assembler to C, with the aim of making it easier to maintain. Changelog: V5: - in "Chunk Calls to flush_dcache_range ...": - Honour the 'chunk' parameter - Rebase to latest master V4: - Split out VDSO patch - Pass/cast the correct types in 'powerpc: Convert flush_icache_range & friends to C' V3: - factor out chunking loop - Replace __asm__ __volatile__ with asm volatile - Replace flush_coherent_icache_or_return macro with flush_coherent_icache function - factor our invalidate_icache_range - Replace code duplicating clean_dcache_range() in __flush_dcache_icache() with a call to clean_dcache_range() - Remove redundant #ifdef CONFIG_44x - Fix preprocessor logic: #if !defined(CONFIG_PPC_8xx) & !defined(CONFIG_PPC64) - Added loop(1|2) to earlyclobbers in flush_dcache_icache_phys - Drop "Remove extern" patch - Replace 32 bit shifts in 64 bit VDSO with 64 bit ones V2: - Replace C implementation of flush_dcache_icache_phys() with inline assembler authored by Christophe Leroy - Add memory clobbers for iccci implementation - Give __flush_dcache_icache a real implementation, it can't just be a wrapper around flush_icache_range() - Remove PPC64_CACHES from misc_64.S - Replace code duplicating clean_dcache_range() in flush_icache_range() with a call to clean_dcache_range() - Replace #ifdef CONFIG_44x with IS_ENABLED(...) in flush_icache_cange() - Use 1GB chunks instead of 16GB in arch_*_memory Alastair D'Silva (6): powerpc: Allow flush_icache_range to work across ranges >4GB powerpc: Allow 64bit VDSO __kernel_sync_dicache to work across ranges >4GB powerpc: define helpers to get L1 icache sizes powerpc: Convert flush_icache_range & friends to C powerpc: Chunk calls to flush_dcache_range in arch_*_memory powerpc: Don't flush caches when adding memory arch/powerpc/include/asm/cache.h | 55 +++++--- arch/powerpc/include/asm/cacheflush.h | 36 +++-- arch/powerpc/kernel/misc_32.S | 120 ---------------- arch/powerpc/kernel/misc_64.S | 102 -------------- arch/powerpc/kernel/vdso64/cacheflush.S | 4 +- arch/powerpc/mm/mem.c | 176 +++++++++++++++++++++++- 6 files changed, 228 insertions(+), 265 deletions(-) -- 2.21.0