Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3418823ybx; Sun, 3 Nov 2019 18:35:19 -0800 (PST) X-Google-Smtp-Source: APXvYqxIdE9K8jJwEnklSm/07BiwkP5dkyqRUJdRVaswDNAgVg1+mrOSoi+mLeFBIPC+Nl2sdZu1 X-Received: by 2002:a17:906:6a8e:: with SMTP id p14mr21732041ejr.137.1572834919154; Sun, 03 Nov 2019 18:35:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572834919; cv=none; d=google.com; s=arc-20160816; b=s3jy9uJTKHmCDL/5NEAL90CU/dPKCj5TYU3O+gq00WtpNYRV79z8jgKowRbNCZSTkV bB58NGHeZYOF3+45uc85NrWQ1T5lJ7W6/q8JNx6NDWX+DXeXi04Pp0ByUf/XNGy7re8f TYQP/NwJ6q7WxfEWknHs0ItNTganBsy9jQC+0SaPQL0DhBGSez23tTEc0AF3gyGrAlp/ JP1ja3/5rrkXThKaBNDBU9JgMXQ2Y9azgOFML/YkkSxqJ2n0atqVVOxEw8taaj/cz1Bt /W+CvRt8vkQGQZVdkasrreJCkqSJQfQGxGARKmXiLpqfn7WIWRMs0fvuQevDAQ0hfa+x Lqvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=Qxerm/dRUeQ92/itGshJdarR8Bt+UJXWRH8r7F8k8NU=; b=wXslJwsl+tHrrX21LkoDJhCAJt//gGSkGHE114DyihFYuqurmvHVghG+qkToZf5BoC R1928npijRInVutMjybaBNxFesqI1TJ68aoOznZJG/6yZOrdrl6Da0pcfjfXAdIWhKNh Te7crHHKWeni+n8uRbCrhlx7j4vy/QJpVKVGH0PvKTaS1DF/DcvsUuuuNUNfTXgFyHSm QReq7W54fJ9+PbBAgAPzhNBoC/ewlISVm0D5fXDCgfazH4RsKL8w63Of3BMLHLxJyj/Y VMFqsBRcwBUsLlmaYiQ+YQen6IQewB7/uA6kcCly8sQH/0hnypr2t/CTwr0HWa91VJpH GeIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qw5si10862532ejb.91.2019.11.03.18.34.55; Sun, 03 Nov 2019 18:35:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbfKDCeM (ORCPT + 99 others); Sun, 3 Nov 2019 21:34:12 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:58336 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728227AbfKDCeM (ORCPT ); Sun, 3 Nov 2019 21:34:12 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA42WSxd147250 for ; Sun, 3 Nov 2019 21:34:11 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w28v9uute-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 03 Nov 2019 21:34:11 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Nov 2019 02:34:08 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 4 Nov 2019 02:34:04 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA42Y3gw53149784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Nov 2019 02:34:03 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ADA0A11C050; Mon, 4 Nov 2019 02:34:03 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5ADE911C04A; Mon, 4 Nov 2019 02:34:03 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 4 Nov 2019 02:34:03 +0000 (GMT) Received: from adsilva.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 99386A01D6; Mon, 4 Nov 2019 13:34:01 +1100 (AEDT) From: "Alastair D'Silva" To: alastair@d-silva.org Cc: stable@vger.kernel.org, Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Christophe Leroy , Allison Randal , Greg Kroah-Hartman , Qian Cai , Thomas Gleixner , Nicholas Piggin , Andrew Morton , David Hildenbrand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB Date: Mon, 4 Nov 2019 13:32:53 +1100 X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191104023305.9581-1-alastair@au1.ibm.com> References: <20191104023305.9581-1-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19110402-0008-0000-0000-0000032A5D3D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110402-0009-0000-0000-00004A49B0C3 Message-Id: <20191104023305.9581-2-alastair@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-04_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=674 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911040026 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alastair D'Silva When calling flush_icache_range with a size >4GB, we were masking off the upper 32 bits, so we would incorrectly flush a range smaller than intended. This patch replaces the 32 bit shifts with 64 bit ones, so that the full size is accounted for. Signed-off-by: Alastair D'Silva Cc: stable@vger.kernel.org --- arch/powerpc/kernel/misc_64.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S index b55a7b4cb543..9bc0aa9aeb65 100644 --- a/arch/powerpc/kernel/misc_64.S +++ b/arch/powerpc/kernel/misc_64.S @@ -82,7 +82,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 /* ensure we get enough */ lwz r9,DCACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of cache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 1: dcbst 0,r6 @@ -98,7 +98,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_COHERENT_ICACHE) subf r8,r6,r4 /* compute length */ add r8,r8,r5 lwz r9,ICACHEL1LOGBLOCKSIZE(r10) /* Get log-2 of Icache block size */ - srw. r8,r8,r9 /* compute line count */ + srd. r8,r8,r9 /* compute line count */ beqlr /* nothing to do? */ mtctr r8 2: icbi 0,r6 -- 2.21.0