Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3693995ybx; Mon, 4 Nov 2019 01:10:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwIZEvx3GymfTvYAo5t/MftDt4Lj9zqHGtxsty+aTxI0NO4jFVo1PdbmGAPbB0xX2lyW/uB X-Received: by 2002:a17:906:8697:: with SMTP id g23mr16462494ejx.177.1572858636580; Mon, 04 Nov 2019 01:10:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572858636; cv=none; d=google.com; s=arc-20160816; b=EX2cARAohjlFE8dJ7elWyaMgbprRWRXQPQtF2DAzFNkzZB0T2Tj8C+xhdICunCFECl 5EJfpIl8xR8Dv+SJ7v2OykSEumWRKaBLLnv4lk+tZGnAzvrkibXXNYOGZwqMhGjeVv61 mQdbNeYt6GCLw2u1j1yvel1bRBx0sJhc+bIOBDsF1OSWBMQmhLul2XqUoMlRffVe7vpN VVy7PM9SNWEahSyQPenPQY4phJySrOc2Z4vTKUVCJlY8El3jHTNa8k/YLiJzNsO14SwP P3QnRWa3MVX2gDsOCjGYVYGwCo97LGyzlJaGG1Y5lupLFQ4MqvsMxRSLMcSfebCyTl8f acYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=bsIXBpkzdk+Qjqq4rTyWaC1BS10+I6G1QrO/a4POeIE=; b=EFnB14a89fpK9RvUcju+XovWz6VoDnwVw9cT/+4y6hGpKZi/MJyqVfFOPAmPEhoYP3 rD8CqOs98Fau2LnKpImbAOWudoJgB5RvbZY280OBTosb74J1xQ99KYhF+JIvThbFZpX+ IY5RXd8p/sxCf1MLv7HT5rIaQ5I9kveUnsuK2yHgykTnrp9Ba8gKpG4XjLAOTQ30lSVE LjxuJ1yJlNNyyNUITcRoriseJ3xnxAd9C8NdaXUw99dqC+mPI6AkP2YGnaBeGIklRSEK twLM/lU/9UyKD0b3pACckc9kahQKc+1lSZqXUtqbMFCrXtmA5dMjxHSJdAMBH6BaP3P/ D0ag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j21si11021266ejn.392.2019.11.04.01.10.13; Mon, 04 Nov 2019 01:10:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728014AbfKDJJe (ORCPT + 99 others); Mon, 4 Nov 2019 04:09:34 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:33234 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfKDJJd (ORCPT ); Mon, 4 Nov 2019 04:09:33 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 2499B1C06CB; Mon, 4 Nov 2019 10:09:32 +0100 (CET) Date: Mon, 4 Nov 2019 10:09:31 +0100 From: Pavel Machek To: Chuhong Yuan Cc: Jacek Anaszewski , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: an30259a: add a check for devm_regmap_init_i2c Message-ID: <20191104090931.GE12355@duo.ucw.cz> References: <20191016125403.23359-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="o0ZfoUVt4BxPQnbU" Content-Disposition: inline In-Reply-To: <20191016125403.23359-1-hslester96@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --o0ZfoUVt4BxPQnbU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-10-16 20:54:03, Chuhong Yuan wrote: > an30259a_probe misses a check for devm_regmap_init_i2c and may cause > problems. > Add a check and print errors like other leds drivers. >=20 > Signed-off-by: Chuhong Yuan Thanks, applied. Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --o0ZfoUVt4BxPQnbU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCXb/qywAKCRAw5/Bqldv6 8tyGAJ4wfMBKXkzwGdXU7+D4hoK47ixpAACfeJnc9IYTirdXFtkbOW1XSHhfBbs= =DAiz -----END PGP SIGNATURE----- --o0ZfoUVt4BxPQnbU--