Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp3819073ybx; Mon, 4 Nov 2019 03:25:34 -0800 (PST) X-Google-Smtp-Source: APXvYqygty+hZs02SiA4OnBa+GrNFpVnMUCeoc/LQhbYVdBevINXaXyhv48Ty1EApMI6AEFfYyNL X-Received: by 2002:a17:906:6d82:: with SMTP id h2mr23357877ejt.127.1572866734221; Mon, 04 Nov 2019 03:25:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572866734; cv=none; d=google.com; s=arc-20160816; b=OUyG3teBvJ5J7OqDuI7kfhdJqZvyiWragHcyI0fstecxQkU6MNKd1MGEKdcMJ1K+Gb b41caJVsWiJHVPzC4YPhWyKAmspGCw9HG3aZRuJEKa258rj9d+7h1Qtsej2Kzx/EUvBf 7NRIZs6bJzftW31KfcXJdPHKiLTBj9QaqrbDmut/pcz5CxrG+ue82a8z9APnrvkr+p+h w67Kh+jWlwA58jZ2s+Wa4A/zPJPwjzJ7sO1fcvTonvm/QVRAihM03S7XZNV6dGhhbZhN b/EO58S5ssDq8GmXtJy3JtdzCb0Bamp1WwG1ZBmjhHB5ZK7YO7aXEdQ3BKL0fZFhQQY6 SwzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=36CNTxGpRLKCy6DXDgcpj9a2p38sXRZwpXyrKbBYafw=; b=K1yAjIt4x54umk+QUSbNrPD+GyZh6cxRxSp+hMTCVZzDk81RG/3xmhYWc67IE4aUHz 4VRdN+HusskppSNLzq1kP1BnfYgG+e4PiO8DZiy4fYyzVgATUee+g76ddhjrmQW0dNtP VsfnTlHKrQ1achDcjGEjpH2RHUbzIbfRPQfyYZ64RhrqNtj9nMX01k0gW+C/b7qlIg7+ dXNg0aM59Lhsu7tsy2nSZEbhUbuFCPnVq5HOzfoce87lpQlBKFoX6uaDbEp7tuDwEm8M uHnrE8fxE/U0j2A9m0J14Vr0KM9JvolUk52ASi18ueaLA7oj5XhcmlpuJzdYVgLXAFNd 992A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y31si7050844edb.47.2019.11.04.03.25.10; Mon, 04 Nov 2019 03:25:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728741AbfKDLV6 (ORCPT + 99 others); Mon, 4 Nov 2019 06:21:58 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:48072 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726364AbfKDLV5 (ORCPT ); Mon, 4 Nov 2019 06:21:57 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9FE3BD46CE388845323F; Mon, 4 Nov 2019 19:21:55 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Mon, 4 Nov 2019 19:21:47 +0800 From: Mao Wenan To: , , , , , , , CC: , , Subject: [PATCH v2 -next] usb: gadget: Add dependency for USB_TEGRA_XUDC Date: Mon, 4 Nov 2019 19:21:04 +0800 Message-ID: <20191104112104.195329-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <51315499-99d0-eca3-a7df-b8dd84628bbd@huawei.com> References: <51315499-99d0-eca3-a7df-b8dd84628bbd@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_USB_TEGRA_XUDC=y and CONFIG_USB_ROLE_SWITCH=m, below erros can be seen: drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_remove': tegra-xudc.c:(.text+0x6b0): undefined reference to `usb_role_switch_unregister' drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_probe': tegra-xudc.c:(.text+0x1b88): undefined reference to `usb_role_switch_register' drivers/usb/gadget/udc/tegra-xudc.o: In function `tegra_xudc_usb_role_sw_work': tegra-xudc.c:(.text+0x5ecc): undefined reference to `usb_role_switch_get_role' It should select USB_ROLE_SWITCH for UDC driver. Fixes: 49db427232fe ("usb: gadget: Add UDC driver for tegra XUSB device mode controller") Signed-off-by: Mao Wenan --- v2: change 'depends on' to 'select'. drivers/usb/gadget/udc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig index acaec3a..d103154 100644 --- a/drivers/usb/gadget/udc/Kconfig +++ b/drivers/usb/gadget/udc/Kconfig @@ -445,6 +445,7 @@ config USB_TEGRA_XUDC tristate "NVIDIA Tegra Superspeed USB 3.0 Device Controller" depends on ARCH_TEGRA || COMPILE_TEST depends on PHY_TEGRA_XUSB + select USB_ROLE_SWITCH help Enables NVIDIA Tegra USB 3.0 device mode controller driver. -- 2.7.4