Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jeff Moyer <jmoyer@redhat.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iocost: add a comment about locking in ioc_weight_write()
References: <20191104101811.GA20821@mwanda>
Date:   Mon, 04 Nov 2019 06:59:32 -0500
In-Reply-To: <20191104101811.GA20821@mwanda> (Dan Carpenter's message of "Mon,
        4 Nov 2019 13:18:11 +0300")
Message-ID: <x491runq2cb.fsf@segfault.boston.devel.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dan Carpenter <dan.carpenter@oracle.com> writes:

> It wasn't very clear that blkg_conf_prep() disables IRQ and that they
> are enabled in blkg_conf_finish() so this patch adds a comment about it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>

Thanks, Dan!

> ---
> I don't know if it's too late to fold this in with the previous patch?
>
>  block/blk-iocost.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/block/blk-iocost.c b/block/blk-iocost.c
> index a7ed434eae03..c5a8703ca6aa 100644
> --- a/block/blk-iocost.c
> +++ b/block/blk-iocost.c
> @@ -2095,6 +2095,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_=
file *of, char *buf,
>  =09=09return nbytes;
>  =09}
> =20
> +=09/* blkg_conf_prep() takes the q->queue_lock and disables IRQs */
>  =09ret =3D blkg_conf_prep(blkcg, &blkcg_policy_iocost, buf, &ctx);
>  =09if (ret)
>  =09=09return ret;
> @@ -2115,6 +2116,7 @@ static ssize_t ioc_weight_write(struct kernfs_open_=
file *of, char *buf,
>  =09weight_updated(iocg);
>  =09spin_unlock(&iocg->ioc->lock);
> =20
> +=09/* blkg_conf_finish() unlocks the q->queue_lock and enables IRQs */
>  =09blkg_conf_finish(&ctx);
>  =09return nbytes;