Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: Ybj3ETyPJ3hoG10Ll0xKpekm4Ac6HH4JMjCOLjLklOqFy5wDLS5qJoT2jj2jfyyUe6QQdX5iKz
 6lgKQsFjZGE/t0XT4HsCRu5nHOfZ9iWA9PDeeSF2USDSiy3L8xeaRkUVMFrWEbx9KPnO1DstwD
 9UvyGR55Ku/wDsKLzht01/0Qe8I8RWrGNfmzgT68RBJ3mI8tDyeWtn9bkuec8i3kt47hCgRraM
 ZgSBR4mNiwgiTd96eoP++/O1eJY9RWD1ybXgmp7csw1+zEdCoxEYu42SVn+flOk8F0zcz24/WI
 Pvo=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bradley Bolen <bradleybolen@gmail.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
        "kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "info@metux.net" <info@metux.net>,
        "hongjiefang@asrmicro.com" <hongjiefang@asrmicro.com>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "yinbo.zhu@nxp.com" <yinbo.zhu@nxp.com>
Subject: RE: [PATCH] mmc: core: Fix size overflow for mmc partitions
Thread-Topic: [PATCH] mmc: core: Fix size overflow for mmc partitions
Thread-Index: AQHVj4iHC/4Zqf+xVky+q9mZEDTeuad7Cq3Q
Date:   Mon, 4 Nov 2019 13:37:52 +0000
Message-ID: <MN2PR04MB6991B930872AB555EB56F16CFC7F0@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <20191031011132.5947-1-bradleybolen@gmail.com>
In-Reply-To: <20191031011132.5947-1-bradleybolen@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e39053e-3be7-4338-e7fd-08d7612c3108
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2019 13:37:52.4455
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: sSF5oPvLIDre3zzt4tpOQbfi7pIy4Mbhqmmr90GOuV9IGA6hsmy10e96jqZhXVqYqS8jbJhiutXiiR3XV3/YqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5775
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> With large eMMC cards, it is possible to create general purpose partition=
s that
> are bigger than 4GB.  The size member of the mmc_part struct is only an
> unsigned int which overflows for gp partitions larger than 4GB.  Change t=
his to a
> u64 to handle the overflow.
>=20
> Signed-off-by: Bradley Bolen <bradleybolen@gmail.com>
> ---
>  drivers/mmc/core/mmc.c   | 4 ++--
>  include/linux/mmc/card.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index
> c8804895595f..4e89cf6524a1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -297,7 +297,7 @@ static void mmc_manage_enhanced_area(struct
> mmc_card *card, u8 *ext_csd)
>         }
>  }
>=20
> -static void mmc_part_add(struct mmc_card *card, unsigned int size,
> +static void mmc_part_add(struct mmc_card *card, u64 size,
>                          unsigned int part_cfg, char *name, int idx, bool=
 ro,
>                          int area_type)
>  {
> @@ -345,7 +345,7 @@ static void mmc_manage_gp_partitions(struct
> mmc_card *card, u8 *ext_csd)
>                                 ext_csd[EXT_CSD_GP_SIZE_MULT + idx * 3];
>                         part_size *=3D (size_t)(hc_erase_grp_sz *
Need to adjust part_size as well.

Thanks,
Avri
>                                 hc_wp_grp_sz);
> -                       mmc_part_add(card, part_size << 19,
> +                       mmc_part_add(card, (u64)part_size << 19,
>                                 EXT_CSD_PART_CONFIG_ACC_GP0 + idx,
>                                 "gp%d", idx, false,
>                                 MMC_BLK_DATA_AREA_GP); diff --git
> a/include/linux/mmc/card.h b/include/linux/mmc/card.h index
> 9b6336ad3266..b59d35bb50ba 100644
> --- a/include/linux/mmc/card.h
> +++ b/include/linux/mmc/card.h
> @@ -226,7 +226,7 @@ struct mmc_queue_req;
>   * MMC Physical partitions
>   */
>  struct mmc_part {
> -       unsigned int    size;   /* partition size (in bytes) */
> +       u64             size;   /* partition size (in bytes) */
>         unsigned int    part_cfg;       /* partition type */
>         char    name[MAX_MMC_PART_NAME_LEN];
>         bool    force_ro;       /* to make boot parts RO by default */
> --
> 2.17.1