Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4050687ybx; Mon, 4 Nov 2019 07:05:34 -0800 (PST) X-Google-Smtp-Source: APXvYqyi+lGJAF3XpbVKkHeQytZ1YxP9lZTzVQNbA2RydXXCNPNdPg9n4Q6pcbtCl55AUrlsXlv/ X-Received: by 2002:a50:f30c:: with SMTP id p12mr8212211edm.208.1572879934282; Mon, 04 Nov 2019 07:05:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572879934; cv=none; d=google.com; s=arc-20160816; b=Tp8SzpvDdRj1a7rpOYP5YweU4EH0DLESZ/02ZlE3e+ACI8ZPE/AUQ9n492S6RW8dt9 1anZFchIfJUe1VSYmQv3pzvBp5I0mBp18v0qbEQUch2u/Ibl9N5ZKh2mB1L91BQBVe7r qtdiTswVAYNnAJ0f9JbVwTjzZcHwZ6cOiG29lbEwRtxFFH2SimXWDhGAD6kftvFWLNNQ 0oxhSphfq7sPIu2YpTkUhRUncSoR4BhiiHsuOM0RLhrdNL3dbd9NgLqb7zzPCNVe2ZcN i6x/TbHjcgZBX1D0EFlnPvPBsL9j78e+t8UXl5RosGBDhVeAcjn5TB26vR9bxN+wKqdu uBcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=D1ClJD7qHHTGYOoAGZcm92C1EBgrR1Y66qzK4bPRJVg=; b=JgR33Hzv7kUr9yLI/uj/ipWxisEoXNI1fsZmnpp+R0IVQUvtyqwNW+pvVyb3lTqQfa h60UFRpA9csBGaUlUP0ThZrkxvbXcpBbvW4CSzCw37Y5POCJRJhpSJ1SzArmRnRG6S9V 5NHmeIjKDbcIxQalDTgtVzBzYOpDYbk6GWqZHHXM8cx16tvOl4xBkbjRTe1/2crADyf7 a552cul3XJrDQmMi7ZRdCKmiUb/WovstLUZYiP2ZGR/Nv/pgckQ4qbS/PcWjqq0kkL7N qU4D/BcavRhoyDuiIR4e1ZJTt6QDXqf6RKj7bCk1rIQu2PgLFX3y0zlXrKTxU4MEKMSH sSjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WW2g8g9k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l2si11313508ejh.389.2019.11.04.07.05.10; Mon, 04 Nov 2019 07:05:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=WW2g8g9k; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728729AbfKDPBP (ORCPT + 99 others); Mon, 4 Nov 2019 10:01:15 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46273 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727788AbfKDPBP (ORCPT ); Mon, 4 Nov 2019 10:01:15 -0500 Received: by mail-wr1-f65.google.com with SMTP id b3so11691434wrs.13 for ; Mon, 04 Nov 2019 07:01:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D1ClJD7qHHTGYOoAGZcm92C1EBgrR1Y66qzK4bPRJVg=; b=WW2g8g9kjHYD6d7n9gPACYe4sD8R00xk11RgzesniVwm3iVvFcjFHCGmNYtIgCZ26F dzIqT0+CW38uzIfOQk+JTPeLpfxM3xq1jf9HAArYobKNo8h4sJaHF2zumnOhwZgt5IWT 9mJ7AXQIhShah0Tmxo8Wt/b79r38/Rj/UimJkbyfUHv0BGBvO/OaxlaRj0wRcWRNjhQs DwVA0uDvPEW3r8fQvZgePAQYUZAjrp0McYyQvKFnPPDAMgP87Gv+ApkLh3yDM5zwyNfS ofHLGCc538ZXVwinSZoE4TkddzX5nJsL/VC8b9cq4NmZedekeCWozjO7n4gmaqBDRXkP EBdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D1ClJD7qHHTGYOoAGZcm92C1EBgrR1Y66qzK4bPRJVg=; b=ZhOZ/w+7jGY1RnosA0TwlGzjOCdzJH5T4pYDfrq1jTfmAczyhsdY82/Ksm/zH884NR 9ISk31LPbNfEjYLLK6OCm2jZvPJH3hLmJ/Jo7btJP7bLIOGLpKKEO2oRv0OSi6xV0CkI EIjliNcJBj/KAY1paYrV53j+Wa6B6IkX6j7aLULGKlAwGFeDwc/WUwhlWjEsabgaTf1L JfEOnfMp/uWYWkrdjpfQSojjfQIcW/ZhQxzlbOfw2Ix/j2lIuqgmNCKWoZmzMf/f7GxN gLitX3lejJouMHo2j0JobSmW3+zssd9NKxfLE7k5x1SvNy5bj61FF1oSEi4hownAMZj0 Q+AQ== X-Gm-Message-State: APjAAAXyfcJ4PxwJc2C9CI6eKCu0l0xRGzDEEv2HjEaLNSODYXgauIKd W+tEJCtY9Sc1GFhoLCOyh/EKapJahPk= X-Received: by 2002:a5d:5262:: with SMTP id l2mr22100564wrc.113.1572879673073; Mon, 04 Nov 2019 07:01:13 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id l18sm21808043wrn.48.2019.11.04.07.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 07:01:12 -0800 (PST) From: Chuhong Yuan Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] phy: cadence: sierra: add missed clk_disable_unprepare in remove Date: Mon, 4 Nov 2019 23:01:02 +0800 Message-Id: <20191104150102.6424-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver forgets to disable and unprepare clk when remove. Add a call to clk_disable_unprepare to fix it. Signed-off-by: Chuhong Yuan --- drivers/phy/cadence/phy-cadence-sierra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index de10402f2931..81a987ca54a5 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -291,6 +291,7 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) struct cdns_sierra_phy *phy = dev_get_drvdata(pdev->dev.parent); int i; + clk_disable_unprepare(phy->clk); reset_control_assert(phy->phy_rst); reset_control_assert(phy->apb_rst); pm_runtime_disable(&pdev->dev); -- 2.23.0