Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4066616ybx; Mon, 4 Nov 2019 07:19:56 -0800 (PST) X-Google-Smtp-Source: APXvYqw7TmE3Mlb4xT63+Sabk3UkAMAmY3n34TS6MVWfVNA0TPkJ37/NZj/Togy5WaTycyQQ2Bmd X-Received: by 2002:a05:6402:160f:: with SMTP id f15mr21056950edv.41.1572880796753; Mon, 04 Nov 2019 07:19:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572880796; cv=none; d=google.com; s=arc-20160816; b=GLPaGmkMZWK7WtmD+SNtkQlXdbAbkETd2040AxB2GKJzGspMGcR86aAsSaNjIWpAsn 0sGHGRE7suRLc9G65eYDK1PohZ2INdBFeVQc1eKvpis98udwDLF6ZAzciwsROBK1S5As Sp1rs8DKIfQmRU7hxlabFL3Vvj8RFc4Z7udYtX8T+yG9oYbYvrSmsayYO6YygJ7O7D+Z 9NFdpUs/Ikv58ugmmPBN1MOs15zyVUlhSJ1iqswhw6EGyou4/89SIqq8Mw4r2uL6RIMI HTCqpMzkgivqeenQRrF8i1ywnDZL9gRAd7RND/P4B/S5GPNMu6cInmEx1cxdUCncS3e/ YWHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wI+MlQfXsMx0uWokWMoST+s/IjPegRzzQjCD9nh+Q+o=; b=Tzdp7PtF2Y0oEv4ohM6byAXwz4sQct1a/Ckzdm250Qrqwq+BProMQk0SQgzegn1RNn em/1RUEITdoMnAytttNiPms3q8DDzNtchbjJBXa307EwyHtowwekuvC+VI9ZHiVYPIdl a3BviWMDtP0aj3MPBzUMgLG2iFUWn3+o+VJCt/Yak2fVx+hX4s74ASmp4CParFDVOUU1 fFFY1h3U+zqJb6qptfiuthIvnIF7ZxuBjQHz4NRgly6IHPiYJYvjI14vdpkv1zTqsvSy Fn+JS9XzYQt+C/VrMtTu+xhJFacALgcV8wBk++bY5xpVSXIkRzIRRBcjYJfG88RoDbob JrmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Y4QNrQVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si8635254ejy.365.2019.11.04.07.19.33; Mon, 04 Nov 2019 07:19:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Y4QNrQVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729326AbfKDPSr (ORCPT + 99 others); Mon, 4 Nov 2019 10:18:47 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:58018 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728646AbfKDPSr (ORCPT ); Mon, 4 Nov 2019 10:18:47 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA4FCPlL032257; Mon, 4 Nov 2019 15:18:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=wI+MlQfXsMx0uWokWMoST+s/IjPegRzzQjCD9nh+Q+o=; b=Y4QNrQVsbZ/BnO04dhmq9gO+33O7WD7A0vrMN69D194HaDfvhyveJxdhBvQRhwKLcNib c4NM8JddRmjoeLcyY2S0nAW+ZLf70RNi1rhwnvCH4v8HByMiPEEuc/Iv6XefpjpcCgsM HrU4gex/gSamGEpCKjgQtxGqaORbunYDONOCxp8fiPky4MlihpexRRQTnTa+A5rJd8m4 xcCdhAY8xazJR/xQlraufK2Gfk49rbwdnckKLu3/VX3xg8bBGfVGBLk5GIqCHzE6LU8G M6wKMs1Lyf1ZZRcwP4Ao/BB1NdVlXuywgl9WzbfJdO7gY2NPAX3FZz41XpKnKryFvHM9 Ew== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2w11rpr20x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Nov 2019 15:18:19 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA4FAASi019949; Mon, 4 Nov 2019 15:16:19 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2w1kxmhnd4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 Nov 2019 15:16:19 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA4FGGZo019676; Mon, 4 Nov 2019 15:16:16 GMT Received: from tomti.i.net-space.pl (/10.175.168.29) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 Nov 2019 07:16:15 -0800 Date: Mon, 4 Nov 2019 16:16:09 +0100 From: Daniel Kiper To: "H. Peter Anvin" Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, ard.biesheuvel@linaro.org, boris.ostrovsky@oracle.com, bp@alien8.de, corbet@lwn.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, eric.snowberg@oracle.com, jgross@suse.com, kanth.ghatraju@oracle.com, konrad.wilk@oracle.com, mingo@redhat.com, rdunlap@infradead.org, ross.philipson@oracle.com, tglx@linutronix.de Subject: Re: [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max Message-ID: <20191104151609.k4qxlw4sbqvld357@tomti.i.net-space.pl> References: <20191024114814.6488-1-daniel.kiper@oracle.com> <20191024114814.6488-3-daniel.kiper@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=925 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911040151 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911040151 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 01, 2019 at 01:55:57PM -0700, H. Peter Anvin wrote: > On 2019-10-24 04:48, Daniel Kiper wrote: > > This field contains maximal allowed type for setup_data. > > > > Now bump the setup_header version in arch/x86/boot/header.S. > > Please don't bump the protocol revision here, otherwise we would create > a very odd pseudo-revision of the protocol: 2.15 without SETUP_INDIRECT > support, should patch 3/3 end up getting reverted. > > (It is possible to detect, of course, but I feel pretty sure in saying > that bootloaders won't get it right.) > > Other than that: > > Reviewed-by: H. Peter Anvin (Intel) I have just sent v5. Please take a look. Daniel