Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Nov 2019 10:30:49 -0500
From:   Brian Foster <bfoster@redhat.com>
To:     Dave Chinner <david@fromorbit.com>
Cc:     linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/28] shrinker: clean up variable types and tracepoints
Message-ID: <20191104153049.GD10665@bfoster>
References: <20191031234618.15403-1-david@fromorbit.com>
 <20191031234618.15403-14-david@fromorbit.com>
MIME-Version: 1.0
In-Reply-To: <20191031234618.15403-14-david@fromorbit.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 01, 2019 at 10:46:03AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>=20
> The tracepoint information in the shrinker code don't make a lot of

Nit:=09=09=09=09=09=09  doesn't

> sense anymore and contain redundant information as a result of the
> changes in the patchset. Refine the information passed to the
> tracepoints so they expose the operation of the shrinkers more
> precisely and clean up the remaining code and varibles in the

Nit:=09=09=09=09=09=09variables

> shrinker code so it all makes sense.
>=20
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>  include/trace/events/vmscan.h | 69 ++++++++++++++++-------------------
>  mm/vmscan.c                   | 24 +++++-------
>  2 files changed, 41 insertions(+), 52 deletions(-)
>=20
...
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index c0e2bf656e3f..7a8256322150 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
...
> @@ -624,23 +622,21 @@ static unsigned long do_shrink_slab(struct shrink_c=
ontrol *shrinkctl,
>  =09=09cond_resched();
>  =09}
>  done:
...
>  =09if (next_deferred > 0)
> -=09=09new_nr =3D atomic64_add_return(next_deferred,
> -=09=09=09=09=09=09&shrinker->nr_deferred[nid]);
> -=09else
> -=09=09new_nr =3D atomic64_read(&shrinker->nr_deferred[nid]);
> +=09=09atomic64_add(next_deferred, &shrinker->nr_deferred[nid]);
> =20
> -=09trace_mm_shrink_slab_end(shrinker, nid, freed, deferred_count, new_nr=
,
> -=09=09=09=09=09scan_count);
> +=09trace_mm_shrink_slab_end(shrinker, nid, freed, scanned_objects,
> +=09=09=09=09 next_deferred);

I guess this invalidates my comment on the previous patch around new_nr.
Looks Ok to me:

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  =09return freed;
>  }
> =20
> --=20
> 2.24.0.rc0
>=20