Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4131633ybx; Mon, 4 Nov 2019 08:18:51 -0800 (PST) X-Google-Smtp-Source: APXvYqzTCvy1whZqzF5Fs76XwFfCBCFOYf3wmVvMWK788Mu85WNvSQ/0bFtSFRgDkV/M455YsVp8 X-Received: by 2002:a05:6402:1397:: with SMTP id b23mr13700286edv.196.1572884330904; Mon, 04 Nov 2019 08:18:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572884330; cv=none; d=google.com; s=arc-20160816; b=nFGzF1Dj82McnoRFuECrvJ1vdnRk4hEuvVjvsHaxf1SB/qzg3dMHrm7rETYzhxwWQ2 xiGgv9hdvCcqkQeqoLCed1ag359OVnUwZelOp3SKAaKy2PJfziqTyF5LDjtdxmQjc2OK oyGa8WbO4+gr/jweQ51BMxtEy6/UfsgTJowSq6++ejagrp96TWWI8bT/r/S9dCIfudPG U07r4VX/57Q8VkViljImhcOp6xMh5ZFrZK1TFwMevqIWRc5+9YSKYypQo34xJ+bbxS8j RDuWABVO4gFvwly+/JAH2dqtEvxo2D9n8F7L8I+Bhd/hcOzhBMEEaNBIh0f9NGSsJyqO vkYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=j3uo0BMKlK0y8MI6JAlvvPKjW+q8BZt61AS+QsUjT+0=; b=eUCiQ3Vt0D1+Zmv3AI0q9d7IvGDy+cuZvta/r5jwJVFIhVAGZ5kSr6ENYOGqotVuAf xonkBfg+Baj6UG4IfL8QYUGUi9qg33SCIRVcznWPJgqM2Kp7udT/WuzfWTvCJkUX81/U X80eIeWHnNxs2SZEDkHw/dXc9Y1noUVTdbVRtPlioC+h8ZgzOfOxKYbpKV3rJYTo8HLc z8F1t3QVn+mwQyr6Wi4mWECadXfaQxNRrFuX0UF3hzwoWB26yB943HIDE7yOUxOjT9MF vjsbYB/2fdmrTAzVvbHt/Jisv1+EjzWj7PEpTAOUFT+VNbQDeEnYxP2uWWWdqTAeky9B IRAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Tnb/Lo2r"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ci3si2403732ejb.37.2019.11.04.08.18.26; Mon, 04 Nov 2019 08:18:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="Tnb/Lo2r"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729386AbfKDQQ5 (ORCPT + 99 others); Mon, 4 Nov 2019 11:16:57 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33398 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728138AbfKDQQ5 (ORCPT ); Mon, 4 Nov 2019 11:16:57 -0500 Received: by mail-wr1-f66.google.com with SMTP id s1so17822498wro.0; Mon, 04 Nov 2019 08:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j3uo0BMKlK0y8MI6JAlvvPKjW+q8BZt61AS+QsUjT+0=; b=Tnb/Lo2rthzMTsJJH+VXKXylmJSmWJd9ZdltDZOhEHkcTYtjujuaWVHzY81dFUM3JR N/1CCvPQA3hUOEBn8zR+5Wlb+vrp4wTZI/D+ixZyE0XfsZab4OTFocXtc2wWPjKAxXxL ppnWzttt/aOtsZVrPuA65eRxAW/bThXyLybgOh6/JHV4Q25v4q9ttBttw90hZmCMEj7q BtJ3kB+xsNuohdYEaRwoF6FUKwvrR1FtkQFNye4DPVAm6xW8EQHvmiwwTTPLrvQ+2j0M yDC58XoxcpHR14OQK0lZ/urATEZxpIdWfCFoiJrZpCCi4ToJSSlc9N/G5ZGf67mqcSNm CV5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=j3uo0BMKlK0y8MI6JAlvvPKjW+q8BZt61AS+QsUjT+0=; b=JQI9OYSpmBASQGj5SqL45RH7IoNnhl+OgZyTthQ78OD2lfzx6A67pOafiLtIfhlgOJ 4W82/sAFS5tx8K7lKmqBXGRBfATgAYS/Y+lyumtmN6m7uROZ/2UTpo/Lm80OTihN2pMz qm1JYLPqH4PInkz1RA2aArgWB1h9DnxeaaqhjdjiMw9VYTzlHJRPqvdrpsojLfIvZw5x Aa5DM66pXWhN0W4nTQsF/V4uoLj1kP7g4bF8eeoQzOwBAd21N2znIpuy4lRh8oFfkJqn 8euQ1hVc4YXJLOqlJe8l6nuM6kv0srCanWF0tG/kR08zVuEXzwyreIxH4CpTBkBHMP/U c0gw== X-Gm-Message-State: APjAAAXHgky99Of6XNMG5lnRZ4iDqHL2/FyqZr96mwisIQv/IRYU9Rg1 S3x6rZSNe1lT/NCFdlVaVfQ= X-Received: by 2002:a5d:4748:: with SMTP id o8mr24904912wrs.239.1572884215437; Mon, 04 Nov 2019 08:16:55 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id k4sm19652778wmk.26.2019.11.04.08.16.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 08:16:54 -0800 (PST) From: Chuhong Yuan Cc: Andy Gross , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] slimbus: qcom: add missed clk_disable_unprepare in remove Date: Tue, 5 Nov 2019 00:16:44 +0800 Message-Id: <20191104161644.11814-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The remove misses to disable and unprepare rclk and hclk. Add calls to clk_disable_unprepare to fix it. Signed-off-by: Chuhong Yuan --- drivers/slimbus/qcom-ctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c index a444badd8df5..4aad2566f52d 100644 --- a/drivers/slimbus/qcom-ctrl.c +++ b/drivers/slimbus/qcom-ctrl.c @@ -641,6 +641,8 @@ static int qcom_slim_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); slim_unregister_controller(&ctrl->ctrl); + clk_disable_unprepare(ctrl->rclk); + clk_disable_unprepare(ctrl->hclk); destroy_workqueue(ctrl->rxwq); return 0; } -- 2.23.0