Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Nov 2019 17:49:19 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jiri Slaby <jslaby@suse.com>
Cc:     Xiaoming Ni <nixiaoming@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty:n_gsm.c: destroy port by tty_port_destroy()
Message-ID: <20191104164919.GA2282079@kroah.com>
References: <1569317156-45850-1-git-send-email-nixiaoming@huawei.com>
 <1fd7d2eb-7497-254b-b40f-84bc4114f8a3@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1fd7d2eb-7497-254b-b40f-84bc4114f8a3@suse.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Oct 31, 2019 at 11:11:24AM +0100, Jiri Slaby wrote:
> On 24. 09. 19, 11:25, Xiaoming Ni wrote:
> > According to the comment of tty_port_destroy():
> >     When a port was initialized using tty_port_init, one has to destroy
> >     the port by tty_port_destroy();
> 
> It continues with a part saying:
>    Either indirectly by using tty_port refcounting
>    (tty_port_put) or directly if refcounting is not used.
> 
> > tty_port_init() is called in gsm_dlci_alloc()
> > so tty_port_destroy() needs to be called in gsm_dlci_free()
> > 
> > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
> > ---
> >  drivers/tty/n_gsm.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> > index 36a3eb4..3f5bcc9 100644
> > --- a/drivers/tty/n_gsm.c
> > +++ b/drivers/tty/n_gsm.c
> > @@ -1681,6 +1681,7 @@ static void gsm_dlci_free(struct tty_port *port)
> >  
> >  	del_timer_sync(&dlci->t1);
> >  	dlci->gsm->dlci[dlci->addr] = NULL;
> > +	tty_port_destroy(&dlci->port);
> 
> This is wrong. gsm_dlci_free is tty_port_operations->destruct, i.e.
> n_gsm uses tty_port refcounting and tty_port_destroy was called on this
> port in tty_port_destructor already.
> 
> Greg, please revert.

Now reverted.

sorry about that.

greg k-h