Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4217652ybx; Mon, 4 Nov 2019 09:37:39 -0800 (PST) X-Google-Smtp-Source: APXvYqzCm/lBErR6dGaX0fctNjskbuUKzTxywtQhkeYC0iYmaPF/KY9mmuvGgZTEGxsuopcNcvTq X-Received: by 2002:aa7:c98f:: with SMTP id c15mr3606965edt.98.1572889059468; Mon, 04 Nov 2019 09:37:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572889059; cv=none; d=google.com; s=arc-20160816; b=r1pWe2OFvHYrTSdNJFL+Gq2w/Eg4fDAUew9SMkXIt1+B2haeLOD/QEWCZzVEJcncaL T7mmdS9oj/+RAKJL5wKEv5Qckq9knw0Xen0WXgTt4/zKDhuF+1PwtC4EinNflXrrvDmT F60dfWQotSI70FzVP4qGP0zqOaNLEaCvB19Xa5J0rMnmTl6MsYQs6moMUDOg9Bo+4g+s 18ccPS9/g45Usl90y1+7UGFAWzlxEG8ccJlJ60N6gYqCUosmXFNc+L6/QoKBJDU2vs1S obZdzy+2kGiMeyxpBKMBkrc4pKDwUWtvD/qiKDECgtrj3pyh2tz67a2MUC8/o7jxRhDn /0UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=2OsvrwszToLv3inr26bHbJl2IPf0+khdgkqsRTySDaM=; b=QaahwIGPTSJSDtYd4XiVFm4nOqWS93MCaWaDwGZsIWnIi0h+8g8OqwtCssf34B0v// GaIs/CYDIHg0vsKTJC1W8QIy1fR+LoozE/9xKcwsYuMW6VL9m6O/NAGskEvCEcQxoLdn DO/+seSgw5+70+GRrFQlYnHs9XZPXYnOt/8+mZUXMmkUGE5+WrYo1ZiTvhGAf7QvTWd7 Abg5saJtv+IzC5sqq29sIGWdRPf5bIbtm2tIqkF7zFJt07Fe08ILQ0mrLjGxEc/ZTgRx s/kk8AGfRjYFU2ZV3KJ2noOOD7nBxR2vqwnUFPpVPf1aLcwqh4FCDo8NRwTIqhGFOHCs NYUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nhuEVF56; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14si8239851ejc.72.2019.11.04.09.37.15; Mon, 04 Nov 2019 09:37:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nhuEVF56; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729326AbfKDRgX (ORCPT + 99 others); Mon, 4 Nov 2019 12:36:23 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34287 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727998AbfKDRgW (ORCPT ); Mon, 4 Nov 2019 12:36:22 -0500 Received: by mail-ed1-f66.google.com with SMTP id b72so13850211edf.1; Mon, 04 Nov 2019 09:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2OsvrwszToLv3inr26bHbJl2IPf0+khdgkqsRTySDaM=; b=nhuEVF56pEjsAGc6RuP8QUSnLUP50dxER7Z7+lHnTazc/32LdVJjbnfYpwfUfrwb2V sak4szEMs6dn09/Uk3a+uz7FXBWCVZayUmWQ/nlScm73DZitGfmFHRy17T4JPc+kYzaW Bmi7OZtdPCqmreYpkndRp19j4I2s8irXrqNE6hW8oI8Ew0N1c86y/BKOr4HLgMEvEFHz e2fvvpb6rvb1/pweRju1tsPiDUsIv+nWdt+OCRLtkdFvMUVXd4FumHOk01t3AyC3xgCu QCAf65N9W3uUWvQCdKR/KRpCC13mkhk1lI+/ACNO+eikx32uVzvMiEKpOAwaxExNc+LW VCng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2OsvrwszToLv3inr26bHbJl2IPf0+khdgkqsRTySDaM=; b=GsdGOeodNGXsoRTt3Pz2Jcz20NuBPmW/TBKT872HbG2CQr4f138JNKijciLVRSxnos cnhS7Esrda8YXU7kdgZ/Gc3SPsrcYrSuzgUOQwr763zCl4PCmEcY/vEXFwbY3NOJu9Rr Cc+nGNb68PYWqwvW6nXahtpjMyT3kuXH/oepygN/kAM+LkiYxXjhSMGCSxk+NoZkizCA friEMXCaB+F7npAFEDyYBz+MmL3k1+iy9PtOGBXhD3qvOz1wZDGF3zIDjVAfgUVyypAs GaEbN8yI3ACzaVPRxNsRXoF8LCbnl961GdSWxLuHzzlJjECcif0v/vmiW4a5iAGOdlfh +RIg== X-Gm-Message-State: APjAAAXY0Yn71ZCCs6C+rfDIdFMOp8tTJo/ZMSZEDYOd/VNiGedMQCUD hAOOTrmC248e5t8mtKo0a19MPVGu X-Received: by 2002:a17:906:53cc:: with SMTP id p12mr24947699ejo.52.1572888978991; Mon, 04 Nov 2019 09:36:18 -0800 (PST) Received: from [10.67.50.53] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id v5sm936001edd.90.2019.11.04.09.36.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2019 09:36:18 -0800 (PST) Subject: Re: [PATCH] rtc: brcmstb-waketimer: add missed clk_disable_unprepare To: Chuhong Yuan Cc: Alessandro Zummo , Alexandre Belloni , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191104155019.9053-1-hslester96@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <420cbb31-1754-444c-cbc2-d32d77e43ca0@gmail.com> Date: Mon, 4 Nov 2019 09:36:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191104155019.9053-1-hslester96@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/4/19 7:50 AM, Chuhong Yuan wrote: > This driver forgets to disable and unprepare clock when remove. > Add a call to clk_disable_unprepare to fix it. > > Signed-off-by: Chuhong Yuan This looks fine, you do not need to check for timer->clk, since the clk_* APIs do that, and we made sure in the probe function that we would not be passing a timer->clk handle which is valid. Also feel free to add: Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer") Thank you -- Florian