Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4261927ybx; Mon, 4 Nov 2019 10:20:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyPyjnWwwzMD2VKq3FhbgutnffmrGboLVPG6bqaX9l1SPIzg3Dl4xkVJ9Zui9FRMfNE9+Mx X-Received: by 2002:a50:ef17:: with SMTP id m23mr10590000eds.81.1572891631094; Mon, 04 Nov 2019 10:20:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572891631; cv=none; d=google.com; s=arc-20160816; b=SGLyYzMEOlwi0yAXQb9ju7GNjOI1IXLxGksrr2T+xFhpdMnfKfq4GqQCqDZhcy5ka3 oX9o/So9QkIdl6ygGi84uU870WADEdNOJmBO4KaYSws+L7aO87fF8rmj4gxCjSXQQn9A FUxUrN6bJdANFC+L40/0zFHYkO0/AKgeZuCo4k8h4LV4StISsY9/m3hrVut3C90BPygP nUwhcEOt39YUaZxVIfLhDGvb11U/R1cGwu2GR313AcMErJgJaThUtmyQIsHJN/3O4mPJ lko4fj86W8bw3xyccCT8/SAoytppDbjhwh5TRB25FY+CNjXkhiXSP+tBaofOWY2DjnR3 H53A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=0fsOAAinXlsL6OzZu8p3dKwG1udep9j5QxOEbtn17vE=; b=ve5m+z47kM1kueNQwdgqpGQ0y0PK+KhEg+u8fJB+cDZvz2TBBM7E0paMZnfvJtyU4Q O0+/melWTR9REH2dUUxaNC4a3/aFymZD2//khgJuUfgkPzCJva9gguIKJNftypTTZa/8 zExpDD1ZvJtNKLxlkZpp2zbJqE/JQGlHIN7P3Chv+qlSV2010Ove5Q9ZuRSswPWiKg2V kOaFCjnNu7XBHRa3nqxoaAZq05kDuEU9qGQMh0cF/nQ9pecA39NdU/4CyljoVg+Y2vXk MtsbeOAP/Se2qGaOPJetJ2smx7akIjnKEZyBLV1xVOANwtPeXePWjjHcnkh0VJog19kv hCRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f36si7815715ede.159.2019.11.04.10.20.07; Mon, 04 Nov 2019 10:20:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729312AbfKDSSZ (ORCPT + 99 others); Mon, 4 Nov 2019 13:18:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:54536 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727998AbfKDSSZ (ORCPT ); Mon, 4 Nov 2019 13:18:25 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6284CABD0; Mon, 4 Nov 2019 18:18:23 +0000 (UTC) From: Thomas Abraham To: hmadhani@marvell.com Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, hare@suse.com, Thomas Abraham Subject: [PATCH] scsi: qla2xxx: avoid crash in qlt_handle_abts_completion() if mcmd == NULL Date: Mon, 4 Nov 2019 13:18:03 -0500 Message-Id: <20191104181803.5475-1-tabraham@suse.com> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org qlt_ctio_to_cmd() will return a NULL mcmd if h == QLA_TGT_SKIP_HANDLE. If the error subcodes don't match the exact codes checked a crash will occur when calling free_mcmd on the null mcmd Signed-off-by: Thomas Abraham --- drivers/scsi/qla2xxx/qla_target.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index a06e56224a55..611ab224662f 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -5732,7 +5732,8 @@ static void qlt_handle_abts_completion(struct scsi_qla_host *vha, vha->vp_idx, entry->compl_status, entry->error_subcode1, entry->error_subcode2); - ha->tgt.tgt_ops->free_mcmd(mcmd); + if (mcmd) + ha->tgt.tgt_ops->free_mcmd(mcmd); } } else if (mcmd) { ha->tgt.tgt_ops->free_mcmd(mcmd); -- 2.16.4