Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191030174429.248697-1-ndesaulniers@google.com> <fa4e28a9a16c54319916be005159e250@agner.ch>
In-Reply-To: <fa4e28a9a16c54319916be005159e250@agner.ch>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Mon, 4 Nov 2019 10:43:08 -0800
Message-ID: <CAKwvOd==f801+AfJWwrO3tbSRoizCa2HV7pViOqedJbipN9nOw@mail.gmail.com>
Subject: Re: [PATCH] arm: replace Sun/Solaris style flag on section directive
To:     Stefan Agner <stefan@agner.ch>
Cc:     Russell King <linux@armlinux.org.uk>,
        Fangrui Song <maskray@google.com>,
        Jian Cai <jiancai@google.com>,
        Peter Smith <peter.smith@linaro.org>,
        Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nicolas Pitre <nico@fluxnic.net>,
        Enrico Weigelt <info@metux.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Roy Franz <rfranz@marvell.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Allison Randal <allison@lohutok.net>,
        Richard Fontana <rfontana@redhat.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Dave Martin <Dave.Martin@arm.com>,
        Sonny Rao <sonnyrao@chromium.org>,
        Doug Anderson <armlinux@m.disordat.com>,
        Vladimir Murzin <vladimir.murzin@arm.com>,
        afzal mohammed <afzal.mohd.ma@gmail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 1, 2019 at 2:05 PM Stefan Agner <stefan@agner.ch> wrote:
>
> Hi Nick,
>
> On 2019-10-30 18:44, Nick Desaulniers wrote:
> > It looks like a section directive was using "Solaris style" to declare
> > the section flags. Replace this with the GNU style so that Clang's
> > integrated assembler can assemble this directive.
> >
> > The modified instances were identified via:
> > $ ag \\.section | grep \#

Submitted: https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8933/1

>
> I actually have the *very same* patch on my tree, just did not cleanup
> the commit message and submit :-(

Send in those patches!

>
> Anyways, this looks good to me:
>
> Reviewed-by: Stefan Agner <stefan@agner.ch>


Thanks all for those reviews.
-- 
Thanks,
~Nick Desaulniers