Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4337746ybx; Mon, 4 Nov 2019 11:38:51 -0800 (PST) X-Google-Smtp-Source: APXvYqw0p0jWy//vX2wgXMdChEm5HDDoTBHsj8JRhhIpl1+3YzgQUUm9VPm5AaPJR+YSdT12Tdis X-Received: by 2002:a05:6402:6cf:: with SMTP id n15mr8825521edy.269.1572896331824; Mon, 04 Nov 2019 11:38:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572896331; cv=none; d=google.com; s=arc-20160816; b=ee/fnuwpnNf8cxDyoVZd9z+/bjXxJ7zX7pDHPZEQiEtvtpQx2hAvbcfguTlyJv5eaN rqalS8HY4/xxKCYD0ev0zyjM27DuqEzThukuvel4OFiDdAzWd0kkaS9epkRsJf4CBa+e quc8T18wbqC+Qth0+PBregdhX8FUNllCH/ambA2F/LprgiP9SfFqPLAB/wc9jdPZ9a9n 0aqHRDgSTvXwqHYdG9tWDPSEIlre0n8zAY0fJ501aTVuJ+nFBdZdh1jg2KYslNKuYp4R +7tBL4LvWjBNG0DT1JJtaID4UxF7Dg38bTWiD9h0G/iqRMMAsQGPb79gAsfEyaTHLN1a Zf4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=39xYFt90x3hcLmdM1dQjIKJtQsb0FMWbyoCrZUqElww=; b=mAvsS5VV8iMAgqyDROmosV4E5B7BG0woqx1ktf2q6kV5pk1Zw4gA4jXZ/v/8EGV7XA rFFb1lilx6472FQmqB26MWMIXvYXXIiacJ2M/4sDMlIZ0yXS62GLxUE2GcgCWfFvMhy4 f/4XecuaBQ1WsJ2c9WevCNKaTcslaXcdaif7SlmJO70/m5kq4kSHzbMyuISpls8/Plas WmzOcPD2M6r/HP+Md4mvi4K0ItR/HE4sFk89Au0j1PjvR33jPP4uyIWN6ATqbwpl8Y1L odf3hQb7HmvMW1iAUe9nxnIxPBe7lKgA6CxHPN+3FWASCzuSP+C/5ZtId3S72+6W3ncr qwUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i47si8146907eda.91.2019.11.04.11.38.28; Mon, 04 Nov 2019 11:38:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387424AbfKDTgC (ORCPT + 99 others); Mon, 4 Nov 2019 14:36:02 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:50624 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387401AbfKDTgC (ORCPT ); Mon, 4 Nov 2019 14:36:02 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B5202151D7255; Mon, 4 Nov 2019 11:36:01 -0800 (PST) Date: Mon, 04 Nov 2019 11:36:01 -0800 (PST) Message-Id: <20191104.113601.407489006150341765.davem@davemloft.net> To: hslester96@gmail.com Cc: fugang.duan@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: fec: add missed clk_disable_unprepare in remove From: David Miller In-Reply-To: <20191104155000.8993-1-hslester96@gmail.com> References: <20191104155000.8993-1-hslester96@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Nov 2019 11:36:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chuhong Yuan Date: Mon, 4 Nov 2019 23:50:00 +0800 > This driver forgets to disable and unprepare clks when remove. > Add calls to clk_disable_unprepare to fix it. > > Signed-off-by: Chuhong Yuan Applied.