Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4345308ybx; Mon, 4 Nov 2019 11:47:20 -0800 (PST) X-Google-Smtp-Source: APXvYqzh4gfx+pAHLsdGoc0+SsryZ68p5tMgUXMGmCL+wpvN2DjyUCb9qvIBkooldJVK9XVm6z+s X-Received: by 2002:a50:e609:: with SMTP id y9mr27322904edm.55.1572896840754; Mon, 04 Nov 2019 11:47:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572896840; cv=none; d=google.com; s=arc-20160816; b=xMeXwzEAyOrcb6+qYJiq7af8Fm48uGEN4DR+V5Ko2ZFglpe4McazMNsvb3ZzGoC7we jbG0fOu9I5aVjAibwYijKPsIPAdgFmqiFol+ZJ27ZMZaqwSGZqmCPtNAj0UoEOsOIMIp csYnWfjmOsvMbxt1ypIGLxYM9YTY0w/9FJRvgOFI/tllR7etigjWcT2qwLQIYmn91sZs itZiJI0fx+EgrWRi0BVGbmi+Pq3jDGq3ZbGBgB7TXQYtOzpz8hywzXtmT37+VN1q8RcA OZZaBrnD0ta4RULz+KBy8HLHQC0PZe3bz29B6EbEQXG4UvBZo6gwYXHYthamQB7f4DK3 g81w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cdfhK75hOvJX/1enfJ1fcjFbwU2W7d3ovGWoPSCV9HE=; b=giNZGpfKPqIRWrKkHDKXh4rqjdpe1+a37MoeAS04NvsO7dCIX55msWhsjIoH+v3uYw PJFrpeK4m+sKobPuYk7R4H6PxHn6l1Qz1E1Adx1N3N+bBNMp0Ah3QZhZNtIrjrhj1D4/ nHPMT33o2JuJpKL8tCRRVoFyQHeAmaCYEJaJVvcNXE506DzLVo1bBmYc+7z3yUWRuJkP 8nOeNue01OHU8obKjaIiW548TfZkibfOhUGd6m3mCvc/FIhyJ3X8TuxaRXKi1E5VQe/L opA1UlWWYRg2ItSkO87NEPGJ0+VqAtngdclWc5dPQUWfI4wGgOOXvjLGZHYlUwegzkxU Kcug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e19si11813058ejd.24.2019.11.04.11.46.57; Mon, 04 Nov 2019 11:47:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728766AbfKDToq (ORCPT + 99 others); Mon, 4 Nov 2019 14:44:46 -0500 Received: from gate.crashing.org ([63.228.1.57]:59631 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728332AbfKDToq (ORCPT ); Mon, 4 Nov 2019 14:44:46 -0500 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id xA4JhxDe009601; Mon, 4 Nov 2019 13:44:00 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id xA4Jhwlx009599; Mon, 4 Nov 2019 13:43:58 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 4 Nov 2019 13:43:57 -0600 From: Segher Boessenkool To: "Alastair D'Silva" Cc: alastair@d-silva.org, Greg Kroah-Hartman , David Hildenbrand , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Paul Mackerras , Nicholas Piggin , Qian Cai , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Allison Randal Subject: Re: [PATCH v5 1/6] powerpc: Allow flush_icache_range to work across ranges >4GB Message-ID: <20191104194357.GE16031@gate.crashing.org> References: <20191104023305.9581-1-alastair@au1.ibm.com> <20191104023305.9581-2-alastair@au1.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191104023305.9581-2-alastair@au1.ibm.com> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 04, 2019 at 01:32:53PM +1100, Alastair D'Silva wrote: > When calling flush_icache_range with a size >4GB, we were masking > off the upper 32 bits, so we would incorrectly flush a range smaller > than intended. > > This patch replaces the 32 bit shifts with 64 bit ones, so that > the full size is accounted for. Please send this separately, to be committed right now? It is a bug fix, independent of the rest of the series. Segher