Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Nov 2019 14:58:22 -0500
From:   Brian Foster <bfoster@redhat.com>
To:     Dave Chinner <david@fromorbit.com>
Cc:     linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/28] mm: back off direct reclaim on excessive shrinker
 deferral
Message-ID: <20191104195822.GF10665@bfoster>
References: <20191031234618.15403-1-david@fromorbit.com>
 <20191031234618.15403-16-david@fromorbit.com>
MIME-Version: 1.0
In-Reply-To: <20191031234618.15403-16-david@fromorbit.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Nov 01, 2019 at 10:46:05AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>=20
> When the majority of possible shrinker reclaim work is deferred by
> the shrinkers (e.g. due to GFP_NOFS context), and there is more work
> defered than LRU pages were scanned, back off reclaim if there are

  deferred

> large amounts of IO in progress.
>=20
> This tends to occur when there are inode cache heavy workloads that
> have little page cache or application memory pressure on filesytems
> like XFS. Inode cache heavy workloads involve lots of IO, so if we
> are getting device congestion it is indicative of memory reclaim
> running up against an IO throughput limitation. in this situation
> we need to throttle direct reclaim as we nee dto wait for kswapd to

=09=09=09=09=09   need to

> get some of the deferred work done.
>=20
> However, if there is no device congestion, then the system is
> keeping up with both the workload and memory reclaim and so there's
> no need to throttle.
>=20
> Hence we should only back off scanning for a bit if we see this
> condition and there is block device congestion present.
>=20
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>  include/linux/swap.h |  2 ++
>  mm/vmscan.c          | 30 +++++++++++++++++++++++++++++-
>  2 files changed, 31 insertions(+), 1 deletion(-)
>=20
> diff --git a/include/linux/swap.h b/include/linux/swap.h
> index 72b855fe20b0..da0913e14bb9 100644
> --- a/include/linux/swap.h
> +++ b/include/linux/swap.h
> @@ -131,6 +131,8 @@ union swap_header {
>   */
>  struct reclaim_state {
>  =09unsigned long=09reclaimed_pages;=09/* pages freed by shrinkers */
> +=09unsigned long=09scanned_objects;=09/* quantity of work done */=20

Trailing whitespace at the end of the above line.

> +=09unsigned long=09deferred_objects;=09/* work that wasn't done */
>  };
> =20
>  /*
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 967e3d3c7748..13c11e10c9c5 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -570,6 +570,8 @@ static unsigned long do_shrink_slab(struct shrink_con=
trol *shrinkctl,
>  =09=09deferred_count =3D min(deferred_count, freeable_objects * 2);
> =20
>  =09}
> +=09if (current->reclaim_state)
> +=09=09current->reclaim_state->scanned_objects +=3D scanned_objects;

Looks like scanned_objects is always zero here.

> =20
>  =09/*
>  =09 * Avoid risking looping forever due to too large nr value:
> @@ -585,8 +587,11 @@ static unsigned long do_shrink_slab(struct shrink_co=
ntrol *shrinkctl,
>  =09 * If the shrinker can't run (e.g. due to gfp_mask constraints), then
>  =09 * defer the work to a context that can scan the cache.
>  =09 */
> -=09if (shrinkctl->defer_work)
> +=09if (shrinkctl->defer_work) {
> +=09=09if (current->reclaim_state)
> +=09=09=09current->reclaim_state->deferred_objects +=3D scan_count;
>  =09=09goto done;
> +=09}
> =20
>  =09/*
>  =09 * Normally, we should not scan less than batch_size objects in one
> @@ -2871,7 +2876,30 @@ static bool shrink_node(pg_data_t *pgdat, struct s=
can_control *sc)
> =20
>  =09=09if (reclaim_state) {
>  =09=09=09sc->nr_reclaimed +=3D reclaim_state->reclaimed_pages;
> +
> +=09=09=09/*
> +=09=09=09 * If we are deferring more work than we are actually
> +=09=09=09 * doing in the shrinkers, and we are scanning more
> +=09=09=09 * objects than we are pages, the we have a large amount
> +=09=09=09 * of slab caches we are deferring work to kswapd for.
> +=09=09=09 * We better back off here for a while, otherwise
> +=09=09=09 * we risk priority windup, swap storms and OOM kills
> +=09=09=09 * once we empty the page lists but still can't make
> +=09=09=09 * progress on the shrinker memory.
> +=09=09=09 *
> +=09=09=09 * kswapd won't ever defer work as it's run under a
> +=09=09=09 * GFP_KERNEL context and can always do work.
> +=09=09=09 */
> +=09=09=09if ((reclaim_state->deferred_objects >
> +=09=09=09=09=09sc->nr_scanned - nr_scanned) &&

Out of curiosity, what's the reasoning behind the direct comparison
between ->deferred_objects and pages? Shouldn't we generally expect more
slab objects to exist than pages by the nature of slab?

Also, the comment says "if we are scanning more objects than we are
pages," yet the code is checking whether we defer more objects than
scanned pages. Which is more accurate?

Brian

> +=09=09=09    (reclaim_state->deferred_objects >
> +=09=09=09=09=09reclaim_state->scanned_objects)) {
> +=09=09=09=09wait_iff_congested(BLK_RW_ASYNC, HZ/50);
> +=09=09=09}
> +
>  =09=09=09reclaim_state->reclaimed_pages =3D 0;
> +=09=09=09reclaim_state->deferred_objects =3D 0;
> +=09=09=09reclaim_state->scanned_objects =3D 0;
>  =09=09}
> =20
>  =09=09/* Record the subtree's reclaim efficiency */
> --=20
> 2.24.0.rc0
>=20