Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp4486305ybx; Mon, 4 Nov 2019 14:13:34 -0800 (PST) X-Google-Smtp-Source: APXvYqx1smJAjM7AXXf217JJcuqIhp5JcAYh/T54YDeqw0hvjLuIpG6lKBMhQmlHkuBCUep9nLRi X-Received: by 2002:a17:907:4300:: with SMTP id oa24mr13064044ejb.8.1572905614003; Mon, 04 Nov 2019 14:13:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572905613; cv=none; d=google.com; s=arc-20160816; b=urbNjD7WaX1f9H8b9uUp0bn6jcodp+wwfC75YNA1GFgTlCN9dPRMfNIYdktZvfR7is OQ7ONFBahWEAuP+Js/4CtY5+bdJsClukGAVokw6a/XXUPR3Mr3esuwEJQf+nAthYhvnt 8vSbWM4ZpxfT/TIH/9nvDUGHW/YGv/JWD5ILsGTY0m+affE7Hbl6WqfQoTbm4TZPIfe7 f5pIH3WlEZ57wwISyXFJNRkk6zYcCPlnSAUwCX83W/Q3/f3Wum+fz5i63KrVe0xe9yAv wnDDnH/el1YsxjYcDWDwkoJ2bX7O3mA0uMJGDorb38XBhofQ2SfdSR08iWemVM9xBaLb ejXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HTiGmnwx20hRS1LTuaxPMGqsLnO7Sdu72cvRoaaD3QI=; b=wNm2VN+Z1FxxgK4LUMruYBVrWK3CpSmo/icA1G0n4KoQpTVfoFNXaf5iZi6G7sKF7b 6geoYZqQQNSIDVtwx01XYjuHKqQ1Vxw5yy9QFV1yCr0fIKohn1sJ4VndMJ/iqaQgokGY 2jgF3i7ucoE/2OBvHeT6z5YqM4MrvHQC7UsIsZTLIkXJvYf/XivfvlgRkS0PANkgdzQQ zPcwc2i025Ih/zxgeiLGOkST94mYXHGZW6WYQ23XL9Hx++DEx9JJv8d7Dl7Sj9+UnRNb xQCVjWOH/FZQ/h+t5s51FYi9TIchfVelwQqnb4XF1JVxNe80MTfKG8TENVgpPd34a4lw 4Gvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tajJnuEI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8si8491777edb.57.2019.11.04.14.13.07; Mon, 04 Nov 2019 14:13:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tajJnuEI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390617AbfKDWLE (ORCPT + 99 others); Mon, 4 Nov 2019 17:11:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:44280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390268AbfKDWLA (ORCPT ); Mon, 4 Nov 2019 17:11:00 -0500 Received: from localhost (6.204-14-84.ripe.coltfrance.com [84.14.204.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2A150214E0; Mon, 4 Nov 2019 22:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572905459; bh=AEX36XsO5lXsy2UodCcGI6ADsqU81+EXoRM9bAA0rL0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tajJnuEIdNycc1mhfT+maVfr71o/iP/PLvqNliwS9J+tCt7t+B+nwKQapvUP8LTMI HexSrpZXIDJRiRGdaB0Tp+tvZttWwTjzLxP2HHxqCddIfHo5f/+IUu2kZ7q6qoKMLm J33AtmsmAEgSx8Zba6W9vwZbDcN9fZmQa8kMyHP8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com, Valentin Vidic , "David S. Miller" Subject: [PATCH 5.3 154/163] net: usb: sr9800: fix uninitialized local variable Date: Mon, 4 Nov 2019 22:45:44 +0100 Message-Id: <20191104212151.434122569@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191104212140.046021995@linuxfoundation.org> References: <20191104212140.046021995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Valentin Vidic commit 77b6d09f4ae66d42cd63b121af67780ae3d1a5e9 upstream. Make sure res does not contain random value if the call to sr_read_cmd fails for some reason. Reported-by: syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com Signed-off-by: Valentin Vidic Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/usb/sr9800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/usb/sr9800.c +++ b/drivers/net/usb/sr9800.c @@ -336,7 +336,7 @@ static void sr_set_multicast(struct net_ static int sr_mdio_read(struct net_device *net, int phy_id, int loc) { struct usbnet *dev = netdev_priv(net); - __le16 res; + __le16 res = 0; mutex_lock(&dev->phy_mutex); sr_set_sw_mii(dev);