Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andrea Arcangeli <aarcange@redhat.com>
To:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
Subject: [PATCH 11/13] KVM: retpolines: x86: eliminate retpoline from vmx.c exit handlers
Date:   Mon,  4 Nov 2019 17:59:59 -0500
Message-Id: <20191104230001.27774-12-aarcange@redhat.com>
In-Reply-To: <20191104230001.27774-1-aarcange@redhat.com>
References: <20191104230001.27774-1-aarcange@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

It's enough to check the exit value and issue a direct call to avoid
the retpoline for all the common vmexit reasons.

Of course CONFIG_RETPOLINE already forbids gcc to use indirect jumps
while compiling all switch() statements, however switch() would still
allow the compiler to bisect the case value. It's more efficient to
prioritize the most frequent vmexits instead.

The halt may be slow paths from the point of the guest, but not
necessarily so from the point of the host if the host runs at full CPU
capacity and no host CPU is ever left idle.

Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
---
 arch/x86/kvm/vmx/vmx.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index a6afa5f4a01c..582f837dc8c2 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -5905,9 +5905,23 @@ int kvm_x86_handle_exit(struct kvm_vcpu *vcpu)
 =09}
=20
 =09if (exit_reason < kvm_vmx_max_exit_handlers
-=09    && kvm_vmx_exit_handlers[exit_reason])
+=09    && kvm_vmx_exit_handlers[exit_reason]) {
+#ifdef CONFIG_RETPOLINE
+=09=09if (exit_reason =3D=3D EXIT_REASON_MSR_WRITE)
+=09=09=09return kvm_emulate_wrmsr(vcpu);
+=09=09else if (exit_reason =3D=3D EXIT_REASON_PREEMPTION_TIMER)
+=09=09=09return handle_preemption_timer(vcpu);
+=09=09else if (exit_reason =3D=3D EXIT_REASON_PENDING_INTERRUPT)
+=09=09=09return handle_interrupt_window(vcpu);
+=09=09else if (exit_reason =3D=3D EXIT_REASON_EXTERNAL_INTERRUPT)
+=09=09=09return handle_external_interrupt(vcpu);
+=09=09else if (exit_reason =3D=3D EXIT_REASON_HLT)
+=09=09=09return kvm_emulate_halt(vcpu);
+=09=09else if (exit_reason =3D=3D EXIT_REASON_EPT_MISCONFIG)
+=09=09=09return handle_ept_misconfig(vcpu);
+#endif
 =09=09return kvm_vmx_exit_handlers[exit_reason](vcpu);
-=09else {
+=09} else {
 =09=09vcpu_unimpl(vcpu, "vmx: unexpected exit reason 0x%x\n",
 =09=09=09=09exit_reason);
 =09=09dump_vmcs();