Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp64155ybx; Mon, 4 Nov 2019 15:55:07 -0800 (PST) X-Google-Smtp-Source: APXvYqwrJu5QtdLin13WReOJZacadhM7NPKaq4MCoLUbo8rkERV6dCxtK2n1N5PbR2otqVrMii0T X-Received: by 2002:a17:906:e2c2:: with SMTP id gr2mr26493165ejb.31.1572911707759; Mon, 04 Nov 2019 15:55:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572911707; cv=none; d=google.com; s=arc-20160816; b=GNHbrF6GvQQR5ETNeoRooAejeuSwh4RnGE1FBHQ+jHgfrPL7j1R2WKO4Y7NjTuFhO6 PRLXwpOEcsM7gnzwJUlh8DTi2SBEhumPBYJqwoRWSPZ6OKjVWK2sBCXqFeHekHhVmKzH C0BwZek1NxMBqpBUmsOlbdlQjLcCmCGlx9dvfRyQy1b99w3f4zSPHgjaWEHGt2V4ZQ1r ITH7PPlQtENBxjW9cqQsH9uXx2rGTWNt864VuJnrb5J71BurkjebOl4xpoaQsQPeOxWw iyCAvMoDn5uTGmLPmDMTfUlTUzPJa3snlgTTYMKzEvuigg+UWyGOm71wWhEQfeWAoqgo 97PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hKQIOkvsEVy33JAGixmFXbJUTJzULvc42wk0hYwJ+hI=; b=Pfr4grUT+E8Ijwn4FuSE3L4jNh/cx8gsARrSBUfxVcKKU/VUDUgUbbCX6kfqRUi2L/ U8wNogfdZ3/GQAARoOjRf54Ytb4S313cXE5X12D/ZEKMff8taAcQXBRKLoLN6aAlvcBy gWT5xecALoZjOSXcUvKj7ffYkVuj46dVUsDSSrep+CgAFD04IwRb/nChkzpcCMbnmCP7 w5Obmt5xhviMPQSIU7/3wi3SRy4NxytVfYOBbT/VpgPk2OLp0RunMjG+vzfK+nZrmx4c 9hv+4qSibxrK0j8UFDJ/C5mzkR/VYrcgllMuh612I840MqxU8+ZZLrUKfve04oI2mjMR P8+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="tEW4v9A/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ss14si6112337ejb.195.2019.11.04.15.54.44; Mon, 04 Nov 2019 15:55:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="tEW4v9A/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730026AbfKDXxn (ORCPT + 99 others); Mon, 4 Nov 2019 18:53:43 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:34950 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729714AbfKDXxn (ORCPT ); Mon, 4 Nov 2019 18:53:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hKQIOkvsEVy33JAGixmFXbJUTJzULvc42wk0hYwJ+hI=; b=tEW4v9A/ErwCu+FB/NjUEr8VU Qea9oQmy5T7hF2x7dZiQkO1vmZjaLTBfE2dhrF7txTiinFDZ/ZyfVp2Gp9iUbuZRYYfogTmVg/cK/ 5kc3UlQ4qPKI9VCRgiPu9WUghW6yao3Ex3Ybw49A2OZzB6Lq/PpWc9rrsQs4cBnnADF5MKtbAOPZN PbaAWqAFj0iDYudecR62IvYI3RqkvHYgTSXnsSj0Qxaq4CImGzBmlDNmiM/Z99Gkym+cWcbwyJnoG FuLryGYuGlBiQeoAGLYL76OZYy2vYYJ4/1CBWC8fFSJTRXRCeDFdGRdyIRntGAQvJlD7LQu8Ks0Uh Kuzkwvo6Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRmAG-0003id-5y; Mon, 04 Nov 2019 23:53:40 +0000 Date: Mon, 4 Nov 2019 15:53:40 -0800 From: Christoph Hellwig To: Thomas Gleixner Cc: Masahiro Yamada , Greg Kroah-Hartman , linux-spdx@vger.kernel.org, Linux Kernel Mailing List Subject: Re: spdxcheck.py complains about the second OR? Message-ID: <20191104235340.GA13961@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 04, 2019 at 11:11:53PM +0100, Thomas Gleixner wrote: > On Fri, 1 Nov 2019, Masahiro Yamada wrote: > > scripts/spdxcheck.py warns the following two files. > > > > $ ./scripts/spdxcheck.py > > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: OR > > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: OR > > > > I do not understand what is wrong with them. > > > > I think "A OR B OR C" is sane. > > Yes it is, but obviously we did not expect files with 3 possible > alternative licenses. And I'm kinda happy about this warning because people are overdoing it. There is no point for the Linux-OpenIB license in this case, as it is just a BSD license with copy and paste errors. I think the right fix is to ask the authors to just drop it.