Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Nov 2019 19:29:15 -0500
From:   Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To:     Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Cc:     outreachy-kernel@googlegroups.com, manasi.d.navare@intel.com,
        hamohammed.sa@gmail.com, daniel@ffwll.ch, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH VKMS v3] drm/vkms: Fix typo and preposion in function
 documentation
Message-ID: <20191105002914.wvscxesn2ecno5w3@smtp.gmail.com>
References: <20191104161424.18105-1-gabrielabittencourt00@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="335jnswaoauvhj7y"
Content-Disposition: inline
In-Reply-To: <20191104161424.18105-1-gabrielabittencourt00@gmail.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--335jnswaoauvhj7y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Gabriela,

Did you double-check for other typos?

Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>

Thanks

On 11/04, Gabriela Bittencourt wrote:
> Fix typo in word 'blend' and in the word 'destination' and change
> preposition 'at' to 'of' in function 'blend' documentation.
> And change the task introduction word 'Todo' for the word all in uppercase
> - 'TODO'. With the TODO word all in uppercase (as it's the standard) it's
> easier to find the tasks that have to be done throughout the code.
>=20
> Changes since V3:
>  Rodrigo:
>  - Merge the patch series into a single patch since it contains one single
>  logical change
>=20
> Changes since V2:
>  - Add fix typo in  word 'destination'
>  - Add change of the preposition
>  - Fix the name of the function in log message
>  - Add the change in word 'Todo'
>=20
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
>=20
> ---
>=20
> I've tested the patch using kernel-doc
> ---
>  drivers/gpu/drm/vkms/vkms_composer.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/=
vkms_composer.c
> index d5585695c64d..4af2f19480f4 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -43,18 +43,18 @@ static uint32_t compute_crc(void *vaddr_out, struct v=
kms_composer *composer)
>  }
> =20
>  /**
> - * blend - belnd value at vaddr_src with value at vaddr_dst
> + * blend - blend value at vaddr_src with value at vaddr_dst
>   * @vaddr_dst: destination address
>   * @vaddr_src: source address
>   * @dest_composer: destination framebuffer's metadata
>   * @src_composer: source framebuffer's metadata
>   *
>   * Blend value at vaddr_src with value at vaddr_dst.
> - * Currently, this function write value at vaddr_src on value
> + * Currently, this function write value of vaddr_src on value
>   * at vaddr_dst using buffer's metadata to locate the new values
> - * from vaddr_src and their distenation at vaddr_dst.
> + * from vaddr_src and their destination at vaddr_dst.
>   *
> - * Todo: Use the alpha value to blend vaddr_src with vaddr_dst
> + * TODO: Use the alpha value to blend vaddr_src with vaddr_dst
>   *	 instead of overwriting it.
>   */
>  static void blend(void *vaddr_dst, void *vaddr_src,
> --=20
> 2.20.1
>=20

--=20
Rodrigo Siqueira
Software Engineer, Advanced Micro Devices (AMD)
https://siqueira.tech

--335jnswaoauvhj7y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4tZ+ii1mjMCMQbfkWJzP/comvP8FAl3AwloACgkQWJzP/com
vP+wqA//RY1Usj+euFpORZ/pNoIlcFq/SrA/bmS4Iys6TkbVypP114kOmX4EyG3f
Tvbeb32D0lsPv+d3pcqMENJfT4Gef0LS9t9wXuhoAdfcfs83FAsPvxRW44G0U40F
lMVjp13b9pjmsxs74NcxoyEmc7BFfi5sjvZd3dKZS2W/dknvBWrWutrSptNE1iLs
w17SGsiNSx11c92i74pFMf1wD/bw868+53+dhQT1b4QfA8E/WgUs9aAd99I0T7iN
RCiOWUpHgXQ+E/1koZ1XvESECEi1ByBoalQG/MxzY53fJe97oKolUKq7tSmtVwer
Xw4zad+WXVa9hUjoqzoTfPrY0OOX3WgW5Ger+jepbSaGGRWB4qYLuHU89S1uJ6qL
wlYnMVGngOs5Z7Ee46i0Hn57C2q7foSg4xbetYTo3DUqPlTTswr9wIdUsnmgWEaC
5MRRk//wuCBGlef+TDjPyY0Z84aRKKFLR+fYX6kVYsGacRQ2gn8dUtzD9N+jSWd7
5kxwX73u+D1Tm5093lN053VtyOaZn6ESwPTmKHpj4Xd3BIailr3d2Q0H/gACdXr3
uP15UPitWukP5qTXZcuAvFI5rg87qF9yxZ4zxzIGbs6eqWOFT2RhhZA5wdUJ+rcb
+UvXuSowTajR4bs6z6MUUIxEowrzVg+MuHS+ZRXNqDbIMw5z+H8=
=zC3i
-----END PGP SIGNATURE-----

--335jnswaoauvhj7y--