Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp146748ybx; Mon, 4 Nov 2019 17:28:46 -0800 (PST) X-Google-Smtp-Source: APXvYqzwIVRyVLP2PMi1tBXoBysHUfyPKyh2sr43bx1igXuXkv8nTHATIWcDeg3tAhKK25LtNats X-Received: by 2002:a17:906:9248:: with SMTP id c8mr10474765ejx.47.1572917325976; Mon, 04 Nov 2019 17:28:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1572917325; cv=pass; d=google.com; s=arc-20160816; b=gdHPk35rIANogyQj9p0rLXMoEE+wF4hCjD+6kRrUs5xOpYn3qecbgBHRbHH4RSGRmb aLPIXNLZfyyDKyM4CTAEqPacRrbfNTgo41hjCFzwSbe0zJhAPy39DQhZOMH4svjUpVbT OdxGMMODv6RDcyoJ1IXIAw7fc85yyKkSD3LYyaw5fl+ouJLexD1tLcJeTBYRIsStn0uL Hg8PH5HlNYjdtlYaDeN3RK0IPWZR2h3zEkq2qLaFil6oTm1e/XpxjG8PpyjgMrx6YBgu Yarf7gPDOYpbdJvsw9pjPVnLjvX7Ky6kxAsNr1H4sn45+iNEKDiamM2WssqjTE7t9wM3 RerQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=qMOVjAt1VYYboK4zPX1TqnonFZseXvy6Pkc5OG8z1xs=; b=RS89UfnZra/Ip0zAf8n3/d0fjMwRPybNUrlMVP5EBUVLEiy0f3FaLB6Ta1QYCZbT64 CYlrFND1YGSV+vhhiniXCJT3REprc5rtkYPlW+Hq1uZsp2xCI8eGWSl7S6GVqFq8niOL nw9QrGzGM/3IYLEt3ljlvikMseIhVWOlhZZYFymmXUWDz4xmC7XotNQM0GBOyb93uflX qfhoSk0BVVXUd9XE+0TwEDOWoFHEc18rsBv1MfzthY4djE5GQKI/7sRpDwXO+cPrXUiN 09+ehWPhSerMj5Qb3MVt4uNVphILqaOhLf4oQYWXnaq7GxIm8PGMwhjaBJxKP3WX7afQ Tw+A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=XefkI+Mr; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id lw2si6985665ejb.440.2019.11.04.17.28.21; Mon, 04 Nov 2019 17:28:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=XefkI+Mr; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730151AbfKEB1O (ORCPT + 99 others); Mon, 4 Nov 2019 20:27:14 -0500 Received: from mail-eopbgr10065.outbound.protection.outlook.com ([40.107.1.65]:53572 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729632AbfKEB1O (ORCPT ); Mon, 4 Nov 2019 20:27:14 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ag+iit+aCjrsh5sHt1gptRtHzk06M4Ph0NISAuWpFCifc6/uTB9KC5hsywWNrLCVcRf7tGsbhwPzP2ksyrNmMBWVOsXT4k3ej3R+MToUgTwsAVWn16QxjE94ZQTy+Rx3oxJTu7eMMBPE5r43YogEbHCHnjQQaI3TzSQ/Nmx3dqJCeYQ3qsaRnMqDPJPwkGCSjvJXkeOniiSEQTEEJiryRJ3fXMWuUf0jZQ+AV0RhQDPoCyF4z86zwCb//ERzLIxOGXFoyC52obJBO01frOzGnqNKhJyawTL/fO1jh2IEGwGmXeJJwpCbv7BkmuP6+ypAXokp2tSgaxxnGzcPOXut+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qMOVjAt1VYYboK4zPX1TqnonFZseXvy6Pkc5OG8z1xs=; b=iD5iDzG1VqdyX6C39IGGG/L+joIPOWspunYBDapm5YZzf39QrW8DTP+cWHOGoQ8mGxkqKSi4lvD1W+Jig6mNIBxK1Qs60vrtz4wvaqepxdQ233cgAwMXsPUid+SGUEUuF/V/K1jZ7HGvUKIbanK8FxWpk6/l/bMueFwfRU4CvEJUvjRk4J2RcYrmQBWtARpEv8TGLQmJMUgfrRZFgaEa3hYStwnvl1xQWa9kI+Pqpn2K04Z7THd1hzwePL8u9cMBmKifCmWGCu5YaD9waFCKFtXDnnEPfu+cD7w0Uw6H41PmSWtvLUUDESIdyNSSV6jMnqUwkHqBiT/UG6M3lC+VFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qMOVjAt1VYYboK4zPX1TqnonFZseXvy6Pkc5OG8z1xs=; b=XefkI+MrN3apsTL5lsG+4t+H/EYaeMKJWK02YArSi64RuET5lJ2eMLhxyJiErBMxX5/HoKqpjjIzVUjEnUjFcRgrHWGixXUnHOdd4aPwSx+L3OV8tXHFgj3fXlJNefDUGqbae+6ajaawEta/JOHeZJnaZzbYfl+PHLhm4Bi9OrE= Received: from VI1PR0402MB3600.eurprd04.prod.outlook.com (52.134.3.146) by VI1PR0402MB3951.eurprd04.prod.outlook.com (52.134.13.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Tue, 5 Nov 2019 01:27:10 +0000 Received: from VI1PR0402MB3600.eurprd04.prod.outlook.com ([fe80::5dd6:297c:51e5:2b52]) by VI1PR0402MB3600.eurprd04.prod.outlook.com ([fe80::5dd6:297c:51e5:2b52%7]) with mapi id 15.20.2408.024; Tue, 5 Nov 2019 01:27:10 +0000 From: Andy Duan To: David Miller , "hslester96@gmail.com" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [EXT] Re: [PATCH] net: fec: add missed clk_disable_unprepare in remove Thread-Topic: [EXT] Re: [PATCH] net: fec: add missed clk_disable_unprepare in remove Thread-Index: AQHVk0caR3l97muk7USTxO6JUo1aF6d7yY3A Date: Tue, 5 Nov 2019 01:27:10 +0000 Message-ID: References: <20191104155000.8993-1-hslester96@gmail.com> <20191104.113601.407489006150341765.davem@davemloft.net> In-Reply-To: <20191104.113601.407489006150341765.davem@davemloft.net> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=fugang.duan@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 40607455-b0a0-413f-0912-08d7618f47a7 x-ms-traffictypediagnostic: VI1PR0402MB3951: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:475; x-forefront-prvs: 0212BDE3BE x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(189003)(199004)(66556008)(66476007)(7736002)(2906002)(305945005)(52536014)(66066001)(256004)(25786009)(7696005)(6116002)(3846002)(316002)(186003)(476003)(26005)(110136005)(76176011)(99286004)(8936002)(6246003)(4744005)(86362001)(54906003)(64756008)(66446008)(2501003)(5660300002)(81156014)(81166006)(102836004)(66946007)(4326008)(486006)(8676002)(446003)(55016002)(229853002)(6436002)(14454004)(74316002)(478600001)(71200400001)(11346002)(71190400001)(6506007)(9686003)(76116006)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3951;H:VI1PR0402MB3600.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X9kg83riwu5xjNGFvuJC5+m7cACBSLQbTXwQu62fBVFS/KUSxjgMP/nnpNcKJVIef5Ueo2QAfTHkVVtVQxinmPLGJq5CJfguOC/RUgjV1hmWjo2Xu0Ai3h7HnN8q5WwqV1rowmeAtysRIOIedDtGQPOm7cyGyo96tcomRoV0EUJJpMyf6AzWSYY8RZFYC5yQpvUeS5z5tVylwK73s98ei22DLfZF3jZiH23BAlC07OxSNTAyYd+asFkLUus1IJ13OWVXCr2nXybxaR7WAtn41fwtbBjdJTyb7NFYRFm+kpXqNoLDLy9E4pVSKg7iHmpfkz71c7glQXI0U2lYjooqq+FIbx5ddumYXjiRNWSXDiA8MNdHqn7As0vAXM/cuicUpfWUYTcC/vS1ZbJAx5zRmgedG3V/T7Ax5Gyfd50UlzsNP8HYGuDvBuEAN1J9fj+Q x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40607455-b0a0-413f-0912-08d7618f47a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 01:27:10.5581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3pID87XMWsXnsEBRst9Cqlwcw5XHUy94CRCrPsVfRa52EqCwJbxFVsLy1TNwpPbmisYmJulyt5uGnRa0Gdt98A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3951 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Miller Sent: Tuesday, November 5, 2019 3:= 36 AM > From: Chuhong Yuan > Date: Mon, 4 Nov 2019 23:50:00 +0800 >=20 > > This driver forgets to disable and unprepare clks when remove. > > Add calls to clk_disable_unprepare to fix it. > > > > Signed-off-by: Chuhong Yuan >=20 > Applied. David, the patch introduces clock count mismatch issue, please drop it. Regards, Andy