Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp150594ybx;
        Mon, 4 Nov 2019 17:33:28 -0800 (PST)
X-Google-Smtp-Source: APXvYqyCo8NB5Vn6jx1qPmnKPeyVf89STOKNZ44E6DQWMCxv2x8qQiTyzFm1Sgc2vSuPqcjZGD6H
X-Received: by 2002:a17:906:b7c6:: with SMTP id fy6mr11652897ejb.90.1572917608786;
        Mon, 04 Nov 2019 17:33:28 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1572917608; cv=none;
        d=google.com; s=arc-20160816;
        b=isFJ48AWvpT14p4KqNG7Hr619SCzuDdeDMhzB4o/5FwtoyFWF6IlMKNKH1K0jR0jvU
         z0T0YJiA/8A86BR6Y7bjUchKCUhJf9OvB8XcR7RE3Gz37HaiUfH/Z18maZ/zfTK326d7
         hWK8diNAIIi6VRrEhiqrK+uyDnqsUnwfq+4gzHF7SPESJiLWk8wurKvO175YGqpoXdra
         JMfWfE6UMquzIHFGzeRzeEhcitKVp5TvdZA8JZ5ym44dHfGEaoiR01T/hR03S5TRJSNz
         CxyX7yCdGjBCd4ovuUe6HhrI6C4ojxjPDZy2u6gBl4WTOr+FSidrc2DDq7Wv/o4nOm7+
         fnNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=EjTlvR61V5/FWVwW7gDZXmNeDFM98KjNN/O9wDH0dU4=;
        b=p+7aaOxC0N3DSB26+a81D0ZSbZBhfAsKKoqds5pTqqwmEg2ztj2/2+LJa519BGIL0+
         BDwF9j8E/WKmKk/vC/cadGv9TugO6xNXUHHEQRoz4DXos7Tio4183iyRI/C1LClKVNHH
         zgVpZ2h1W1mAXNq6OgjOjBcuYIZA75zifDKBNxUt19Qa1a/sKRZTDO+X4tunQ8/hZfP5
         Tb62eTWg4daR4XE0DXydlsEmb3SPc1hRYJG36LTZXPgIsoJwzSW8lmPHSUGeGNIJq8ZZ
         0hlIKdGyqpJ3Bc8WGCN80fu2P9r7BxB+uwt+A687GqFcEIPiktOX5cFB6o0Hu07yYpVw
         HYkA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id lw2si6985665ejb.440.2019.11.04.17.33.06;
        Mon, 04 Nov 2019 17:33:28 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730128AbfKEBc3 (ORCPT <rfc822;thunderbird.krnldev@gmail.com>
        + 99 others); Mon, 4 Nov 2019 20:32:29 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:54724 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728987AbfKEBc3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Nov 2019 20:32:29 -0500
Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id EF3DC15252E0F;
        Mon,  4 Nov 2019 17:32:28 -0800 (PST)
Date:   Mon, 04 Nov 2019 17:32:26 -0800 (PST)
Message-Id: <20191104.173226.388214102826562799.davem@davemloft.net>
To:     fugang.duan@nxp.com
Cc:     hslester96@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [EXT] Re: [PATCH] net: fec: add missed clk_disable_unprepare
 in remove
From:   David Miller <davem@davemloft.net>
In-Reply-To: <VI1PR0402MB360095D673E33032706C5BEAFF7E0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20191104155000.8993-1-hslester96@gmail.com>
        <20191104.113601.407489006150341765.davem@davemloft.net>
        <VI1PR0402MB360095D673E33032706C5BEAFF7E0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Nov 2019 17:32:29 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Andy Duan <fugang.duan@nxp.com>
Date: Tue, 5 Nov 2019 01:27:10 +0000

> From: David Miller <davem@davemloft.net> Sent: Tuesday, November 5, 2019 3:36 AM
>> From: Chuhong Yuan <hslester96@gmail.com>
>> Date: Mon,  4 Nov 2019 23:50:00 +0800
>> 
>> > This driver forgets to disable and unprepare clks when remove.
>> > Add calls to clk_disable_unprepare to fix it.
>> >
>> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
>> 
>> Applied.
> 
> David, the patch introduces clock count mismatch issue, please drop it.

Please send me a revert, I'm backlogged at the moment.

Thanks.