Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp262075ybx; Mon, 4 Nov 2019 20:01:32 -0800 (PST) X-Google-Smtp-Source: APXvYqw9SVozjtD/aJWOguAXEaFmnvl9f6ZmCXhhcucINxLosDSn8M+N1gEUoSn5NsL20C1HM2gh X-Received: by 2002:a17:906:e101:: with SMTP id gj1mr28118825ejb.253.1572926492506; Mon, 04 Nov 2019 20:01:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572926492; cv=none; d=google.com; s=arc-20160816; b=Uov06Zf8L06J4gqsOPS/dZqY8fADkYo22umIilEz1mmqnoh3Vcxgt2GvWvOtxuOQDa LBTBThA1KO7rs2h4dxLx/BXhizWT6osW84LSWRL2csh9sCAPPZZkho/fyCs2wIxoOeHW 68r3BgIzieq4It/+2wsUx/LZzPQQ03uBje3DNIK6ji37EdWQE5MQ601FDPvH4/tiG3Y3 xWRlyruX9NVMHOetGU0AC/Fvu/Pu3qR2y1TFaUG5+92HkgVxWhEJq2/JDcttZAE7titq DQp3m1MuFBU9hx8MoWf4A44yPoVmk3/C2hn+a7Bl9rfJWKOoeOBXXDsOZT4Jtel34iPj GBaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature; bh=qTyiyL5nN4wzPhBcXzQt09WTpywYrn7C4dHnHzpIs4s=; b=rmqWwXCZDYVqBh7HzPhVIn9GyWGUC/flvMj0M/3nxYBpIc0JHSfa2XqCjC8NPufDQC pLgt8RLcum9/YBB0nVByAdgyeuotq3IyIvC4thb2K1fXLXkAoyH5IK0jE2b43V5Wisnv A5hzw/OkCmSF171zNRbQiEFpCW9R6wv39RcgUEUlgHftxmaTARVj/navy/0Lg64icrZs p17XKgXh7XOpu+cWNYAUdBQHtDSPERq6Do1bvoABVUagTgdaRe4yq9nN+JqlVb+//ogp OgN+BV0dIW8lZ4waum8DoQFGOctNnGeRNmY+UVEFIQdXaYzW35Cbjf2MAUjhCe/Ea5rf twzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EUhbMqdm; dkim=pass header.i=@codeaurora.org header.s=default header.b=LKtm3vCY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si12248375ejc.213.2019.11.04.20.01.08; Mon, 04 Nov 2019 20:01:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EUhbMqdm; dkim=pass header.i=@codeaurora.org header.s=default header.b=LKtm3vCY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730467AbfKEEA2 (ORCPT + 99 others); Mon, 4 Nov 2019 23:00:28 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34482 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730017AbfKEEA1 (ORCPT ); Mon, 4 Nov 2019 23:00:27 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D1EC560EE6; Tue, 5 Nov 2019 04:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572926426; bh=KXlcTtuXcJB8YvdOR6kq1K60cVzJa2GqQG8wQRd1wPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EUhbMqdm3Ktj6u7mDbHb4cvfJ1E6poHyeBLy5FCyvEyEWJvSSepi/ZvcIqmoYId4z mY1Yxh3E2g4gKSkF/y82w8zmG8LGhHA3RP7E16WU/pYjAiLfVpMDT2LMBYedg5uo5/ IP8gdgAgWqs+XylMvUSRJvgsA6tUrPYIZAp72DAE= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from pacamara-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: cang@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3015560EE3; Tue, 5 Nov 2019 04:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572926425; bh=KXlcTtuXcJB8YvdOR6kq1K60cVzJa2GqQG8wQRd1wPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LKtm3vCYEoM/SeXnKppSKWSbtrt+FxzEgvMwWuKt5ccVxyuIkQ1sgBm3ksGWmu2AZ msrfHPx0Rwld41mFt04HyMwbohZapeIfyLNpkP5TvfCiDGuWCSupv6sOCcyGo+JPvz 5nRcBm8MHsuHgCKxdI+xrGUvecwofwqhChVrAM/g= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3015560EE3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=cang@codeaurora.org From: Can Guo To: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, cang@codeaurora.org Cc: Alim Akhtar , Avri Altman , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , Tomas Winkler , Venkat Gopalakrishnan , Subhash Jadavani , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v3 4/7] scsi: ufs: Fix register dump caused sleep in atomic context Date: Mon, 4 Nov 2019 19:57:12 -0800 Message-Id: <1572926236-720-5-git-send-email-cang@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1572926236-720-1-git-send-email-cang@codeaurora.org> References: <1572926236-720-1-git-send-email-cang@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ufshcd_print_host_regs() can be called by interrupt handler, but it may sleep due to ufshcd_dump_regs() allocates the dump buffer memory with flag GFP_KERNEL. Fix it by changing GFP_KERNEL to GFP_ATMOIC. Signed-off-by: Can Guo Reviewed-by: Bean Huo --- drivers/scsi/ufs/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index f12f5a7..671ea2a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -117,7 +117,7 @@ int ufshcd_dump_regs(struct ufs_hba *hba, size_t offset, size_t len, if (offset % 4 != 0 || len % 4 != 0) /* keep readl happy */ return -EINVAL; - regs = kzalloc(len, GFP_KERNEL); + regs = kzalloc(len, GFP_ATOMIC); if (!regs) return -ENOMEM; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project