Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Nov 2019 10:03:26 +0530
From:   Bhaskar Chowdhury <unixbhaskar@gmail.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     bfields@fieldses.org, yamada.masahiro@socionext.com,
        michal.lkml@markovi.net, linux-kbuild@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts:prune-kernel:remove old kernels and modules dir
 from system
Message-ID: <20191105043323.GA27350@Gentoo>
References: <20191102063036.28601-1-unixbhaskar@gmail.com>
 <50680c37-9e85-0050-c1e1-700260a0471c@infradead.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ibTvN161/egqYuK8"
Content-Disposition: inline
In-Reply-To: <50680c37-9e85-0050-c1e1-700260a0471c@infradead.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ibTvN161/egqYuK8
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 18:03 Mon 04 Nov 2019, Randy Dunlap wrote:
>On 11/1/19 11:30 PM, Bhaskar Chowdhury wrote:
>> This patch allow you to remove old kernels and associated modules
>> directory from the system.You can do it at once with the -r flag
>> and interactively with the -i flag.
>>=20
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  scripts/prune-kernel | 82 +++++++++++++++++++++++++++++++++++---------
>>  1 file changed, 65 insertions(+), 17 deletions(-)
>
>Hi,
>I believe that this script now does what the patch author intends it to do.
>It does have a few whitespace issues, but no big deals.  (see below)
>
>Tested-by: Randy Dunlap <rdunlap@infradead.org>
>
>
Thank you Randy..
>> diff --git a/scripts/prune-kernel b/scripts/prune-kernel
>> index e8aa940bc0a9..01d0778db71f 100755
>> --- a/scripts/prune-kernel
>> +++ b/scripts/prune-kernel
>> @@ -1,21 +1,69 @@
>>  #!/bin/bash
>>  # SPDX-License-Identifier: GPL-2.0
>> +#This script will remove old kernels and modules directory related to i=
t.
>> +#"-r" or "--remove" show how to silently remove old kernel and modules =
dir.
>> +# "-h" or "--help" show how to use this script or show without paramete=
r.
>> +#"-i" or "--interactive" show how to remove interactively.
>> +
>> +flag=3D$1
>> +kernel_version=3D$2
>> +modules_version=3D$3
>> +boot_dir=3D/boot
>> +modules_dir=3D/lib/modules
>> +
>> +remove_old_kernel() {
>> +	cd $boot_dir
>> +	rm -If vmlinuz-$kernel_version System.map-$kernel_version config-$kern=
el_version
>> +	return 0
>> +}
>> +
>> +remove_old_modules_dir() {
>> +	cd $modules_dir
>> +	rm -rf $modules_version
>> +	return 0
>> +}
>> +
>> +usage() {
>> +	printf "Usage: $(basename $0) [-ri]\n"
>> +	printf "\n -r or --remove  kernel_version modules_version\n"
>> +	printf "\n -i or --interactive do as interactive way\n"
>> +	return 0
>> +}
>> +
>> +case "$flag" in
>> +	-i | --interactive)
>> +		printf "\nEnter kernel version to remove or blank/empty to exit:"
>> +		read kernel_version
>> +		if [[ $kernel_version !=3D "" ]]; then
>> +			remove_old_kernel
>> +			printf "\nRemoved kernel version:$kernel_version from the system.\n\=
n"
>
>space after ':'
>
>drop one \n above.
>
Will do.
>> +			printf "Please give the full modules directory name to remove:"
>> +			read modules_version
>> +			if [[ $modules_version !=3D "" ]]; then
>> +				remove_old_modules_dir
>> +				printf "\n\nRemoved modules directory:$modules_version from the sys=
tem.\n\n"
>
>space after ':'
>
>drop one \n above.
>
Will do.
>> +			else
>> +				exit 1
>> +			fi
>> +		fi
>> +		;;
>> +	-h | --help)
>> +		usage
>> +		exit 0
>> +		;;
>> +	-r | --remove)
>> +		if [[ $# -ne 3 ]]; then
>> +			 printf "You need to provide kernel version and modules directory na=
me.\n"
>> +			 exit 1
>> +		 else
>> +			 remove_old_kernel
>> +			 remove_old_modules_dir
>> +		fi
>> +		;;
>> +	*)
>> +		usage
>> +		exit 1
>> +		;;
>> +esac
>>=20
>> -# because I use CONFIG_LOCALVERSION_AUTO, not the same version again and
>> -# again, /boot and /lib/modules/ eventually fill up.
>> -# Dumb script to purge that stuff:
>>=20
>
>OK, the former script's loop is removed.. good.
>But the 2 preceding blank lines are not removed, so the script
>now ends with 2 unnecessary blank lines.
>
Will do.
>> -for f in "$@"
>> -do
>> -        if rpm -qf "/lib/modules/$f" >/dev/null; then
>> -                echo "keeping $f (installed from rpm)"
>> -        elif [ $(uname -r) =3D "$f" ]; then
>> -                echo "keeping $f (running kernel) "
>> -        else
>> -                echo "removing $f"
>> -                rm -f "/boot/initramfs-$f.img" "/boot/System.map-$f"
>> -                rm -f "/boot/vmlinuz-$f"   "/boot/config-$f"
>> -                rm -rf "/lib/modules/$f"
>> -                new-kernel-pkg --remove $f
>> -        fi
>> -done
>> --
>
>
>--=20
>~Randy
>
Bhaskar

--ibTvN161/egqYuK8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAl3A+48ACgkQsjqdtxFL
KRVpDQgA0c8060YO3XdTlh547axg5JL0CI+xBlRvYOltRP7LNrqoGYssxXzJAvoW
vr6f6dvhWoN3a+KGfiYRiWAxejFVGbwGeT7rBCz21tt/gvkG+8QKkvKttysT5g3m
1LL/s0XFh5qrnayU0tLb7Ql07s9MXegrJn9iUKqimATOow/SVGqN3/YJwNwtS3bR
cNx2aDfzRxBnFuwrFLO3nsMtI8slQtl8nryCrMekhug13qYCS21UJATyv4qnE8eP
seeuGNDrPAKV/HIvLxrt+C0ZjScnSuoNgCVu93LmF+LMDc7mB/LGruFbE6md996v
iqmNpGgkbpSjL68VG9FWvqGNDaiTgg==
=08zP
-----END PGP SIGNATURE-----

--ibTvN161/egqYuK8--