Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/memory-failure.c: replace with page_shift() in
 add_to_kill()
To:     Yunfeng Ye <yeyunfeng@huawei.com>, n-horiguchi@ah.jp.nec.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        "hushiyuan@huawei.com" <hushiyuan@huawei.com>,
        "linfeilong@huawei.com" <linfeilong@huawei.com>
References: <7bc9d610-728c-37b0-d175-dba21dc0dfff@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <ad7d1d04-a734-6e9e-1222-215e1329cc98@redhat.com>
Date:   Tue, 5 Nov 2019 09:57:59 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <7bc9d610-728c-37b0-d175-dba21dc0dfff@huawei.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05.11.19 09:21, Yunfeng Ye wrote:
> The function page_shift() is supported after the commit 94ad9338109f
> ("mm: introduce page_shift()").
>=20
> So replace with page_shift() in add_to_kill() for readability.
>=20
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
>   mm/memory-failure.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 3151c87dff73..e48c50cac889 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -326,7 +326,7 @@ static void add_to_kill(struct task_struct *tsk, stru=
ct page *p,
>   =09if (is_zone_device_page(p))
>   =09=09tk->size_shift =3D dev_pagemap_mapping_shift(p, vma);
>   =09else
> -=09=09tk->size_shift =3D compound_order(compound_head(p)) + PAGE_SHIFT;
> +=09=09tk->size_shift =3D page_shift(compound_head(p));
>=20
>   =09/*
>   =09 * Send SIGKILL if "tk->addr =3D=3D -EFAULT". Also, as
>=20

Reviewed-by: David Hildenbrand <david@redhat.com>

--=20

Thanks,

David / dhildenb