Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp551151ybx; Tue, 5 Nov 2019 01:41:40 -0800 (PST) X-Google-Smtp-Source: APXvYqyS1Qr9FwcP/clngyTjW4RYg9oehcFAZYVRyWu0y6ak+5DY/C2STGjJUo5KTv0EI0ZPxJH9 X-Received: by 2002:a17:906:1fd5:: with SMTP id e21mr7174616ejt.320.1572946900789; Tue, 05 Nov 2019 01:41:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572946900; cv=none; d=google.com; s=arc-20160816; b=0wcm4OdEp9i7Pa4HvKmwfJlZZTIv9joUynuV7IZdLYikzXLN/KjqkTSpCucrFPC7jt OiYbHWHuozGEx+gMSTuQM0r0jjMDkRcycIBs6/Rvv+htuN/nvpm70sWft4AS328E1sZ0 sF3ra/UlRbKlLymKmHqFY4yrN9BIONXgur1u1IArasy7LijLfXMIJW+dbzraV7NsSM01 18M/jM1lHxtBn/nyx7ejlq+8BET/mRxpSu9x0bs5nvKmLMr1GacH2SnMyzss2oEHRPCi uyIXynHpMpjQMRkpEv7lIqwek1FM+GHtHH5VPKNpEcDv6UVIWUwc/utpNPsf6sT0UtsF G4Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=co+w0k79G3ndnVT1tw2oC6b5nHyZtabUCQzvllnx4dg=; b=f9xDcKTig1JVhJH+BYGwETYQNmGCmwCrmbSA39d0rNYUqLbjqeh+r5IGVNvwe6yYla FsfhmWlediNGNnKm9mTX4ve9LctjdxNyBlR2BXHixV2+oupaZRilulEx4kump3Xf6cX9 iIF2PgRpb/RaXWz2seXNjw2Z8ti6TcH4o0b9xWyXig1mvcaBDyPLQs0u3MaePewG5Em0 k+TzFTcBbCnEPZEEIBCNMFVm/C6Bs4x3H6I6Z/fULrgsvFR3P+3clSKh2v/mw9LgnAHE Rqj1D3eMZbB2EsdszorKqoTTcylnMQfWccvzKA1UK41TvAxbwqlGyTnVltmhkGISDrE1 Wuow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Vl8wn86Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si9655698edc.195.2019.11.05.01.41.17; Tue, 05 Nov 2019 01:41:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b=Vl8wn86Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730896AbfKEJjG (ORCPT + 99 others); Tue, 5 Nov 2019 04:39:06 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:60730 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730769AbfKEJjG (ORCPT ); Tue, 5 Nov 2019 04:39:06 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA59crKN105088; Tue, 5 Nov 2019 09:38:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=co+w0k79G3ndnVT1tw2oC6b5nHyZtabUCQzvllnx4dg=; b=Vl8wn86Z7TBfVgmOyWLrsHJVhFqfpWZA68lrnLDuEW4JBiN/O9rCX+UPVZPg4JGHwx7/ ASYCraCunqDPyfllA5+UbogKpN/WF3P9tno3BAzmzDcA+g9RgCZdUwr0pev0kySL8+YV 5h1g0CCWiSHxQlInsE+di4F5JqXarlWoxQLFMQ+qCDDF5ulVLBH31PBX+1vm5EmUb6/W p06lXZOUSeWf4ZVhm8JxSFumyI1QEooQz0bVMiQjSZYTocDZllRJaHnVj65sYK+aDN3q To8SUomhvgChIlJOqnw8Wxi8NXoRWRs1qAEt144F4wFaSpsrAqjCA8gAxiSF1cCuiV8H jw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2w12er4t9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 09:38:53 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA59XTs4052977; Tue, 5 Nov 2019 09:36:53 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 2w3160yr75-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 09:36:52 +0000 Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA59apol018864; Tue, 5 Nov 2019 09:36:51 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 05 Nov 2019 01:36:50 -0800 Date: Tue, 5 Nov 2019 12:36:41 +0300 From: Dan Carpenter To: Sumit Saxena Cc: Markus Elfring , Linux SCSI List , "PDL,MEGARAIDLINUX" , "James E. J. Bottomley" , Kashyap Desai , Shivasharan S , "Martin K. Petersen" , LKML , kernel-janitors@vger.kernel.org, Chandrakanth Patil , YueHaibing Subject: Re: [PATCH] scsi: megaraid_sas: Use common error handling code in megasas_mgmt_ioctl_fw() Message-ID: <20191105093641.GE10409@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050082 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9431 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050083 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 05, 2019 at 02:58:35PM +0530, Sumit Saxena wrote: > On Fri, Nov 1, 2019 at 3:06 AM Markus Elfring wrote: > > > > From: Markus Elfring > > Date: Thu, 31 Oct 2019 22:23:02 +0100 > > > > Move the same error code assignments so that such exception handling > > can be better reused at the end of this function. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > Acked-by: Sumit Saxena > The code was a lot better originally... :( regards, dan carpenter