Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] mm/memory_hotplug: Fix try_offline_node()
To:     Masayoshi Mizuma <msys.mizuma@gmail.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Tang Chen <tangchen@cn.fujitsu.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Keith Busch <keith.busch@intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Jani Nikula <jani.nikula@intel.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        Michal Hocko <mhocko@suse.com>,
        Oscar Salvador <osalvador@suse.de>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Dan Williams <dan.j.williams@intel.com>,
        Pavel Tatashin <pasha.tatashin@soleen.com>
References: <20191102120221.7553-1-david@redhat.com>
 <20191105012049.x2k4v2xizd2tim5b@gabell>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <495a43af-befb-91f9-0097-9f0b449ff632@redhat.com>
Date:   Tue, 5 Nov 2019 11:07:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <20191105012049.x2k4v2xizd2tim5b@gabell>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05.11.19 02:20, Masayoshi Mizuma wrote:
> 5.4-rc5 with this patch works for memory-hotadd and remove, thanks!
> Please feel free to add:
>=20
>      Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>=20
> Without this patch, memory hotplug fails as panic:
>=20
>   BUG: kernel NULL pointer dereference, address: 0000000000000000
>   ...
>   Call Trace:
>    remove_memory_block_devices+0x81/0xc0
>    try_remove_memory+0xb4/0x130
>    ? walk_memory_blocks+0x75/0xa0
>    __remove_memory+0xa/0x20
>    acpi_memory_device_remove+0x84/0x100
>    acpi_bus_trim+0x57/0x90
>    acpi_bus_trim+0x2e/0x90
>    acpi_device_hotplug+0x2b2/0x4d0
>    acpi_hotplug_work_fn+0x1a/0x30
>    process_one_work+0x171/0x380
>    worker_thread+0x49/0x3f0
>    kthread+0xf8/0x130
>    ? max_active_store+0x80/0x80
>    ? kthread_bind+0x10/0x10
>    ret_from_fork+0x35/0x40
>=20
> - Masa

Thanks a lot for testing!

--=20

Thanks,

David / dhildenb