Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Zavras, Alexios" <alexios.zavras@intel.com>
To:     Joe Perches <joe@perches.com>, Thomas Gleixner <tglx@linutronix.de>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-spdx@vger.kernel.org" <linux-spdx@vger.kernel.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: RE: spdxcheck.py complains about the second OR?
Thread-Topic: spdxcheck.py complains about the second OR?
Thread-Index: AQHVkGx97YY5RqhHq0ueYoAqFuykEad7mOCAgAADfoCAAMSpYA==
Date:   Tue, 5 Nov 2019 10:11:31 +0000
Message-ID: <CY4PR1101MB2360AB7647D9E2FA15044EE4897E0@CY4PR1101MB2360.namprd11.prod.outlook.com>
References: <CAK7LNASwF9y+MkhkvCRATu0qXSJkxx8fZ-DUjQTfWOi9+1YrfQ@mail.gmail.com>
         <alpine.DEB.2.21.1911042310040.17054@nanos.tec.linutronix.de>
 <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com>
In-Reply-To: <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-reaction: no-action
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f364d03-0c7d-4c74-c10a-08d761d8880c
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 10:11:31.8392
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eJQWuUcrvqnWC5lOBalzTGwrh8xlpq3dUieDGqsve+REgd+fmJRBpxCIyAdHI8l4ZTFw3XCMx/PLmG0KtgodXGwsEaq78WcvGogwNCW/flc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2263
X-OriginatorOrg: intel.com
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This is not correct.
Since the grammar includes the production "expr: expr OR expr",
there is absolutely no need to add a rule with more than two operands --
it will be handled recursively.

-- zvr

-----Original Message-----
From: linux-spdx-owner@vger.kernel.org <linux-spdx-owner@vger.kernel.org> O=
n Behalf Of Joe Perches
Sent: Monday, 4 November, 2019 23:24
To: Thomas Gleixner <tglx@linutronix.de>; Masahiro Yamada <yamada.masahiro@=
socionext.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>; linux-spdx@vger.kernel=
.org; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: spdxcheck.py complains about the second OR?

On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote:
> On Fri, 1 Nov 2019, Masahiro Yamada wrote:
> > scripts/spdxcheck.py warns the following two files.
> > =

> > $ ./scripts/spdxcheck.py
> > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: =

> > OR
> > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: =

> > OR
> > =

> > I do not understand what is wrong with them.
> > =

> > I think "A OR B OR C" is sane.
> =

> Yes it is, but obviously we did not expect files with 3 possible =

> alternative licenses.

Perhaps just this, but the generic logic obviously isn't complete.
---
 scripts/spdxcheck.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index 6374e0..00be=
34 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -150,6 +150,7 @@ class id_parser(object):
                 | ID WITH EXC
                 | expr AND expr
                 | expr OR expr
+                | expr OR expr OR expr
                 | LPAR expr RPAR'''
         pass
 =


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928