Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Abel Vesa <abel.vesa@nxp.com>
To:     Peng Fan <peng.fan@nxp.com>
CC:     "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Leonard Crestez <leonard.crestez@nxp.com>
Subject: Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant
 initialization
Thread-Topic: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant
 initialization
Thread-Index: AQHVkvg/xrfIJzKQG0a+hb51V+MVqad8dP+A
Date:   Tue, 5 Nov 2019 11:37:58 +0000
Message-ID: <20191105113757.7emblygbcqfa6gyl@fsr-ub1664-175>
References: <1572862200-29923-1-git-send-email-peng.fan@nxp.com>
 <1572862200-29923-2-git-send-email-peng.fan@nxp.com>
In-Reply-To: <1572862200-29923-2-git-send-email-peng.fan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 8b5ddda4-83f1-4e8b-68d2-08d761e49b74
x-ms-traffictypediagnostic: AM0PR04MB4595:|AM0PR04MB4595:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR04MB45959DDEAEBA6202C9C220B2F67E0@AM0PR04MB4595.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:597;
x-forefront-prvs: 0212BDE3BE
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(39860400002)(396003)(376002)(346002)(366004)(189003)(199004)(86362001)(476003)(478600001)(5660300002)(81156014)(6436002)(1076003)(44832011)(14454004)(486006)(25786009)(33716001)(6636002)(71190400001)(305945005)(71200400001)(7736002)(11346002)(9686003)(6506007)(6512007)(99286004)(229853002)(102836004)(53546011)(52116002)(6486002)(76176011)(316002)(2906002)(386003)(54906003)(6246003)(4326008)(256004)(14444005)(66476007)(66556008)(66946007)(64756008)(66066001)(66446008)(446003)(6862004)(8936002)(81166006)(186003)(26005)(8676002)(6116002)(3846002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4595;H:AM0PR04MB5779.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: aCiiY8Xr1W7vGmM/Z2U/Pdt7lPeYxvcgRhHADcY+nc0zm5sLS7rYRT97NsowwSgIHftgnjk6Git70ZtANy5UWBBvBHIzqIscVuMRo8W6evHEUp/QVx36lH1DcQsG5k29SG42+oq/76pOqQEyVIcbtyI7wZVauFqAdZIJGNcPDKJY2XBalephnsmId+QQxhoiEQ992DRAT2u1WdRqIdgIHvhFnHMrjZpH23HUTBViF7nf+RwD/80KGtqw/Ct6x74I9Jtb/GgiHv6cfvU7hq3K7+US8tfQeqw1fnLQKJjQHjiVNsVYEz6keMs5TeTGjGNeOz0fYNlw0qQAut3CScKjv+TOticv1nlSLrGg8f6X/ZWuSK8Qbxu3FNuretdEKtwKHMkttpjccUWPlUjcfITpYcJdPOEYrua+Bz/+L4hjnW5HosCI8mYO2COEqSY4VPB1
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4DAE11B15D0F814F82A82AE72658CCDF@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b5ddda4-83f1-4e8b-68d2-08d761e49b74
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 11:37:58.7858
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J4q+yUkdCi9aiXspDBFEe1T+WklC3gjZlZET0zbzi5JZoQxMmzMMoFtYNtZJ2psUUr9XwjplB4qggnKEhCPLeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4595
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-11-04 10:11:37, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>=20
> There is no need to initialize flags as 0.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-divider-gate.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-div=
ider-gate.c
> index 214e18eb2b22..4145594af53b 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struc=
t clk_hw *hw,
>  {
>  	struct clk_divider_gate *div_gate =3D to_clk_divider_gate(hw);
>  	struct clk_divider *div =3D to_clk_divider(hw);
> -	unsigned long flags =3D 0;
> +	unsigned long flags;
>  	unsigned int val;
> =20
>  	spin_lock_irqsave(div->lock, flags);
> @@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw,=
 unsigned long rate,
>  {
>  	struct clk_divider_gate *div_gate =3D to_clk_divider_gate(hw);
>  	struct clk_divider *div =3D to_clk_divider(hw);
> -	unsigned long flags =3D 0;
> +	unsigned long flags;
>  	int value;
>  	u32 val;
> =20
> @@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
>  {
>  	struct clk_divider_gate *div_gate =3D to_clk_divider_gate(hw);
>  	struct clk_divider *div =3D to_clk_divider(hw);
> -	unsigned long flags =3D 0;
> +	unsigned long flags;
>  	u32 val;
> =20
>  	if (!div_gate->cached_val) {
> @@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
>  {
>  	struct clk_divider_gate *div_gate =3D to_clk_divider_gate(hw);
>  	struct clk_divider *div =3D to_clk_divider(hw);
> -	unsigned long flags =3D 0;
> +	unsigned long flags;
>  	u32 val;
> =20
>  	spin_lock_irqsave(div->lock, flags);
> --=20
> 2.16.4
>=20