Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>
Subject: RE: [PATCH 06/12] staging: dpaa2-ethsw: add ACL entry to redirect STP
 to CPU
Thread-Topic: [PATCH 06/12] staging: dpaa2-ethsw: add ACL entry to redirect
 STP to CPU
Thread-Index: AQHVk9VwUttQp4rnGEyeNWyFfbjmDKd8oR0AgAAAhWA=
Date:   Tue, 5 Nov 2019 14:31:35 +0000
Message-ID: <VI1PR0402MB28007254BB7614477CED4DBCE07E0@VI1PR0402MB2800.eurprd04.prod.outlook.com>
References: <1572957275-23383-1-git-send-email-ioana.ciornei@nxp.com>
 <1572957275-23383-7-git-send-email-ioana.ciornei@nxp.com>
 <20191105142202.GC7189@lunn.ch>
In-Reply-To: <20191105142202.GC7189@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ddf62c0-005a-46bd-047e-08d761fcdc57
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 14:31:35.1628
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iiYjoMwwBebl+3ZmowflXYxer5+R5RiIPubJMAxLl+xHP4zKtV1PKb1lKuvES+IEbwHJIEjq8mn7VsAKG1MSZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3790
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH 06/12] staging: dpaa2-ethsw: add ACL entry to redirec=
t
> STP to CPU
>=20
> > +static int ethsw_port_set_ctrl_if_acl(struct ethsw_port_priv
> > +*port_priv) {
> > +	const char stp_mac[ETH_ALEN] =3D {0x01, 0x80, 0xC2, 0x00, 0x00, 0x00}=
;
>=20
> I think there is a standard define for that somewhere in include/linux or
> maybe include/net.
>=20
> But thinking about the big picture, i wonder why this is needed, at least=
 in a
> minimal implementation. Bit 0 is set in this MAC address, so it is a L2 m=
ulticast
> frame. By default, all L2 multicast frames should be delivered to the CPU=
. So
> it should work without this.
>=20
>        Andrew

Now I see that I should have been more clear about what our switch can do.

The control queues do not form an actual interface in the sense that the CP=
U does not receive unknown unicast, broadcast and multicast frames by defau=
lt.
For each frame that we want to direct to the CPU we must add an ACL entry.

Ioana