Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1572610108-1363-1-git-send-email-rkambl@codeaurora.org>
 <1572610108-1363-2-git-send-email-rkambl@codeaurora.org> <5dc09bbb.1c69fb81.196e5.9770@mx.google.com>
In-Reply-To: <5dc09bbb.1c69fb81.196e5.9770@mx.google.com>
From:   Amit Kucheria <amit.kucheria@linaro.org>
Date:   Tue, 5 Nov 2019 20:21:22 +0530
Message-ID: <CAP245DWz7qkS3mGEjRA-EfhGieZtOAbnLsPZCHqSG9DL+NvPcg@mail.gmail.com>
Subject: Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Add device node support for
 TSENS in SC7180
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Rajeshwari <rkambl@codeaurora.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        sivaa@codeaurora.org, sanm@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rajeshwari,

On Tue, Nov 5, 2019 at 3:14 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Rajeshwari (2019-11-01 05:08:28)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 07ea393..06ded1d 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -449,6 +465,508 @@
> >                 };
> >         };
> >
> > +       thermal-zones {
> > +               aoss-0-usr {
> > +                       polling-delay-passive = <0>;
> > +                       polling-delay = <0>;
>
> Can we get real polling delays instead of 0?
>
> > +                       thermal-governor = "user_space";
> > +                       thermal-sensors = <&tsens0 0>;
> > +                       wake-capable-sensor;
>
> What is this property?

Downstream property. If you need this, propose changes to the tsens bindings.

> > +                       trips {
> > +                               active-config0 {
> > +                                       temperature = <125000>;
> > +                                       hysteresis = <1000>;
> > +                                       type = "passive";
> > +                               };
> > +                               reset-mon-cfg {
> > +                                       temperature = <115000>;
> > +                                       hysteresis = <5000>;
> > +                                       type = "passive";
> > +                               };
> > +                       };
> > +               };
> > +
> > +               cpu-0-0-usr {
> > +                       polling-delay-passive = <0>;
> > +                       polling-delay = <0>;
> > +                       thermal-governor = "user_space";
>
> What is this property?

Based on a downstream property that was rejected upstream. Please get rid of it.

Regards,
Amit