Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp930561ybx; Tue, 5 Nov 2019 07:43:36 -0800 (PST) X-Google-Smtp-Source: APXvYqziWzvzwQR6tOklHXenG3m1ZfGEskwFFyTl3IY95lKtI357awkF+p1Wth9dl6wSVSk0B0OP X-Received: by 2002:a50:8851:: with SMTP id c17mr21646740edc.60.1572968615985; Tue, 05 Nov 2019 07:43:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572968615; cv=none; d=google.com; s=arc-20160816; b=aMrmjAlw4kTuDrFptbPjdwjYQ/6wSeNjEWzojgOMH8w4GwYhhVgvi0TXusbhsfdkWn uSQ4jsP0d/f04HdZpJq8ALB6cOqAX9vEGvrheP++Lo4h5OXWlOKUU+A/2vMGc/yWFrhv rT1iO/hw/WTJxg3Lt90pQh6KXpYW4DkpDV2tyFluvwPheh5lZ9sN/syu/RxwKIKtXMgc reJGHWOl7KBjpUFj7OS3z46fVg0eKAIL+Vub6mzZFTQc0gXtTsJcTssugqyqNSkSnwL7 8WWhgE+jc/Lb8Lg/lUJ07pMQCloX9oi10VwA4DdledwATEyYnP9vLQypGfvSanwWMpI+ jmYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=cYpV5+o1A/dXvbQaQ7n7dcL2+JD79qjMx+pIX36zQXU=; b=rSyCjMj1Ks0M7RtWRgmVR6ECsMA46T09ctsebqFjQ3dms/yFBO4IV4tdg3uVXSNf+f p8MT3ju/BL/X4ShWPFL/N8v5gZfFAph4oS3UF9zPqj1pAlDWs7x6rp6ILp3xGmGuOarj S/uLFYEnfmEWKt9/jy+UBnPqKA12f2NvEzZKfRvOGv22NF/NKtpmBw86DuiMML2pV9TV 1e6XCRxAfCL9Y/uyS+ezqiXKtnNJj+UKl/GhQ8CHChEeCUgiOajM4fat1SW4FMifSoAn Z+yw57SR+Hjm841pBYQsFI9j85t4m7wN0+thDqTth/lSihZR3NmI5YtxAgg/p7WkFnSL rbBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Si47Mpri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u93si11134170edc.184.2019.11.05.07.43.12; Tue, 05 Nov 2019 07:43:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Si47Mpri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389920AbfKEPlx (ORCPT + 99 others); Tue, 5 Nov 2019 10:41:53 -0500 Received: from mail-ot1-f66.google.com ([209.85.210.66]:35818 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389032AbfKEPlx (ORCPT ); Tue, 5 Nov 2019 10:41:53 -0500 Received: by mail-ot1-f66.google.com with SMTP id z6so18013366otb.2 for ; Tue, 05 Nov 2019 07:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cYpV5+o1A/dXvbQaQ7n7dcL2+JD79qjMx+pIX36zQXU=; b=Si47Mpriw1EKXcSZsKuCqlPm4/dogrxQwhOJv0m772xFHmIUe052ovmhrkWgGU+Bkl jZ5bwHGw4D+uiMu+tsUEztuFOU+SRx0OYmKjn34Oa0IqeWEfvy9uB3oFmhEp4Bk6BxU9 q1whDXxaitjDU2vXBm44oZTDU/eQILq9K0+wk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cYpV5+o1A/dXvbQaQ7n7dcL2+JD79qjMx+pIX36zQXU=; b=kDS0UkTOQXT/S4hFszQLPgC/sgu2MAdE9Jp1cqKPKEw2JOSo9lKT+fZZ/7uNjuHIEK LNHa1vboFPun47V6VTeuFQlijaJm+g+WCmBOkdtINkJQV66dwK7I2CU/uexDqB6ttuhN KhLkw9AvOKX0b9xx3uJ4H99+7i0ySD8Sj5V7BdZJPVS73eImLBUH3egpzpBFoEguMfdV k2sA9z0Mr3sXMi/jMV6xKJZiusL8+VIFp+pe/tIHAVTuw0ETf6d2X0wQYdYDhnUHxxfv NLTqxLqgkWRmG9Y6fQPLzxAEm5gHKSwo4uFjsMcn3iEgd8ts3lZ2Pfne4XkWYWdDF3uX 67YA== X-Gm-Message-State: APjAAAXJyjegyyK2qV358DxDyBg+Fjcb0LFLopMj4HE5QJZaFhxmEbtF 5Sk7/2dHXfG+8DXPu1ODIX8qFuY28OKOAFz4+xNUQQ== X-Received: by 2002:a05:6830:1649:: with SMTP id h9mr1965788otr.281.1572968512490; Tue, 05 Nov 2019 07:41:52 -0800 (PST) MIME-Version: 1.0 References: <20191014184320.GA161094@dtor-ws> <20191105004050.GU57214@dtor-ws> In-Reply-To: From: Daniel Vetter Date: Tue, 5 Nov 2019 16:41:41 +0100 Message-ID: Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get_index() To: Linus Walleij Cc: Dmitry Torokhov , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Heikki Krogerus , "open list:DRM PANEL DRIVERS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij wrote: > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov > wrote: > > On Mon, Oct 14, 2019 at 11:43:20AM -0700, Dmitry Torokhov wrote: > > > > Instead of fwnode_get_named_gpiod() that I plan to hide away, let's use > > > the new fwnode_gpiod_get_index() that mimics gpiod_get_index(), but > > > works with arbitrary firmware node. > > > > > > Reviewed-by: Laurent Pinchart > > > Signed-off-by: Dmitry Torokhov > > > --- > > > > > > Andrzej, Neil, > > > > > > This depends on the new code that can be bound in > > > ib-fwnode-gpiod-get-index immutable branch of Linus' Walleij tree: > > > > > > git pull git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git ib-fwnode-gpiod-get-index > > > > > > I hope that it would be possible to pull in this immutable branch and > > > not wait until after 5.5 merge window, or, alternatively, merge through > > > Linus Walleij's tree. > > > > Any chance this could be merged, please? > > I'm happy to merge it into the GPIO tree if some DRM maintainer can > provide an ACK. Ack. > Getting ACK from DRM people is problematic and a bit of friction in the > community, DVetter usually advice to seek mutual reviews etc, but IMO > it would be better if some people felt more compelled to review stuff > eventually. (And that has the problem that it doesn't scale.) This has a review already plus if you merge your implied review. That's more than good enough imo, so not seeing the issue here? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch