Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: nicolas.dichtel@6wind.com
Subject: Re: [PATCH 4/5] net: ipv4: allow setting address on interface outside
 current namespace
To:     Jonas Bonn <jonas@norrbonn.se>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     davem@davemloft.net
References: <20191105081112.16656-1-jonas@norrbonn.se>
 <20191105081112.16656-5-jonas@norrbonn.se>
From:   Nicolas Dichtel <nicolas.dichtel@6wind.com>
Organization: 6WIND
Message-ID: <ae1d28b3-f62f-c58e-d478-980f47fe4fea@6wind.com>
Date:   Tue, 5 Nov 2019 16:47:44 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <20191105081112.16656-5-jonas@norrbonn.se>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le 05/11/2019 à 09:11, Jonas Bonn a écrit :
> This patch allows an interface outside of the current namespace to be
> selected when setting a new IPv4 address for a device.  This uses the
> IFA_TARGET_NETNSID attribute to select the namespace in which to search
> for the interface to act upon.
> 
> Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
> ---
[snip]
> @@ -945,10 +961,11 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
>  
>  			if (ret < 0) {
>  				inet_free_ifa(ifa);
> -				return ret;
> +				err = ret;
> +				goto out;
>  			}
>  		}
> -		return __inet_insert_ifa(ifa, nlh, NETLINK_CB(skb).portid,
> +		err = __inet_insert_ifa(ifa, nlh, NETLINK_CB(skb).portid,
>  					 extack);
if (err < 0)
	goto out;
?
else err is set to 0 later.

>  	} else {
>  		u32 new_metric = ifa->ifa_rt_priority;
> @@ -956,8 +973,10 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
>  		inet_free_ifa(ifa);
>  
>  		if (nlh->nlmsg_flags & NLM_F_EXCL ||
> -		    !(nlh->nlmsg_flags & NLM_F_REPLACE))
> -			return -EEXIST;
> +		    !(nlh->nlmsg_flags & NLM_F_REPLACE)) {
> +			err = -EEXIST;
> +			goto out;
> +		}
>  		ifa = ifa_existing;
>  
>  		if (ifa->ifa_rt_priority != new_metric) {
> @@ -971,7 +990,14 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
>  				&check_lifetime_work, 0);
>  		rtmsg_ifa(RTM_NEWADDR, ifa, nlh, NETLINK_CB(skb).portid);
>  	}
> -	return 0;
> +
> +	err = 0;
here.


Regards,
Nicolas