Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp937253ybx; Tue, 5 Nov 2019 07:50:00 -0800 (PST) X-Google-Smtp-Source: APXvYqx+Ik40dLNhwfcHBQPqbEsjMDFJNiKfA25cbMXi6UM17cHKq0Nh1YCp+eUwgdvdaJTMedIx X-Received: by 2002:aa7:dc1a:: with SMTP id b26mr36568773edu.139.1572969000733; Tue, 05 Nov 2019 07:50:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572969000; cv=none; d=google.com; s=arc-20160816; b=l6AKjXyhg8aRE6ehuTlfqvgjA5gNeZVNWezxpSzTqNtNO1PZ+dC7tHCT28rYCG8yia oAr6E/Qx818lJYjUSx6Zy5XPI41hZpAAocMpaug5VYus4d+w4/zNvVX22OWUSKwf766y 64L+pTa8T8yk82YNMgBVQ0pd0j7HvxR9MJMlDSv2+cOuddzYx8r/6OBjv1vn5pHgbOlz NZirLhijb6K9JXtp+6Ezkk0DbtEEKGpxkHr2cQXJUm2JZNeRw+VgMmcoPnMLDdyvaYdC AV/mQ4EVS00wRg/8A+GCzmwqlBjWHb1lucvLgdZNtf5uuRsaiBelFVi9RQ0KQ9a1lzvv pmbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DFt11oLLoMJgDFYS0MiPrq0J+nWr0aEDvBTZoCHPfhI=; b=a5yiR20cJgUMGZPtX9EnDJ41M12z4djMk3drUzwipqc+EsKv4LZIj4hPJwEvLY2b70 EWdBBoeXoRdgEvHH2cf6DCfqSmWHFiOGvQdUFi9FWOr3F3Zw1HDVxGU2bQKeYfMrWFRF HldhTxKvPcnKA6bg90Lg9U/tF36x1YORTJ8MDfRycbegFyRvoS7Mph9ncvBE+6NZpxon Ckp/bWmQPPGAYdqXjt1XswouHJzXyebAHMdiKTUC+1OGLxKUgtNl3VBB9jYe1c+krWCD BgeSN8nFqeVNhe1gs3dgC0OqF7nV1KkWV+1qtOQ2WMg2JTqh1UP4mlLU0X+HKhqx1UUU IeuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UR3LSp2F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si13591091eja.146.2019.11.05.07.49.36; Tue, 05 Nov 2019 07:50:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=UR3LSp2F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389966AbfKEPsA (ORCPT + 99 others); Tue, 5 Nov 2019 10:48:00 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:52230 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389571AbfKEPr7 (ORCPT ); Tue, 5 Nov 2019 10:47:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DFt11oLLoMJgDFYS0MiPrq0J+nWr0aEDvBTZoCHPfhI=; b=UR3LSp2FcVIcBHnz8MSvcstQ1 xBM3DXaklmz8A0CnRD5XWVvNfa6tt7Ao4dslaBcXRGAVy/WygA6beBC8kdI6r1OjpRzeorOEhetkt bFJaM8ZU/vZiAs7VaOHnE7388I7S6CdzIS6uRj/4mUIpeo3vhHeLzvRfLln+q6VUfYlR+ayLn1hPi CEtQ3UIWqysJ31OvlL1vh1NmxborXMTK5QJ+2W0DA+raFS9kuAGnKWxDSlyKy49cORs1rxbXw2thG ii7cjdspsx3AY/MTRptJAUSliPNp1doTS/qKPRfMPm01CYRbVlffBGg29w8dYAegqJUjcmvcQn7FZ 5RIt9/dOA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS13i-00059U-SN; Tue, 05 Nov 2019 15:47:54 +0000 Date: Tue, 5 Nov 2019 07:47:54 -0800 From: Christoph Hellwig To: Joe Perches Cc: Thomas Gleixner , Masahiro Yamada , Greg Kroah-Hartman , linux-spdx@vger.kernel.org, Linux Kernel Mailing List Subject: Re: spdxcheck.py complains about the second OR? Message-ID: <20191105154754.GA18119@infradead.org> References: <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46615f063c973eee649e3fdb8261978102c89108.camel@perches.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 04, 2019 at 02:24:23PM -0800, Joe Perches wrote: > On Mon, 2019-11-04 at 23:11 +0100, Thomas Gleixner wrote: > > On Fri, 1 Nov 2019, Masahiro Yamada wrote: > > > scripts/spdxcheck.py warns the following two files. > > > > > > $ ./scripts/spdxcheck.py > > > drivers/net/ethernet/pensando/ionic/ionic_if.h: 1:52 Syntax error: OR > > > drivers/net/ethernet/pensando/ionic/ionic_regs.h: 1:52 Syntax error: OR > > > > > > I do not understand what is wrong with them. > > > > > > I think "A OR B OR C" is sane. > > > > Yes it is, but obviously we did not expect files with 3 possible > > alternative licenses. > > Perhaps just this, but the generic logic > obviously isn't complete. Can we please print a warning in that case even if we end up parsing it correct? tripple licensing always has a bit of a bad smell.