Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1021437ybx; Tue, 5 Nov 2019 09:03:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxW/5gKWW5l3hLSrHlZqBAMyrm3K4OY/Z8SxPcjZojsamysjqpCzbxyDn3jUXhfod81eT7R X-Received: by 2002:a17:906:3ec6:: with SMTP id d6mr31076657ejj.41.1572973439719; Tue, 05 Nov 2019 09:03:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572973439; cv=none; d=google.com; s=arc-20160816; b=FBRKrxWddqJXeNPq15DvgXl92dNdsfvY6XfSWtrrpCorox8QFsbKiRcl7HSPu8LiKO FTClE8cD5K3A8hFtUPLSdMUUfDSgt0grpGziNx65O6rmAyvwGmHVRPGHH1IjazODSAfV wBtzg/5w1AKIos3kkS72WY2aAihvskN5SCE0+vUs8DBoUt5ZhAG4+Q0pOx4QCuuz7yf6 Vx6UJkn+9f9YkZ12uyStwcwsTkqS9jw5+N7Slz8VIZNhZ8XWjt1EBfSCBloRq0gLym/H fFa+WiEbM/R83iGxiM9PYHM+4wxJkdLgplwJDithoRwK4m+KhMTaRJMySl2JjoDHQy+h D/Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject; bh=53B/ZvOSZLOwww7DyBx8j6HGea1fqAatCEbntgSANNE=; b=NBUMniRd4UeG6ApM0OW4FLxt/vaCxtZSvufhLsnF2Mg/sywj6aG6q8KOvcboCZi1Lv VIja/3Yr3Brr6tUgQJnmpm929DNehz4uDscW8A6M5eh0py2YUYAnjcgCrnpRMUHdibVi 4c5n790cSVia1cfXesYVfFuzHIJpq3qmbn6ULqnDfb9LvomwZdxi9gh++IZHfUc+MZNr mmK+ILYr3052jjUhsr0ZLz0sKZp0l7i+Y2mzE/XY6si+wwT/dP0raePybapFBeuullDY 8dvu18gtITNCm5HClo43Q3FTWcLceTGhAHbIw8t6k1cLEp3KQQwMnH/khgBtGx4i3pJk gpCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r18si2971927edw.65.2019.11.05.09.03.35; Tue, 05 Nov 2019 09:03:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389668AbfKERBX (ORCPT + 99 others); Tue, 5 Nov 2019 12:01:23 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:63328 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388488AbfKERBW (ORCPT ); Tue, 5 Nov 2019 12:01:22 -0500 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id xA5GwgPf049840 for ; Tue, 5 Nov 2019 12:01:21 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w3afaew6y-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 05 Nov 2019 12:01:20 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Nov 2019 17:01:15 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 5 Nov 2019 17:01:12 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xA5H0b2a15139156 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 5 Nov 2019 17:00:37 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4E2D11C04C; Tue, 5 Nov 2019 17:01:11 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 390C011C054; Tue, 5 Nov 2019 17:01:10 +0000 (GMT) Received: from [9.199.51.136] (unknown [9.199.51.136]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 5 Nov 2019 17:01:09 +0000 (GMT) Subject: Re: [PATCH v2 3/4] Documentation/ABI: mark /sys/kernel/fadump_* sysfs files deprecated To: Sourabh Jain , mpe@ellerman.id.au Cc: corbet@lwn.net, mahesh@linux.vnet.ibm.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org References: <20191018130557.2217-1-sourabhjain@linux.ibm.com> <20191018130557.2217-4-sourabhjain@linux.ibm.com> From: Hari Bathini Date: Tue, 5 Nov 2019 22:31:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19110517-0012-0000-0000-00000360F5A5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19110517-0013-0000-0000-0000219C4FB8 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-11-05_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050140 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/19 2:24 PM, Sourabh Jain wrote: > > > On 10/21/19 1:11 PM, Hari Bathini wrote: >> >> >> On 18/10/19 6:35 PM, Sourabh Jain wrote: >>> The /sys/kernel/fadump_* sysfs files are replicated under >> >> [...] >> >>> +Note: The following FADump sysfs files are deprecated. >>> + >>> + Deprecated Alternative >>> + ------------------------------------------------------------------------------- >>> + /sys/kernel/fadump_enabled /sys/kernel/fadump/fadump_enabled >>> + /sys/kernel/fadump_registered /sys/kernel/fadump/fadump_registered >>> + /sys/kernel/fadump_release_mem /sys/kernel/fadump/fadump_release_mem >> >> /sys/kernel/fadump/* looks tidy instead of /sys/kernel/fadump/fadump_* >> I mean, /sys/kernel/fadump/fadump_enabled => /sys/kernel/fadump/enabled and such.. > > > > Could you please confirm whether you want to address the sysfs file path differently or > actually changing the sysfs file name from fadump_enabled to enabled. I meant, given the path "/sys/kernel/fadump/", the prefix fadump_ is redundant. If there are no conventions that we should retain the same file name, I suggest to drop the fadump_ prefix and just call them enabled, registered, etc.. - Hari