Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1023476ybx; Tue, 5 Nov 2019 09:05:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxporqEmGqrbHp2jNIP3aASe4x15xtWHPFnBBX8gCu8If4TftN9seFxyJWK0XGFLX4Hhy6r X-Received: by 2002:a7b:c4c7:: with SMTP id g7mr10199wmk.144.1572973534864; Tue, 05 Nov 2019 09:05:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572973534; cv=none; d=google.com; s=arc-20160816; b=pzl2aHgVjr3B42U4rg8+2qR5tj0aKSJri3MCwYSwP6k9VNhn/uUMe8f9DbQRqg7rdo hKv/Z0MS4Nd6lkuTC2wSwRjH2aOFEIG8lYnloIuAeJ0Mllz5OdOXg+f5ANIHaWifFd/p 25mCEJnNR0YDaCXVBOqP30ZZTtuac9uXA6nJoVSAdVElNPnTVhlbNdIxTxL3PITpwDND kN4pYdx/9NbG4/eIbILvQyr0P7fJY7n/yiIv0qBh84RVc8rdOiAJ5C6HCI1vIdox0plF S4UfNHiRsV0gzBQKyEjoszAR5snfE9K+lpL6IRVMpFUdGLtrGiHI/ThyE3NbTVupynNr w04w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=y64SjsIfQ/9yIi9jLut9emU3CIqXKBLjebItaPR8MI4=; b=JFVHmR4vrpQGkbvZUkrOEkaoeoV3KXIoc2wpF5IUnlpQ7kPMnv/MjXVbONFLxuoFe/ bplaGHMNm2lW+bfct1XBL7zv/y0tuKj/OdEGZ2J4tWWz7ay0RGret1NsejJW1Lj2SCxE H5OctL7lZjcLjTyufKoGL7Esqzu3kwzsogJTSAJVPTb9nwyaKq1FNua7zB+QokV6CHjo EY3Lj+2wC5C+uq+men5wGMfyxXvnFh/OQc/SAssh+RaiXpxtJ+aFIBafcshlBGWZJchO A5jC9wrAk+x6noJxhiAyANh3nJy2ya9djeqFoj6vEaUtH6EvgfrJkjCkyaMXuOXMEepq LlxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b03Ga5kL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g90si10861462edd.329.2019.11.05.09.05.10; Tue, 05 Nov 2019 09:05:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b03Ga5kL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389167AbfKERET (ORCPT + 99 others); Tue, 5 Nov 2019 12:04:19 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36206 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387776AbfKERES (ORCPT ); Tue, 5 Nov 2019 12:04:18 -0500 Received: by mail-ed1-f68.google.com with SMTP id f7so13669471edq.3; Tue, 05 Nov 2019 09:04:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y64SjsIfQ/9yIi9jLut9emU3CIqXKBLjebItaPR8MI4=; b=b03Ga5kLo8H6LwyRbdEm6JlWBhwvfkcloWhPBLvcL83ZRdFe/DPnCIWTbWuGBHCKIy CwQAEXofncC90t51q3mgYYkIoKAygpgBhZ3In2PD0ZGbVvJinE2OFATIawoeqFq2k5hX w+5tJBJhN88yvx/aTn8btb9HrMUjwnqIn2ZwGNgS5ykAd3QvbHpkO2yXpvJrMF2pmdcg IY2TMyo4gT8gHrnecO2ioWMfNpc96zFQmIsQveS1tW9iNumqtitbmoBYX6HKtWlBr9u3 lLIlY/oltilH4HNUQCYJN0GUpdCiGd7kQZg602vEl3J+pZUJTRGoVA5qKUkFTRncOrl2 Pxww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=y64SjsIfQ/9yIi9jLut9emU3CIqXKBLjebItaPR8MI4=; b=Kyw+UAUmzeIKnWLVgSly/2P7Bb8P7mafWn6VHaR011IWAGRZ8AwSXyzyh0vtoRNL24 GzP7M099U0/dEuyMEgj+UiqhFzxLjVeNJ6y095sEt4R0S2WQtgPI6BPHnkkf4x/yZlJB SUVa/QNSUimzKF9lvSBLec+0PjOoM+T051YnrkiQ0wnyOTccwMHm1tL7pzHOLwrcT+mD COad/cXv4d3vZQTnEho5rhQ7NrwZBn3r94fpz3UOS+aaG7aWqK3vZSl90cBtOvagZGfe HsnNMP+8UpWOkGXl+hn1wEXYvBK+Nmkmwmh2hpGQsuUrFuA5G+K1W2UNJuf/fZisGKp4 BHuQ== X-Gm-Message-State: APjAAAWkc960QsdfUZx1XgT5d6IhfXhEsQyR7DtcOqzVeAgf1QsDRyW6 GHEmEgOo5C/+mRtWNcqD35oB3uV8 X-Received: by 2002:a17:906:80d1:: with SMTP id a17mr29236480ejx.77.1572973455848; Tue, 05 Nov 2019 09:04:15 -0800 (PST) Received: from [10.67.50.53] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id x6sm1071484edc.50.2019.11.05.09.04.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2019 09:04:15 -0800 (PST) Subject: Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare To: Chuhong Yuan Cc: Alessandro Zummo , Alexandre Belloni , bcm-kernel-feedback-list@broadcom.com, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191105160043.20018-1-hslester96@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <34008ef4-9078-fb6d-048b-2060fb16f418@gmail.com> Date: Tue, 5 Nov 2019 09:04:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191105160043.20018-1-hslester96@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/19 8:00 AM, Chuhong Yuan wrote: > This driver forgets to disable and unprepare clock when remove. > Add a call to clk_disable_unprepare to fix it. > > Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer") > Signed-off-by: Chuhong Yuan Acked-by: Florian Fainelli -- Florian