Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1316515ybx; Tue, 5 Nov 2019 14:07:14 -0800 (PST) X-Google-Smtp-Source: APXvYqx0Rk5vfQddBdQa6/J0v/jxx28CpBSKVTot28WqrCeSDxerlS/23QeWET3+m9xQbAOCFsZS X-Received: by 2002:a05:6402:1452:: with SMTP id d18mr38905571edx.158.1572991634597; Tue, 05 Nov 2019 14:07:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1572991634; cv=none; d=google.com; s=arc-20160816; b=shchVc9dxMXkJ/hL5KZIWaXTi4sb7KdAXd7t4TYugCHJ+JC9R7rqIQUQYuWQQp+gmL SV4LpWk3GOSZKMqYkHPdqOo2tMYK76JkifBBCOJDAl6JRwQ3Io8zkCAzk7GFSOKLsIss 9HuqXN0NcRKRY+8nM6hxjBmodBXCOaEQsQUrlG0ugPwVo749lQbFFs62OY2WotXskIpA B8s7JfknhDqc1OxvlIh8eurAO/Zs/N1Kt9RG7VDRgKQwEFAUYZkYEtHYYIm2IZyUy5WC zlw8zThYr8iJu/6KunW8iYKWqhP5MCefPxiqu2CKuFoTX+uW9BJoXntJyExoGmm1kd7Z bDQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=0huU5fCOUbpLDpHRiqK1oQAXy1/4rrj9EuHr7zStDzA=; b=ZMbAFK3dWGFgimWCREMbw5iV1YFgWl/lHQOI/T/lDiXoplkXVZR+YiK240lRUczUOl DxfziZoAb6NBi4SifOG2dSZMAsUqqXJ6H5MpqvY+1F8fsGd/zswjSk9a8ns/IDRQG0ln TiqzmWsd+oacDO1KDBEkkpCS2QcY2+xEXT1RKc6QLWojLxzAGNU7ZkBoik+E5YWiz5PS 8YLOJKcPqAW4HAonCthU/hoMrf/I4SbKd35BhSh23OzCKbe7j3dwI6Qt650mRjswuraI Qgu6qCYeItVpxN5xmlLTgZ6sE3a//YnC7BvrU2QoC54GZyrRUeYOD45CNKNuCoLAOGJq 3qYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2si12333860eda.322.2019.11.05.14.06.51; Tue, 05 Nov 2019 14:07:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730369AbfKEWDZ (ORCPT + 99 others); Tue, 5 Nov 2019 17:03:25 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:39314 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729830AbfKEWDY (ORCPT ); Tue, 5 Nov 2019 17:03:24 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 04641150689E4; Tue, 5 Nov 2019 14:03:23 -0800 (PST) Date: Tue, 05 Nov 2019 14:03:23 -0800 (PST) Message-Id: <20191105.140323.1324058477518607844.davem@davemloft.net> To: mcroce@redhat.com Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/2] icmp: move duplicate code in helper functions From: David Miller In-Reply-To: <20191102001204.83883-1-mcroce@redhat.com> References: <20191102001204.83883-1-mcroce@redhat.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Nov 2019 14:03:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matteo Croce Date: Sat, 2 Nov 2019 01:12:02 +0100 > Remove some duplicate code by moving it in two helper functions. > First patch adds the helpers, the second one uses it. Series applied.