Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp1518038ybx;
        Tue, 5 Nov 2019 17:56:54 -0800 (PST)
X-Google-Smtp-Source: APXvYqzi4M86TSHlUAZTJjmOIi+SeQ8cI66ekbrt4E8okQoDeDJnBiIrgGx/iztALN/mGkhqaKLE
X-Received: by 2002:a17:906:af62:: with SMTP id os2mr25460890ejb.105.1573005414587;
        Tue, 05 Nov 2019 17:56:54 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1573005414; cv=none;
        d=google.com; s=arc-20160816;
        b=Et7qDBLOmiHNu/X5xbNbgRshNC+IVnkCphB9cqPClqWg4EKJOy9CaRqRbKVp5NQme+
         O8IhTK2eu6YQm6JL+If325FR3kMc60ou1GnfYSZahz1Zbvn3Bsow1702QHJGsazxnAAp
         /ki3WxZCWX1dZJqhqMbSTic7jeYSuEpnl8XfbTeTIiDF+saLQ6nnhzpxqGl08u5VHdPg
         nYovB1c22tmR5rb8ulj61sOwSda6T64aRY/uHvJnEI1Ya2EPZYn5qFu14HettIcoEOxQ
         sxxfRDkcJ63t78347bF4ODSAxe/des/24Dz0PxXRXGBAAowl3YSo1GY1DFbF5VMP3DZ6
         Suwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=9UAI6J30tTZXiotkD20gcxxpcrmMieJ2MFTXnlhy63I=;
        b=LfWxbRnWjzPfi3Wo+KWNq6DqyR3mGM5TdN1U349bTWGzC7vz68B/FyhGa/GCEqzU5p
         aGYcPLWWoYiExyNFFRJQao0/d1ffvo7cJTloV8bH4EO05FyOvivdf3QjK21qj4m6PPof
         90PoOB6kU/nWtHc1tMVLxFs6Jqxsg3JHVNkLGStrZLGNBjDnOL3HyVn1JivYWaR6363a
         wKGg9gsWNu7wJwNxfequcjrGfpXpDV3sSWUdUUob8aZ9GK7JSCr+SIujFg5fTMMmwKsb
         6ZJURY1hsiUPYJKdVPthAgnJsYcdUOW1QHrsNg+sTYTKLku4gA/SP/BUzIzq818wSM4A
         cfQw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t18si4061778eds.247.2019.11.05.17.56.31;
        Tue, 05 Nov 2019 17:56:54 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730862AbfKFBzS (ORCPT <rfc822;saikripd@gmail.com> + 99 others);
        Tue, 5 Nov 2019 20:55:18 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:41858 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727252AbfKFBzR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Nov 2019 20:55:17 -0500
Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 5D3E4150FEF46;
        Tue,  5 Nov 2019 17:55:17 -0800 (PST)
Date:   Tue, 05 Nov 2019 17:55:16 -0800 (PST)
Message-Id: <20191105.175516.1095237130960059082.davem@davemloft.net>
To:     f.fainelli@gmail.com
Cc:     netdev@vger.kernel.org, rmk+kernel@armlinux.org.uk,
        hkallweit1@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix driver removal
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191103031739.27157-1-f.fainelli@gmail.com>
References: <20191103031739.27157-1-f.fainelli@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 05 Nov 2019 17:55:17 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sat,  2 Nov 2019 20:17:39 -0700

> With the DSA core doing the call to dsa_port_disable() we do not need to
> do that within the driver itself. This could cause an use after free
> since past dsa_unregister_switch() we should not be accessing any
> dsa_switch internal structures.
> 
> Fixes: 0394a63acfe2 ("net: dsa: enable and disable all ports")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.