Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp73034ybx; Tue, 5 Nov 2019 19:47:25 -0800 (PST) X-Google-Smtp-Source: APXvYqy0CsIYyjsunqOITxLWwZ189hv/ZKKIneGlpuKtu9ul6+N43Q4i9+OPS7GBtMA9c7CGcY2C X-Received: by 2002:a50:a7c5:: with SMTP id i63mr339111edc.79.1573012045313; Tue, 05 Nov 2019 19:47:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573012045; cv=none; d=google.com; s=arc-20160816; b=YW9CXZpn9bQLJmLPWWNqtVqYzszoULCsZXfhaYSx+kYHkzeC7I7id00hZA3K9+wXGW FSGK5NBZgA6x2D3Bsev6xiHt3v5KWerQlrs8bwxtgads9Ju3JUOrXk7Mo3z+UUelLVaT 4rxFjmErhupEaswqa5ULcKxvABfzCx0pAjg1kLOiQbEEMfar7DkYBLzkEXiTM/11j9nG zhuZSjFQLfiRnVh74vLRC2lapZuL03zK2rOfkPMrx2KKcvHSfLPjR7lNcGPkp4uMx9oy OlqSO6DKJWXE+zAPaE/aIl3ZGShy5SJSxi/Obrgh/wAh0nBiEo1FDh76g6jvRegVV/mp 5L7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=frL9/aCXhfxisGdXkirBm3DhOU4DdFp7w4JgKbYTA2o=; b=UH2dBhgJ9Bjnmwmt+j8aeS9xD7sFBbCB8reTJnKiF8ghUoB6EALNQoo5Y2hmvMYxED RfEDU63rBtZum22CW09I1Xfm9V9lq7SVciCfa8k1wMs0xw+G0r6FO7C1WWOmICDFCI08 ZeQB6tV5MLhB1LOzQbZ9ZcCmVs4yDqOLhU9z80bNQcFL29mQb9uoN4Pj/wtt6J1yKntM oFirHnQd562NzyRVcPs1yhf7JPNqeEPFo5NJODHL6BRPMnIDk6sBAu73IfPMm3QYjKrB Sgt2Fa8/ccKLPMLBMbUPxPqH6LIxkfvQuff+21ZkQqbTMG7304Md9zUgE+wAUXrhjcGt AY/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CvBHwinX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e12si2943396ejr.39.2019.11.05.19.47.01; Tue, 05 Nov 2019 19:47:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CvBHwinX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731185AbfKFDpg (ORCPT + 99 others); Tue, 5 Nov 2019 22:45:36 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40611 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfKFDpf (ORCPT ); Tue, 5 Nov 2019 22:45:35 -0500 Received: by mail-pf1-f194.google.com with SMTP id r4so17777541pfl.7; Tue, 05 Nov 2019 19:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=frL9/aCXhfxisGdXkirBm3DhOU4DdFp7w4JgKbYTA2o=; b=CvBHwinXHu/bfua35zHx2bcBsBIlL0q2uRL/t1Ql5Hl+K2nUs6bo3oebrYcgJ+oN/3 SstoRYoLeGTSo6hxnIP12CcYB2wpEbPyU5Qz8dT3IKP6/iKePNyYfo/Xnc44ZUY0JoBV ZBzBvwAO9G/C4+IcYBDY+N9CYUL9/dvbYEyw+XlR/qZ7gUpILyFKrmFjWBctXQUMUTmX yjzkGkv5fAPlVwtSIvWh22zKfqImmVklCeXZlvLQut2BLhPdlH0J9uAMWguzwAwiRw2X +D35n/Tm+9fkHqzAznhwnIAsZ1fgmr4yTJ246/me975stU08xNIjX39XYp0Ykat47od6 ciCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=frL9/aCXhfxisGdXkirBm3DhOU4DdFp7w4JgKbYTA2o=; b=hykmqFs6JfYZ7PRWjg+PY/Lmbmr50Cp0BF6tcx5RPG3tEdetHpA+8rXhYa3FiEZUfp 5l5PXRFfdHvxJq0o+M/CR9MIpP0dslKwdWrUMCDohIgqxYNXFKcbPZKqtHXWaIdPxh33 TaTcASIBxEJKzZGpc7O5gio1bYfCEL7Aj5SQDOMCe3DGP8rnqBDqvhstA0VRG6vgBzd4 +p+lT4wX03jS+1U81mv+8i6R6m0OLBDJKYHWS25JXQ51r/+9vdZFDQlNWjw/vWtlEyYm FsmAjU6+/kC5/dLCVhlKHbYpvHAMy0EtFzPrLh9yEIjT1BhIYPrPFX/S4Zb0wTA1Qpel 9JXw== X-Gm-Message-State: APjAAAX8X+bv/io95i63U9WebLLbEJphm1R65FQ66SqQZvdt+cYa5GJX thF53ma041fG4o5dI/klcuFwTFqt X-Received: by 2002:a63:1d60:: with SMTP id d32mr350197pgm.37.1573011934753; Tue, 05 Nov 2019 19:45:34 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id x192sm19984006pfc.109.2019.11.05.19.45.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Nov 2019 19:45:34 -0800 (PST) Subject: Re: [PATCH net 3/3] net: bcmgenet: reapply manual settings to the PHY To: Doug Berger , "David S. Miller" Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1572980846-37707-1-git-send-email-opendmb@gmail.com> <1572980846-37707-4-git-send-email-opendmb@gmail.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: <990bd954-5928-f9b8-55d5-c45c3fc8b976@gmail.com> Date: Tue, 5 Nov 2019 19:45:33 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <1572980846-37707-4-git-send-email-opendmb@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2019 11:07 AM, Doug Berger wrote: > The phy_init_hw() function may reset the PHY to a configuration > that does not match manual network settings stored in the phydev > structure. If the phy state machine is polled rather than event > driven this can create a timing hazard where the phy state machine > might alter the settings stored in the phydev structure from the > value read from the BMCR. > > This commit follows invocations of phy_init_hw() by the bcmgenet > driver with invocations of the genphy_config_aneg() function to > ensure that the BMCR is written to match the settings held in the > phydev structure. This prevents the risk of manual settings being > accidentally altered. > > Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") > Signed-off-by: Doug Berger Acked-by: Florian Fainelli -- Florian