Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp73161ybx; Tue, 5 Nov 2019 19:47:34 -0800 (PST) X-Google-Smtp-Source: APXvYqwO2l9oB9/FmZ8DWK2/NuGjZtYVwsGOpBsVS2LP1KbypMulHxdslMbrL8FlKRlcTlA9b9iR X-Received: by 2002:a50:fa83:: with SMTP id w3mr355759edr.272.1573012054809; Tue, 05 Nov 2019 19:47:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573012054; cv=none; d=google.com; s=arc-20160816; b=PUVkOUkMyow7R+MD7Zx9g7Km8S5cnyFB3bnJSwN91wgaEI0416XasPHav4tycdruEv 3k2/s/sR3bD45607BINlEi+KGcQ9DaXDCBdVtrmT5cufVaVjU4HJAwUEQX9zqFAJthcG NFKM4kfdVOuy9mkaLhyrp2/aWAeXdoocVVgpSc/s9udp2vZe/7lR9n+QEJz49IwZquk9 voIXNmjhJ9FrgScv5GXGaIXCPaMlzoDX4zI0mmxy19Wwl9PlPX/oaWrLxolM4EyidzoQ aiqU+ZngfB88MEm/5yl1lz7f5cKAig7lOcS64GCL3NHsuWdkhUNbBmgnyerbQjF2CBA6 Igmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from; bh=B+aH+MLz1BYME+pJs+ab+WUmohrfGSaq0/1uqMxTleo=; b=jtrzUQCX5TBf8zdb9CfIij4McqKVDKAwiVeCk1OjIcax83T5ZgQ5AweabzG9IUoGfP 69QvNJgwOqz5kC0TtmemTgLL38tdrtIaQwgXMKcfo+GgQu2wxZAhYvcR1bYLL6f8/Ouz 8xIDEgFCITGqP2Tg7l7WRLP45SS5ZcrcoBT5q6fa7/ZHc5gwvBPeBgjHP3yxUdR6i/1k 6sGyjdScLwGxohiMcdvOOLoEGNe6fRGApfkILNEEFnaRdBNG6SPHEVixzDbpSkc7Pp+o pZDlUjRKHluQofy91qYTfqxZCx/WcUZ7BvBvqa1zFYA2DC38u26emwO/NZD6l6sywAUl MQrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7si9064738ejf.155.2019.11.05.19.47.11; Tue, 05 Nov 2019 19:47:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731133AbfKFDod (ORCPT + 99 others); Tue, 5 Nov 2019 22:44:33 -0500 Received: from mga11.intel.com ([192.55.52.93]:41250 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbfKFDob (ORCPT ); Tue, 5 Nov 2019 22:44:31 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 19:44:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,272,1569308400"; d="scan'208";a="212679198" Received: from sgsxdev004.isng.intel.com (HELO localhost) ([10.226.88.13]) by fmsmga001.fm.intel.com with ESMTP; 05 Nov 2019 19:44:27 -0800 From: Dilip Kota To: gustavo.pimentel@synopsys.com, lorenzo.pieralisi@arm.com, andrew.murray@arm.com, helgaas@kernel.org, jingoohan1@gmail.com, robh@kernel.org, martin.blumenstingl@googlemail.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@intel.com, cheol.yong.kim@intel.com, chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com, Dilip Kota Subject: [PATCH v5 3/3] PCI: artpec6: Configure FTS with dwc helper function Date: Wed, 6 Nov 2019 11:44:03 +0800 Message-Id: <90a64d72a32dbc75c03a58a1813f50e547170ff4.1572950559.git.eswara.kota@linux.intel.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Utilize DesugnWare helper functions to configure Fast Training Sequence. Drop the respective code in the driver. Signed-off-by: Dilip Kota --- drivers/pci/controller/dwc/pcie-artpec6.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/controller/dwc/pcie-artpec6.c index d00252bd8fae..02d93b8c7942 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -51,9 +51,6 @@ static const struct of_device_id artpec6_pcie_of_match[]; #define ACK_N_FTS_MASK GENMASK(15, 8) #define ACK_N_FTS(x) (((x) << 8) & ACK_N_FTS_MASK) -#define FAST_TRAINING_SEQ_MASK GENMASK(7, 0) -#define FAST_TRAINING_SEQ(x) (((x) << 0) & FAST_TRAINING_SEQ_MASK) - /* ARTPEC-6 specific registers */ #define PCIECFG 0x18 #define PCIECFG_DBG_OEN BIT(24) @@ -313,10 +310,7 @@ static void artpec6_pcie_set_nfts(struct artpec6_pcie *artpec6_pcie) * Set the Number of Fast Training Sequences that the core * advertises as its N_FTS during Gen2 or Gen3 link training. */ - val = dw_pcie_readl_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL); - val &= ~FAST_TRAINING_SEQ_MASK; - val |= FAST_TRAINING_SEQ(180); - dw_pcie_writel_dbi(pci, PCIE_LINK_WIDTH_SPEED_CONTROL, val); + dw_pcie_link_set_n_fts(pci, 180); } static void artpec6_pcie_assert_core_reset(struct artpec6_pcie *artpec6_pcie) -- 2.11.0