Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp269589ybx; Tue, 5 Nov 2019 23:47:58 -0800 (PST) X-Google-Smtp-Source: APXvYqwgjVpbRuRPacjRTA0EX5iVSuthhy3SyuZxJIjfMrcgkStWbxRY+sYpmT1CzXvWHSvSU6g/ X-Received: by 2002:a50:ac3c:: with SMTP id v57mr1118735edc.300.1573026478133; Tue, 05 Nov 2019 23:47:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573026478; cv=none; d=google.com; s=arc-20160816; b=ZBohs6/CiDg/Xm4GyoDo31CLY4MAfAs6poKuaLoIOK25KMDfpigP//eP8LYgg+zXOn 4NmArCqv0zjXUMH52tjaLSw2GJ1jwImxjI2+wdp9kxORWeruFsDMt3cy8TyxzIFkBf6u H3KO5QX2XyEREKPzOhfiQNInEt6imlFAX8KND+xpx81hNocUl/sYSY4O+F3HsKFyJKdb HiSGzWY7b+q5QeBjhZ/hl+SibTkrn41v1RMGKbgQbnsxnW/NUuCmZKXg+LeWloRswsML Px5yUOkZ+4gACgY4COE6wwmKAGic2D8i7EKrvH2lNJakxraixsY2LlfXJsJEDUuTYVYe 3Ecw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=GQiDbpJ2lWoQjxogiLC76wvVDvALWHHs4GpRXuiccOI=; b=gKSLcXQry9qYnXJGyZaFaJ2Qbffsgwr3WrWp/oYqN4/EczECM8S0Ue0eXp0Tn1blhk cJa5252E8WX3pRw5KswUryF3vSGDKpqniwvBxR/WAQ0LPcVBrDLt15GgHT0vkkG85Ccu AnKa92MjAXWn7zhF0i3CAT0yuQkdc/+2IZ10Kb5Es2Yb6/M4w/E+eNUByGsxSKusfEz1 guzLqXU9uAHZn6/EoDGRYkH+iHv07Zsekp4JFNJ5CajceXHnmvgI+nympENm/Fd4IpCd nWtEbPBO7NeCk6nAfqcH8NcKEVgcqYuE+ymSjBTy78cRhOSekWAqf5zR9qY6o5gCQd/A BMew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=WAw9vU4J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n4si3461690ejy.426.2019.11.05.23.47.34; Tue, 05 Nov 2019 23:47:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=WAw9vU4J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731562AbfKFHoh (ORCPT + 99 others); Wed, 6 Nov 2019 02:44:37 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39950 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731553AbfKFHoh (ORCPT ); Wed, 6 Nov 2019 02:44:37 -0500 Received: by mail-lj1-f193.google.com with SMTP id q2so18352987ljg.7 for ; Tue, 05 Nov 2019 23:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GQiDbpJ2lWoQjxogiLC76wvVDvALWHHs4GpRXuiccOI=; b=WAw9vU4JDVSEM4/tX3dXF8lllf4N+YzqBd5KUQ8snC5w5eDIIZ+umT4kLbyVnFM++0 ZB8hLVMoITJnSq1rOsxgeKtkROl/uFH9ESV8xVpi8yb698FGYQmgutU67Wm0q//x2Bsj SZ/Bk5cn1mPajr330aCYxLLHJQpMBwRD7lKS4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GQiDbpJ2lWoQjxogiLC76wvVDvALWHHs4GpRXuiccOI=; b=gGbgq83uBcvYw8mhVfOzd2HgI90WxYZDE5QU5Mg96JtVkgvexpA5gUu0jY16YX3GPJ 6obA8IGvV9SuvooGOrOUEUf5X73uCI/Qd0pzTrdU0bszwhmChMGAasiY9tPlzQarxq+C ws7v8r+F3dLcRz37GkkbPexu2zRkI+qTW0LvRZx3AuFIg8Cp0kBssOWrcj8tFiOWug8E vcFL8Mn7sKeo32aJyRLI3Ga/N7Ow1q7AOw/jGuNtxw/rMAsQ1IFxCX01Xa49IIQQQLtH xuAI6g7+tyfpx3VnhFgHxyt2NESeNzPoidbTmrpxHpCWLWCbBzgIe/ihuKKdZUzw21Dv rQQQ== X-Gm-Message-State: APjAAAXdhk0wrSuToSwuVxmdLYo85bv59MrVu1KJfGh5ZWw+RWckL+pX wiQ8jaG3odmE7NOyuDq26bNsjA== X-Received: by 2002:a2e:6a19:: with SMTP id f25mr798316ljc.147.1573026274938; Tue, 05 Nov 2019 23:44:34 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id t16sm8449870ljc.106.2019.11.05.23.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2019 23:44:34 -0800 (PST) Subject: Re: [PATCH] watchdog: make nowayout sysfs file writable To: kbuild test robot , Rasmus Villemoes Cc: kbuild-all@lists.01.org, Wim Van Sebroeck , Guenter Roeck , linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org References: <20191105123125.25985-1-linux@rasmusvillemoes.dk> <201911060551.VIFgN8pe%lkp@intel.com> From: Rasmus Villemoes Message-ID: Date: Wed, 6 Nov 2019 08:44:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <201911060551.VIFgN8pe%lkp@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2019 22.16, kbuild test robot wrote: > In file included from include/linux/mutex.h:14:0, > from include/linux/kernfs.h:12, > from include/linux/sysfs.h:16, > from include/linux/kobject.h:20, > from include/linux/cdev.h:5, > from drivers/watchdog/watchdog_dev.c:31: > drivers/watchdog/watchdog_dev.c: In function 'nowayout_store': >>> arch/ia64/include/asm/current.h:16:19: error: expected identifier or '(' before 'struct' > #define current ((struct task_struct *) ia64_getreg(_IA64_REG_TP)) > ^ > drivers/watchdog/watchdog_dev.c:460:22: note: in expansion of macro 'current' > unsigned int value, current; > ^~~~~~~ :facecpalm: And it happened to work just fine in my test because I was targeting ppc32 where unlike most other arches, current is not a macro but a (more-or-less) ordinary global declaration register struct task_struct *current asm ("r2"); Oh well, already fixed in v2 which dropped current for other reasons. Rasmus