Received: by 2002:a25:31c3:0:0:0:0:0 with SMTP id x186csp759145ybx; Wed, 6 Nov 2019 08:02:55 -0800 (PST) X-Google-Smtp-Source: APXvYqybE3PtAUwg54wd+vkgFVQnAknoua5bS+hWvdoFJFhEHlyU29CeF/R1YcQ3bBlVyin2zb96 X-Received: by 2002:a50:8c02:: with SMTP id p2mr3537578edp.30.1573056174993; Wed, 06 Nov 2019 08:02:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573056174; cv=none; d=google.com; s=arc-20160816; b=n5RIPJaMdDY2ksvdx9FKb2g8qH4GXwTOawVxemxdQMAFtuYBVbvQQshc0FZivuyE9w ZS0iTFH/iDY4NeRlpum8+LphImtUcrcAcbtB8ddHulcSkyE4/iJh1iOnQ3EWlEUft5Nw b6Lf78XvdcjgtqsL6hfSfI2/bb6plBqS+Et2LHtLlWXce45cGPKLdXyGJ93kw1Vsrqrx /uCzBVarhZBR+z+eb0SW4vfIl/caaTb1xzi3s191q3CE5HVE8xqjkW3qwQm5rRLjGPuN Yo97zUIyQXf4sstVadTV0Mjw9KlnDmVOQhI4w26Q2CcfmUyAQLW1CgnW1n3BBJetAZVS +Bcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4cAWngu1ScTtQyuXzSX9H/2ioWBwp2LksdT6RIA3nmU=; b=aos0KDx/d4MyYeOn5jJlSY2tECU4wvAhRa2qWv0jfTO4C0MO+n+IgQC2oQho3alK43 GO+oe9Xdf0mI9RdCLe2JLtZEQsvRQFGgpGm7tlWGZcjipLIkchi4DeaZYHZyYS4GCbt/ 6a/NXaItgI+AvWyzds1GNOAijQvy6+fNi9XodmF2r2ULE5CTYaG70FQ3n+alUUNddxjl ZMCVa58vm1KV/HIJn6jRHldIP5sQ5/60cNu9rsipZE8JydC2uT7+gLIRLM3ddr4CGxI/ Wl0FaLfkEEmrNsw66frPjkjRIK4JJRt0+tL4CQgXOvvgQJDk2PQPp2icpbtBUnO7LbaY LV7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ks15si6693425ejb.133.2019.11.06.08.02.29; Wed, 06 Nov 2019 08:02:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732193AbfKFQAj (ORCPT + 99 others); Wed, 6 Nov 2019 11:00:39 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:57102 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727192AbfKFQAj (ORCPT ); Wed, 6 Nov 2019 11:00:39 -0500 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iSNjY-0003JQ-Ax; Wed, 06 Nov 2019 16:00:36 +0000 Date: Wed, 6 Nov 2019 17:00:35 +0100 From: Christian Brauner To: Adrian Reber Cc: Shuah Khan , Eugene Syromiatnikov , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: add tests for clone3() Message-ID: <20191106160034.73wla62ndojfz4rq@wittgenstein> References: <20191104131846.1076814-1-areber@redhat.com> <20191106155914.hzolyolz2w4hcn7w@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191106155914.hzolyolz2w4hcn7w@wittgenstein> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 04:59:14PM +0100, Christian Brauner wrote: > On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote: > > This adds tests for clone3() with different values and sizes > > of struct clone_args. > > > > This selftest was initially part of of the clone3() with PID selftest. > > After that patch was almost merged Eugene sent out a couple of patches > > to fix problems with these test. > > > > This commit now only contains the clone3() selftest after the LPC > > decision to rework clone3() with PID to allow setting the PID in > > multiple PID namespaces including all of Eugene's patches. > > > > Signed-off-by: Eugene Syromiatnikov > > Signed-off-by: Adrian Reber > > Resending, since mutt messed-up the quoting due to a new configuration I > was testing. > > A few more comments below. > > Also, would you be open to adding tests here for the newly added .stack > and .stack_size API (cf. [1])? Actually, forget that part for now. We can do this later in a separate patchset. Christian