Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191106142308.10511-1-aford173@gmail.com> <20191106161815.uwcoe7spn3seupaq@pengutronix.de>
In-Reply-To: <20191106161815.uwcoe7spn3seupaq@pengutronix.de>
From:   Adam Ford <aford173@gmail.com>
Date:   Wed, 6 Nov 2019 10:21:52 -0600
Message-ID: <CAHCN7xLRJ8y7039iiCbrm5ZxgXyEdKtubYNNr8TcSBDHDNEENg@mail.gmail.com>
Subject: Re: [PATCH V2] ARM: dts: imx6q-logicpd: Enable ili2117a Touchscreen
To:     Marco Felsch <m.felsch@pengutronix.de>
Cc:     arm-soc <linux-arm-kernel@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        devicetree <devicetree@vger.kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Nov 6, 2019 at 10:18 AM Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> Hi Adam,
>
> On 19-11-06 08:23, Adam Ford wrote:
> > The LCD used with the imx6q-logicpd board has an integrated
> > ili2117a touch controller connected to i2c1.
> >
> > This patch adds the node to enable this feature.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> > ---
> > ili2117 support is scheduled to be introduced for Kernel v5.5.
> >
> > V2:  Change node to touchscreen@26 and move comment about 5.5 to under the dashes
> >
> > diff --git a/arch/arm/boot/dts/imx6q-logicpd.dts b/arch/arm/boot/dts/imx6q-logicpd.dts
> > index d96ae54be338..7a3d1d3e54a9 100644
> > --- a/arch/arm/boot/dts/imx6q-logicpd.dts
> > +++ b/arch/arm/boot/dts/imx6q-logicpd.dts
> > @@ -73,6 +73,16 @@
> >       status = "okay";
> >  };
> >
> > +&i2c1 {
> > +     touchscreen@26 {
> > +             compatible = "ilitek,ili2117";
> > +             reg = <0x26>;
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_touchscreen>;
>
> This phandle already exists?

Yes it does exist, but it probably should not have been since there
was no user of it.  At least this fixes that.  :-)

adam

>
> Regards,
>   Marco
>
> > +             interrupts-extended = <&gpio1 6 IRQ_TYPE_EDGE_RISING>;
> > +     };
> > +};
> > +
> >  &ldb {
> >       status = "okay";
> >
> > --
> > 2.20.1
> >
> >
> >
>
> --
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |